Skip to contentSkip to conversation

cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

PATCH Superseded Erwan Velu 3 participants 5 messages Feb 11, 2019 – Feb 12, 2019

Subsystems (2)

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Erwan Velu

author
#0 lore raw

PATCH v3 1/1 cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

The init code path have several execeptions where the module can decide not to load. As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is not reachable. The initialisation code is neither verbose of the reason why it did choose to prematurely exit.

This situation leads to situation where its difficult for a user to determine, on a given platform, why the driver didn't loaded properly.

This patch is about reporting to the user the reason/context why the driver failed to load. That is a precious hint when debugging a platform.

---
 drivers/cpufreq/intel_pstate.c | 36 ++++++++++++++++++++++++++--------
 1 file changed, 28 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +28 -8
index dd66decf2087..ba2e2aee6c20 100644
@@ -2475,6 +2475,7 @@ static bool __init intel_pstate_no_acpi_pss(void)
 		kfree(pss);
 	}
 
+	pr_info("Cannot detect ACPI PSS");
 	return true;
 }
 
@@ -2484,10 +2485,16 @@ static bool __init intel_pstate_no_acpi_pcch(void)
 	acpi_handle handle;
 
 	status = acpi_get_handle(NULL, "\\_SB", &handle);
-	if (ACPI_FAILURE(status))
+	if (ACPI_FAILURE(status)) {
+		pr_info("Cannot detect ACPI SB");
 		return true;
+	}
 
-	return !acpi_has_method(handle, "PCCH");
+	status = acpi_has_method(handle, "PCCH");
+	if (!status) {
+		pr_info("Cannot detect ACPI PCCH");
+	}
+	return !status;
 }
 
 static bool __init intel_pstate_has_acpi_ppc(void)
@@ -2502,6 +2509,7 @@ static bool __init intel_pstate_has_acpi_ppc(void)
 		if (acpi_has_method(pr->handle, "_PPC"))
 			return true;
 	}
+	pr_info("Cannot detect ACPI PPC");
 	return false;
 }
 
@@ -2592,8 +2600,10 @@ static int __init intel_pstate_init(void)
 	const struct x86_cpu_id *id;
 	int rc;
 
-	if (no_load)
+	if (no_load) {
+		pr_info("disabling as per user-request\n");
 		return -ENODEV;
+	}
 
 	id = x86_match_cpu(hwp_support_ids);
 	if (id) {
@@ -2606,31 +2616,41 @@ static int __init intel_pstate_init(void)
 		}
 	} else {
 		id = x86_match_cpu(intel_pstate_cpu_ids);
-		if (!id)
+		if (!id) {
+			pr_warn("CPU ID is not in the list of supported devices\n");
 			return -ENODEV;
+		}
 
 		copy_cpu_funcs((struct pstate_funcs *)id->driver_data);
 	}
 
-	if (intel_pstate_msrs_not_valid())
+	if (intel_pstate_msrs_not_valid()) {
+		pr_warn("Cannot enable driver as per invalid MSRs\n");
 		return -ENODEV;
+	}
 
 hwp_cpu_matched:
 	/*
 	 * The Intel pstate driver will be ignored if the platform
 	 * firmware has its own power management modes.
 	 */
-	if (intel_pstate_platform_pwr_mgmt_exists())
+	if (intel_pstate_platform_pwr_mgmt_exists()) {
+		pr_warn("Platform already taking care of power management\n");
 		return -ENODEV;
+	}
 
-	if (!hwp_active && hwp_only)
+	if (!hwp_active && hwp_only) {
+		pr_warn("HWP not present\n");
 		return -ENOTSUPP;
+	}
 
 	pr_info("Intel P-state driver initializing\n");
 
 	all_cpu_data = vzalloc(array_size(sizeof(void *), num_possible_cpus()));
-	if (!all_cpu_data)
+	if (!all_cpu_data) {
+		pr_warn("Cannot allocate memory\n");
 		return -ENOMEM;
+	}
 
 	intel_pstate_request_control_from_smm();
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · Erwan Velu

The init code path have several execeptions where the module can decide not to load.
As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is not reachable.
The initialisation code is neither verbose of the reason why it did choose to prematurely exit.

Quoted 7 lines

This situation leads to situation where its difficult for a user to determine,
on a given platform, why the driver didn't loaded properly.

This patch is about reporting to the user the reason/context why the driver failed to load.
That is a precious hint when debugging a platform.

pr_info and pr_warn are too strong for this debug use case. Anytime someone see some error in dmesg, we have an additional work to explain that that is not a problem to an average user. So this is an maintenance overhead for the purpose of debugging. Only few users who are really trying to debug, will care for these errors. For them pr_debug will be enough, we have other pr_debugs which will be helpful to root cause the issue, even if driver loads.

Also when some user disabled intel_pstate via kernel command line, additional debug message is not useful.

Thanks,
Srinivas

Quoted 112 lines
---
 drivers/cpufreq/intel_pstate.c | 36 ++++++++++++++++++++++++++----
----
 1 file changed, 28 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +9 -2
index dd66decf2087..ba2e2aee6c20 100644
@@ -2475,6 +2475,7 @@ static bool __init
 intel_pstate_no_acpi_pss(void)
 		kfree(pss);
 	}
 
+	pr_info("Cannot detect ACPI PSS");
 	return true;
 }
@@ -2484,10 +2485,16 @@ static bool __init
 intel_pstate_no_acpi_pcch(void)
 	acpi_handle handle;
 
 	status = acpi_get_handle(NULL, "\\_SB", &handle);
-	if (ACPI_FAILURE(status))
+	if (ACPI_FAILURE(status)) {
+		pr_info("Cannot detect ACPI SB");
 		return true;
+	}
 
-	return !acpi_has_method(handle, "PCCH");
+	status = acpi_has_method(handle, "PCCH");
+	if (!status) {
+		pr_info("Cannot detect ACPI PCCH");
+	}
+	return !status;
 }
 

static bool __init intel_pstate_has_acpi_ppc(void)

drivers/cpufreq/intel_pstate.c +19 -6
@@ -2502,6 +2509,7 @@ static bool __init
 intel_pstate_has_acpi_ppc(void)
 		if (acpi_has_method(pr->handle, "_PPC"))
 			return true;
 	}
+	pr_info("Cannot detect ACPI PPC");
 	return false;
 }
@@ -2592,8 +2600,10 @@ static int __init intel_pstate_init(void)
 	const struct x86_cpu_id *id;
 	int rc;
 
-	if (no_load)
+	if (no_load) {
+		pr_info("disabling as per user-request\n");
 		return -ENODEV;
+	}
 
 	id = x86_match_cpu(hwp_support_ids);
 	if (id) {
@@ -2606,31 +2616,41 @@ static int __init intel_pstate_init(void)
 		}
 	} else {
 		id = x86_match_cpu(intel_pstate_cpu_ids);
-		if (!id)
+		if (!id) {
+			pr_warn("CPU ID is not in the list of supported
 devices\n");
 			return -ENODEV;
+		}
 
 		copy_cpu_funcs((struct pstate_funcs *)id->driver_data);
 	}
 
-	if (intel_pstate_msrs_not_valid())
+	if (intel_pstate_msrs_not_valid()) {
+		pr_warn("Cannot enable driver as per invalid MSRs\n");
 		return -ENODEV;
+	}
 
 hwp_cpu_matched:
 	/*
 	 * The Intel pstate driver will be ignored if the platform
 	 * firmware has its own power management modes.
 	 */
-	if (intel_pstate_platform_pwr_mgmt_exists())
+	if (intel_pstate_platform_pwr_mgmt_exists()) {
+		pr_warn("Platform already taking care of power
 management\n");
 		return -ENODEV;
+	}
 
-	if (!hwp_active && hwp_only)
+	if (!hwp_active && hwp_only) {
+		pr_warn("HWP not present\n");
 		return -ENOTSUPP;
+	}
 
 	pr_info("Intel P-state driver initializing\n");
 
 	all_cpu_data = vzalloc(array_size(sizeof(void *),
 num_possible_cpus()));
-	if (!all_cpu_data)
+	if (!all_cpu_data) {
+		pr_warn("Cannot allocate memory\n");
 		return -ENOMEM;
+	}

intel_pstate_request_control_from_smm();

author
#2 lore raw

I understand your concern but I'd like to defend my use case ;)

I was in a case where I didn't noticed that intel_pstate did engaged after a kernel upgrade while it didn't before.
But there strictly no information message why the driver took the decision not to load (aka considering there is already a power management system engaged).

That had a major impact on the system performance without _any_ notice.

So I would have found helpful to have informative message about the reason why it didn't loaded.
A intel_pstate is usually set (and by default) to Y, which prevent debugging this live and enforce a kernel reboot which was an issue in my production case.
So I would agree to put some details in pr_debug() but keep the important return path being explicit to help user understanding (withtout triggering the debug) why it did behave like that giving serious hints (kernel, bios, fw update).

Would you agree if I update the patch this way ?
Thx !
Erwan,

Quoted 143 lines · Srinivas Pandruvada
Quoted 7 lines · Erwan Velu

The init code path have several execeptions where the module can decide not to load.
As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is not reachable.
The initialisation code is neither verbose of the reason why it did choose to prematurely exit.

Quoted 7 lines

This situation leads to situation where its difficult for a user to determine,
on a given platform, why the driver didn't loaded properly.

This patch is about reporting to the user the reason/context why the driver failed to load.
That is a precious hint when debugging a platform.

pr_info and pr_warn are too strong for this debug use case. Anytime someone see some error in dmesg, we have an additional work to explain that that is not a problem to an average user. So this is an maintenance overhead for the purpose of debugging. Only few users who are really trying to debug, will care for these errors. For them pr_debug will be enough, we have other pr_debugs which will be helpful to root cause the issue, even if driver loads.

Also when some user disabled intel_pstate via kernel command line, additional debug message is not useful.

Thanks,
Srinivas

Quoted 112 lines
---
 drivers/cpufreq/intel_pstate.c | 36 ++++++++++++++++++++++++++----
----
 1 file changed, 28 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +9 -2
index dd66decf2087..ba2e2aee6c20 100644
@@ -2475,6 +2475,7 @@ static bool __init
 intel_pstate_no_acpi_pss(void)
              kfree(pss);
      }
 
+     pr_info("Cannot detect ACPI PSS");
      return true;
 }
@@ -2484,10 +2485,16 @@ static bool __init
 intel_pstate_no_acpi_pcch(void)
      acpi_handle handle;
 
      status = acpi_get_handle(NULL, "\\_SB", &handle);
-     if (ACPI_FAILURE(status))
+     if (ACPI_FAILURE(status)) {
+             pr_info("Cannot detect ACPI SB");
              return true;
+     }
 
-     return !acpi_has_method(handle, "PCCH");
+     status = acpi_has_method(handle, "PCCH");
+     if (!status) {
+             pr_info("Cannot detect ACPI PCCH");
+     }
+     return !status;
 }
 

static bool __init intel_pstate_has_acpi_ppc(void)

drivers/cpufreq/intel_pstate.c +19 -6
@@ -2502,6 +2509,7 @@ static bool __init
 intel_pstate_has_acpi_ppc(void)
              if (acpi_has_method(pr->handle, "_PPC"))
                      return true;
      }
+     pr_info("Cannot detect ACPI PPC");
      return false;
 }
@@ -2592,8 +2600,10 @@ static int __init intel_pstate_init(void)
      const struct x86_cpu_id *id;
      int rc;
 
-     if (no_load)
+     if (no_load) {
+             pr_info("disabling as per user-request\n");
              return -ENODEV;
+     }
 
      id = x86_match_cpu(hwp_support_ids);
      if (id) {
@@ -2606,31 +2616,41 @@ static int __init intel_pstate_init(void)
              }
      } else {
              id = x86_match_cpu(intel_pstate_cpu_ids);
-             if (!id)
+             if (!id) {
+                     pr_warn("CPU ID is not in the list of supported
 devices\n");
                      return -ENODEV;
+             }
 
              copy_cpu_funcs((struct pstate_funcs *)id->driver_data);
      }
 
-     if (intel_pstate_msrs_not_valid())
+     if (intel_pstate_msrs_not_valid()) {
+             pr_warn("Cannot enable driver as per invalid MSRs\n");
              return -ENODEV;
+     }
 
 hwp_cpu_matched:
      /*
       * The Intel pstate driver will be ignored if the platform
       * firmware has its own power management modes.
       */
-     if (intel_pstate_platform_pwr_mgmt_exists())
+     if (intel_pstate_platform_pwr_mgmt_exists()) {
+             pr_warn("Platform already taking care of power
 management\n");
              return -ENODEV;
+     }
 
-     if (!hwp_active && hwp_only)
+     if (!hwp_active && hwp_only) {
+             pr_warn("HWP not present\n");
              return -ENOTSUPP;
+     }
 
      pr_info("Intel P-state driver initializing\n");
 
      all_cpu_data = vzalloc(array_size(sizeof(void *),
 num_possible_cpus()));
-     if (!all_cpu_data)
+     if (!all_cpu_data) {
+             pr_warn("Cannot allocate memory\n");
              return -ENOMEM;
+     }
      intel_pstate_request_control_from_smm();
#3 lore raw
Quoted 8 lines · Erwan Velu

I understand your concern but I'd like to defend my use case ;)

I was in a case where I didn't noticed that intel_pstate did engaged after a kernel upgrade while it didn't before.
But there strictly no information message why the driver took the decision not to load (aka considering there is already a power management system engaged).

Quoted 8 lines

That had a major impact on the system performance without _any_ notice.

So I would have found helpful to have informative message about the reason why it didn't loaded.
A intel_pstate is usually set (and by default) to Y, which prevent debugging this live and enforce a kernel reboot which was an issue in my production case.

To know if the intel_pstate in control, you can look at:
#cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver

So if it is not loaded and Intel intend to support a processor model with intel_pstate, then OEM's platform_power_management policy can override. So we can add one pr_info to show that driver can't be loaded because of platform
intel_pstate_platform_pwr_mgmt_exists(), return true.

If HWP is used we already have a pr_info. If HWP is present it will always be used unless user overrides.

The cases where a memory allocation fails you will see other warnings in the system, so don't need to add in driver. Also if someone explcitly using kernel command line to either disable or control features, user knows what he is doing.

So no need of pr_warn or pr_info except one case for platform mower management. The others are debug messages only.

Thanks,
Srinivas

Quoted 165 lines

So I would agree to put some details in pr_debug() but keep the important return path being explicit to help user understanding (withtout triggering the debug) why it did behave like that giving serious hints (kernel, bios, fw update).

Would you agree if I update the patch this way ?
Thx !
Erwan,

Quoted 154 lines · Srinivas Pandruvada
Quoted 14 lines · Erwan Velu

The init code path have several execeptions where the module can decide not to load.
As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is
not reachable.
The initialisation code is neither verbose of the reason why it did
choose to prematurely exit.

This situation leads to situation where its difficult for a user to
determine,
on a given platform, why the driver didn't loaded properly.

Quoted 4 lines

This patch is about reporting to the user the reason/context why the
driver failed to load.
That is a precious hint when debugging a platform.

pr_info and pr_warn are too strong for this debug use case. Anytime someone see some error in dmesg, we have an additional work to explain
that that is not a problem to an average user. So this is an maintenance overhead for the purpose of debugging. Only few users who
are really trying to debug, will care for these errors. For them pr_debug will be enough, we have other pr_debugs which will be helpful
to root cause the issue, even if driver loads.

Also when some user disabled intel_pstate via kernel command line, additional debug message is not useful.

Thanks,
Srinivas

Quoted 116 lines
---
 drivers/cpufreq/intel_pstate.c | 36 ++++++++++++++++++++++++++
----
----
 1 file changed, 28 insertions(+), 8 deletions(-)
drivers/cpufreq/intel_pstate.c +9 -2
index dd66decf2087..ba2e2aee6c20 100644
@@ -2475,6 +2475,7 @@ static bool __init
 intel_pstate_no_acpi_pss(void)
              kfree(pss);
      }
 
+     pr_info("Cannot detect ACPI PSS");
      return true;
 }
@@ -2484,10 +2485,16 @@ static bool __init
 intel_pstate_no_acpi_pcch(void)
      acpi_handle handle;
 
      status = acpi_get_handle(NULL, "\\_SB", &handle);
-     if (ACPI_FAILURE(status))
+     if (ACPI_FAILURE(status)) {
+             pr_info("Cannot detect ACPI SB");
              return true;
+     }
 
-     return !acpi_has_method(handle, "PCCH");
+     status = acpi_has_method(handle, "PCCH");
+     if (!status) {
+             pr_info("Cannot detect ACPI PCCH");
+     }
+     return !status;
 }
 

static bool __init intel_pstate_has_acpi_ppc(void)

drivers/cpufreq/intel_pstate.c +6 -2
@@ -2502,6 +2509,7 @@ static bool __init
 intel_pstate_has_acpi_ppc(void)
              if (acpi_has_method(pr->handle, "_PPC"))
                      return true;
      }
+     pr_info("Cannot detect ACPI PPC");
      return false;
 }
@@ -2592,8 +2600,10 @@ static int __init intel_pstate_init(void)
      const struct x86_cpu_id *id;
      int rc;
 
-     if (no_load)
+     if (no_load) {
+             pr_info("disabling as per user-request\n");
              return -ENODEV;
+     }
 
      id = x86_match_cpu(hwp_support_ids);
      if (id) {
@@ -2606,31 +2616,41 @@ static int __init intel_pstate_init(void)
              }
      } else {
              id = x86_match_cpu(intel_pstate_cpu_ids);
-             if (!id)
+             if (!id) {
+                     pr_warn("CPU ID is not in the list of

supported

devices\n");
                      return -ENODEV;

+ }

copy_cpu_funcs((struct pstate_funcs *)id-

Quoted 1 line

driver_data);

      }
drivers/cpufreq/intel_pstate.c +2 -1
-     if (intel_pstate_msrs_not_valid())
+     if (intel_pstate_msrs_not_valid()) {
+             pr_warn("Cannot enable driver as per invalid
MSRs\n");
              return -ENODEV;
drivers/cpufreq/intel_pstate.c +3 -1
+     }
 
 hwp_cpu_matched:
      /*
       * The Intel pstate driver will be ignored if the platform
       * firmware has its own power management modes.
       */
-     if (intel_pstate_platform_pwr_mgmt_exists())
+     if (intel_pstate_platform_pwr_mgmt_exists()) {
+             pr_warn("Platform already taking care of power
management\n");
              return -ENODEV;
drivers/cpufreq/intel_pstate.c +4 -1
+     }
 
-     if (!hwp_active && hwp_only)
+     if (!hwp_active && hwp_only) {
+             pr_warn("HWP not present\n");
              return -ENOTSUPP;
+     }
 
      pr_info("Intel P-state driver initializing\n");
 
      all_cpu_data = vzalloc(array_size(sizeof(void *),

num_possible_cpus()));

drivers/cpufreq/intel_pstate.c +3 -1
-     if (!all_cpu_data)
+     if (!all_cpu_data) {
+             pr_warn("Cannot allocate memory\n");
              return -ENOMEM;
+     }
 
      intel_pstate_request_control_from_smm();
#4 lore raw

Le 12/02/2019 à 00:17, Srinivas Pandruvada a écrit :

Quoted 9 lines

[...]
To know if the intel_pstate in control, you can look at:
#cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver

So if it is not loaded and Intel intend to support a processor model with intel_pstate, then OEM's platform_power_management policy can override. So we can add one pr_info to show that driver can't be loaded because of platform
intel_pstate_platform_pwr_mgmt_exists(), return true.

Agreed.

But I do think the intel_pstate_msrs_not_valid() case also deserves a pr_warn() as this is a premature exit because of some hardware settings.

Quoted 10 lines

If HWP is used we already have a pr_info. If HWP is present it will always be used unless user overrides.

The cases where a memory allocation fails you will see other warnings in the system, so don't need to add in driver. Also if someone explcitly using kernel command line to either disable or control features, user knows what he is doing.

So no need of pr_warn or pr_info except one case for platform mower management. The others are debug messages only.

Ack.

I'm sending a v4 this way.

Thanks for the review & discussions.

Erwan,