arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
PATCH 1/1 arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep config.
--- arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi +1 -1
@@ -139,7 +139,7 @@ }; pinconf { - pins = "gpio4", "gpiio5", "gpio6", "gpio7"; + pins = "gpio4", "gpio5", "gpio6", "gpio7"; drive-strength = <2>; bias-disable; };
Signature · 1 line
2.20.1
Quoted 6 lines · Johan Hovold
Fix "gpiio5" typo in the (currently unused)
blsp2_uart14-pin sleep config.Fixes 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")Cc Srinivas Kandagatla <[email protected]>Signed-off-by Johan Hovold <[email protected]>
I can't seem to find this one in your tree (or linux-next), Andy. Lost or simply not applied yet?
Johan
Quoted 15 lines · Johan Hovold
Fix "gpiio5" typo in the (currently unused)
blsp2_uart14-pin sleep config.Fixes 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")Cc Srinivas Kandagatla <[email protected]>Signed-off-by Johan Hovold <[email protected]>--- arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/qcom/msm8996-pins.dtsi +0
-0
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi line 145
Quoted 8 lines
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi +1
-1@@ -139,7 +139,7 @@ }; pinconf { - pins = "gpio4", "gpiio5", "gpio6", "gpio7"; + pins = "gpio4", "gpio5", "gpio6", "gpio7"; drive-strength = <2>; bias-disable; };
I took one in slightly older than this one. However, it doesn't have the fixes line.
commit ff10032fb309d0baa0b79e28009bf154de08d341
Author: Jakob Wuhrer <[email protected]> Date: Fri Dec 14 18:01:30 2018 +0100
arm64: dts: qcom: Correct "gpiio" typo in msm8996-pins
gpiio5 is missspelt in msm8996-pins.dtsi, fix that.
Regards,
Andy
Quoted 33 lines · Andy Gross
Quoted 15 lines · Johan Hovold
Fix "gpiio5" typo in the (currently unused)
blsp2_uart14-pin sleep config.Fixes 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")Cc Srinivas Kandagatla <[email protected]>Signed-off-by Johan Hovold <[email protected]>--- arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/qcom/msm8996-pins.dtsi +0
-0arch/arm64/boot/dts/qcom/msm8996-pins.dtsi line 145
Quoted 8 lines
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi +1
-1@@ -139,7 +139,7 @@ }; pinconf { - pins = "gpio4", "gpiio5", "gpio6", "gpio7"; + pins = "gpio4", "gpio5", "gpio6", "gpio7"; drive-strength = <2>; bias-disable; };I took one in slightly older than this one. However, it doesn't have the fixes line.
commit
ff10032fb309d0baa0b79e28009bf154de08d341Author: Jakob Wuhrer <[email protected]> Date: Fri Dec 14 18:01:30 2018 +0100
Quoted 7 lines
arm64: dts: qcom: Correct "gpiio" typo in msm8996-pins
gpiio5 is missspelt in
msm8996-pins.dtsi, fix that.Signed-off-by Jakob Wuhrer <[email protected]>Signed-off-by Bjorn Andersson <[email protected]>Signed-off-by Andy Gross <[email protected]>
That's funny, submitted six days before mine for a 2+ year old issue.
The typo would prevent the pin from being reconfigured (hence the stable tag), but at least you'd get a runtime warning when trying to set this config.
Johan
Quoted 1 line · Johan Hovold
That's funny, submitted six days before mine for a 2+ year old issue.
I can't tell you how many times I've seen this happen (to myself and others).
Andy