tpm: remove tpm_dev_wq_lock
Subsystems (2)
PATCH 1/1 tpm: remove tpm_dev_wq_lock
Added in commit
9e1b74a63f776 ("tpm: add support for nonblocking operation")
but never actually used it.
--- drivers/char/tpm/tpm-dev-common.c | 1 - 1 file changed, 1 deletion(-)
drivers/char/tpm/tpm-dev-common.c +0 -1
@@ -25,7 +25,6 @@#include "tpm-dev.h" static struct workqueue_struct *tpm_dev_wq; -static DEFINE_MUTEX (tpm_dev_wq_lock);static void tpm_async_work (struct work_struct *work) {
Signature · 1 line
2.20.1
Quoted 10 lines · Sebastian Andrzej Siewior
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>
You should use Fixes-tag e.g.
/Jarkko
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Sebastian Andrzej Siewior
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Quoted 8 lines
Quoted 4 lines
Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>You should use Fixes-tag e.g.
Fixes <12 first chars from SHA-1> ("<short summary>")
Is this the only reason why it has not been picked up? A fixes line which triggers stable backports for something that does need to be backported?
Quoted 1 line
/Jarkko
Sebastian
Quoted 13 lines · Sebastian Andrzej Siewior
Quoted 12 lines · Jarkko Sakkinen
Quoted 10 lines · Sebastian Andrzej Siewior
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>
Quoted 7 lines
Quoted 3 lines
You should use Fixes-tag e.g.
Fixes <12 first chars from SHA-1> ("<short summary>")Is this the only reason why it has not been picked up? A fixes line which triggers stable backports for something that does need to be backported?
Fully agree with you. Frankly, I don't really remember anymore why I responded that way. My guess is that I responded that to a worng patch.
Please just ping immediatelly. Sometimes when dealing with dozens of patches this kind of human error might happen.
In any case, the patch is applied.
/Jarkko
Quoted 22 lines · Jarkko Sakkinen
Quoted 13 lines · Sebastian Andrzej Siewior
Quoted 12 lines · Jarkko Sakkinen
Quoted 10 lines · Sebastian Andrzej Siewior
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>Quoted 7 lines
Quoted 3 lines
You should use Fixes-tag e.g.
Fixes <12 first chars from SHA-1> ("<short summary>")Is this the only reason why it has not been picked up? A fixes line which triggers stable backports for something that does need to be backported?
Quoted 7 lines
Fully agree with you. Frankly, I don't really remember anymore why I responded that way. My guess is that I responded that to a worng patch.
Please just ping immediatelly. Sometimes when dealing with dozens of patches this kind of human error might happen.
In any case, the patch is applied.
OK, so. Gave a relook at this:
This gives checkpatch.pl error:
0012-tpm-remove-tpm_dev_wq_lock.patch
-------------------------------------
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9e1b74a63f77 ("tpm: add support for nonblocking operation")' #8:
9e1b74a63f776 ("tpm: add support for nonblocking operation")
total: 1 errors, 0 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Please send me a new patch with a legit fixes line. It is a fix to regression even if it is a cosmetic one.
I'll drop the current patch from my tree and apply a new one once I get it from you.
Thanks.
/Jarkko
Quoted 49 lines · Jarkko Sakkinen
Quoted 22 lines · Jarkko Sakkinen
Quoted 13 lines · Sebastian Andrzej Siewior
Quoted 12 lines · Jarkko Sakkinen
Quoted 10 lines · Sebastian Andrzej Siewior
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>Quoted 7 lines
Quoted 3 lines
You should use Fixes-tag e.g.
Fixes <12 first chars from SHA-1> ("<short summary>")Is this the only reason why it has not been picked up? A fixes line which triggers stable backports for something that does need to be backported?
Quoted 7 lines
Fully agree with you. Frankly, I don't really remember anymore why I responded that way. My guess is that I responded that to a worng patch.
Please just ping immediatelly. Sometimes when dealing with dozens of patches this kind of human error might happen.
In any case, the patch is applied.
OK, so. Gave a relook at this:
This gives checkpatch.pl error:
0012-tpm-remove-tpm_dev_wq_lock.patch
-------------------------------------
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit9e1b74a63f77("tpm: add support for nonblocking operation")' #8:
9e1b74a63f776("tpm: add support for nonblocking operation")total: 1 errors, 0 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.Please send me a new patch with a legit fixes line. It is a fix to regression even if it is a cosmetic one.
Quoted 6 lines
I'll drop the current patch from my tree and apply a new one once I get it from you.
Thanks.
/Jarkko
AFAIK cc stable triggers stable backport, not fixes line alone (not 100% sure about this though). Anyway even my original response was meant to this patch I recall now that I bumped into that checkpatch error.
/Jarkko
sorry for that late reply, was traveling…
Quoted 12 lines · Jarkko Sakkinen
Quoted 12 lines
OK, so. Gave a relook at this:
This gives checkpatch.pl error:
0012-tpm-remove-tpm_dev_wq_lock.patch
-------------------------------------
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit9e1b74a63f77("tpm: add support for nonblocking operation")' #8:
9e1b74a63f776("tpm: add support for nonblocking operation")total: 1 errors, 0 warnings, 7 lines checked
Quoted 8 lines
Quoted 8 lines
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.Please send me a new patch with a legit fixes line. It is a fix to regression even if it is a cosmetic one.
I'll drop the current patch from my tree and apply a new one once I get it from you.
Can you please explain what is wrong with that one? It is exactly as suggested by the error line.
Quoted 8 lines
Quoted 3 lines
Thanks.
/Jarkko
AFAIK cc stable triggers stable backport, not fixes line alone (not 100% sure about this though). Anyway even my original response was meant to this patch I recall now that I bumped into that checkpatch error.
The cc: for stable and fixes are high indicators for it to be considered. These days even a few keywords in the commit message might let Sasha's script decide to pick/suggest a patch for stable.
Quoted 1 line
/Jarkko
Sebastian
Quoted 36 lines · Sebastian Andrzej Siewior
sorry for that late reply, was traveling…
Quoted 12 lines · Jarkko Sakkinen
Quoted 12 lines
OK, so. Gave a relook at this:
This gives checkpatch.pl error:
0012-tpm-remove-tpm_dev_wq_lock.patch
-------------------------------------
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit9e1b74a63f77("tpm: add support for nonblocking operation")' #8:
9e1b74a63f776("tpm: add support for nonblocking operation")total: 1 errors, 0 warnings, 7 lines checked
Quoted 8 lines
Quoted 8 lines
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.Please send me a new patch with a legit fixes line. It is a fix to regression even if it is a cosmetic one.
I'll drop the current patch from my tree and apply a new one once I get it from you.
Can you please explain what is wrong with that one? It is exactly as suggested by the error line.
Quoted 8 lines
Quoted 3 lines
Thanks.
/Jarkko
AFAIK cc stable triggers stable backport, not fixes line alone (not 100% sure about this though). Anyway even my original response was meant to this patch I recall now that I bumped into that checkpatch error.
Quoted 7 lines
The cc: for stable and fixes are high indicators for it to be considered. These days even a few keywords in the commit message might let Sasha's script decide to pick/suggest a patch for stable.
Quoted 1 line
/Jarkko
Sebastian
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
Added in
commit 9e1b74a63f776 ("tpm: add support for nonblocking operation")
but never actually used it.
Quoted 2 lines · Jerry Snitselaar
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
That would explain it. That is however not what the TIP tree and other people do not to mention that reading wise it makes sense to keep the word `commit' as part of the sentence and add the hash in the next line.
Quoted 11 lines
Added in
commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Fixes 9e1b74a63f776 ("tpm: add support for nonblocking operation")Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>
Sebastian
Quoted 8 lines · Sebastian Andrzej Siewior
Quoted 2 lines · Jerry Snitselaar
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
That would explain it. That is however not what the TIP tree and other people do not to mention that reading wise it makes sense to keep the word `commit' as part of the sentence and add the hash in the next line.
Yes it reads better. What about the following?
Added in commit 9e1b74a63f776 ("tpm: add support for nonblocking operation"), but never actually used it.
And then add the Fixes: line above the Cc: and Signed-off-by: ?
Quoted 13 lines
Quoted 11 lines
Added in
commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
Fixes 9e1b74a63f776 ("tpm: add support for nonblocking operation")Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>Signed-off-by Sebastian Andrzej Siewior <[email protected]>Sebastian
Quoted 10 lines · Jerry Snitselaar
Quoted 8 lines · Sebastian Andrzej Siewior
Quoted 2 lines · Jerry Snitselaar
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
That would explain it. That is however not what the TIP tree and other people do not to mention that reading wise it makes sense to keep the word `commit' as part of the sentence and add the hash in the next line.
Quoted 6 lines
Yes it reads better. What about the following?
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation"), but never actually used it.And then add the Fixes: line above the Cc: and Signed-off-by: ?
Can please get over with? It is a simple patch. It has simple description.
Sebastian
Quoted 13 lines · Sebastian Andrzej Siewior
Quoted 12 lines · Jerry Snitselaar
Quoted 8 lines · Sebastian Andrzej Siewior
Quoted 2 lines · Jerry Snitselaar
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
That would explain it. That is however not what the TIP tree and other people do not to mention that reading wise it makes sense to keep the word `commit' as part of the sentence and add the hash in the next line.
Yes it reads better. What about the following?
Quoted 7 lines
Quoted 4 lines
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation"), but never actually used it.And then add the Fixes: line above the Cc: and Signed-off-by: ?
Can please get over with? It is a simple patch. It has simple description.
https://lore.kernel.org/linux-integrity/[email protected]/
I'm also cool with cc stable as long as the commit is message has the correct format.
/Jarkko
Quoted 19 lines · Jarkko Sakkinen
Quoted 18 lines · Sebastian Andrzej Siewior
Quoted 16 lines · Jerry Snitselaar
Quoted 8 lines · Sebastian Andrzej Siewior
Quoted 2 lines · Jerry Snitselaar
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
That would explain it. That is however not what the TIP tree and other people do not to mention that reading wise it makes sense to keep the word `commit' as part of the sentence and add the hash in the next line.
Yes it reads better. What about the following?
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation"), but never actually used it.And then add the Fixes: line above the Cc: and Signed-off-by: ?
Quoted 7 lines
Quoted 2 lines
Can please get over with? It is a simple patch. It has simple description.
https://lore.kernel.org/linux-integrity/[email protected]/
I'm also cool with cc stable as long as the commit is message has the correct format.
This is _really_ getting ridiculous. Holding back a simple patch just because checkpatch says that the word `commit' is not in a new line. It is more readable that way not to mention line with the commit id is getting really long. This is a stupid checkpatch rule which is enforced here.
Quoted 1 line
/Jarkko
Sebastian
Quoted 25 lines · Sebastian Andrzej Siewior
Quoted 24 lines · Jarkko Sakkinen
Quoted 13 lines · Sebastian Andrzej Siewior
Quoted 12 lines · Jerry Snitselaar
Quoted 8 lines · Sebastian Andrzej Siewior
Quoted 2 lines · Jerry Snitselaar
It looks like checkpatch is expecting the word commit to precede the hash on the same line. I get no errors with the following:
That would explain it. That is however not what the TIP tree and other people do not to mention that reading wise it makes sense to keep the word `commit' as part of the sentence and add the hash in the next line.
Yes it reads better. What about the following?
Quoted 7 lines
Quoted 4 lines
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation"), but never actually used it.And then add the Fixes: line above the Cc: and Signed-off-by: ?
Can please get over with? It is a simple patch. It has simple description.
Quoted 8 lines
Quoted 2 lines
I'm also cool with cc stable as long as the commit is message has the correct format.
This is _really_ getting ridiculous. Holding back a simple patch just because checkpatch says that the word `commit' is not in a new line. It is more readable that way not to mention line with the commit id is getting really long. This is a stupid checkpatch rule which is enforced here.
I'm not sure why formatting a commit message properly is ridicilous.
If it is a bug fix, then it should have fixes tag.
/Jarkko
Quoted 5 lines · Sebastian Andrzej Siewior
Added in commit
9e1b74a63f776("tpm: add support for nonblocking operation")but never actually used it.
It was used in one of the early versions of this patch
https://patchwork.kernel.org/patch/10559151/
Not needed later.
Thanks,
Signature · 1 line
Tadeusz
PATCH v2 1/1 tpm: Remove tpm_dev_wq_lock
In reply to Sebastian Andrzej SiewiorFrom: Sebastian Andrzej Siewior <[email protected]>
Never used since it was added.
---
V2: Reworded the change log so the !&!%#$ dispute over the formatting
is not longer in the way of getting this triviality done.
--- drivers/char/tpm/tpm-dev-common.c | 1 - 1 file changed, 1 deletion(-)
drivers/char/tpm/tpm-dev-common.c +0 -1
@@ -20,7 +20,6 @@#include "tpm-dev.h" static struct workqueue_struct *tpm_dev_wq; -static DEFINE_MUTEX (tpm_dev_wq_lock);static ssize_t tpm_dev_transmit (struct tpm_chip *chip,struct tpm_space *space,u8 *buf,size_t bufsiz)
Jarkko Sakkinen
maintainerRe: [PATCH V2] tpm: Remove tpm_dev_wq_lock
Quoted 4 lines · Thomas Gleixner
From: Sebastian Andrzej Siewior <[email protected]>
Never used since it was added.
Hi, apologies for this latency. I was in vacation during 12/14-12/20 last month, and after that Christmas and New Year mixed up schedules a bit.
Applying today, thanks.
/Jarkko
Quoted 25 lines
Fixes 9e1b74a63f776 ("tpm: add support for nonblocking operation")Signed-off-by Sebastian Andrzej Siewior <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>Cc Jason Gunthorpe <[email protected]>Cc Philip Tricca <[email protected]>Cc Tadeusz Struk <[email protected]>Cc Jarkko Sakkinen <[email protected]>---
V2: Reworded the change log so the !&!%#$ dispute over the formatting
is not longer in the way of getting this triviality done.--- drivers/char/tpm/tpm-dev-common.c | 1 - 1 file changed, 1 deletion(-)drivers/char/tpm/tpm-dev-common.c +0
-1@@ -20,7 +20,6 @@#include "tpm-dev.h" static struct workqueue_struct *tpm_dev_wq; -static DEFINE_MUTEX (tpm_dev_wq_lock);static ssize_t tpm_dev_transmit (struct tpm_chip *chip,struct tpm_space *space,u8 *buf,size_t bufsiz)