Skip to contentSkip to conversation

usb: phy: twl6030-usb: fix possible use-after-free on remove

PATCH New Sven Van Asbroeck 1 participant 1 message Feb 11, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: phy: twl6030-usb: fix possible use-after-free on remove

In remove(), use cancel_delayed_work_sync() to cancel the delayed work. Otherwise there's a chance that this work will continue to run until after the device has been removed.

This issue was detected with the help of Coccinelle.

Cc Tony Lindgren <[email protected]>
Cc Bin Liu <[email protected]>
Fixes b6a619a883c3 ("usb: phy: Check initial state for twl6030")
---
 drivers/usb/phy/phy-twl6030-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/phy/phy-twl6030-usb.c +1 -1
index 183550b63faa..dade34d70419 100644
@@ -400,7 +400,7 @@ static int twl6030_usb_remove(struct platform_device *pdev)
 {
 	struct twl6030_usb *twl = platform_get_drvdata(pdev);
 
-	cancel_delayed_work(&twl->get_status_work);
+	cancel_delayed_work_sync(&twl->get_status_work);
 	twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK,
 		REG_INT_MSK_LINE_C);
 	twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK,