Skip to contentSkip to conversation

ARM: dts: omap3-gta04: declare backlight in lcd node

PATCH Applied Andreas Kemnade 3 participants 3 messages Feb 11, 2019 – Feb 13, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: omap3-gta04: declare backlight in lcd node

The lcd display of the gta04 has a backlight but the backlight was not referenced in the lcd node, so screen blanking did not turn off the backlight. Fix that.

---
the backlight property for the driver was accepted here:
https://lore.kernel.org/lkml/[email protected]/

 arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/omap3-gta04.dtsi +2 -1
index 8c55d33ff694..3b88eb5f1a72 100644
@@ -142,6 +142,7 @@
 			spi-cpol;
 			spi-cpha;
 
+			backlight= <&backlight>;
 			label = "lcd";
 			port {
 				lcd_in: endpoint {
@@ -151,7 +152,7 @@
 		};
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm11 0 12000000 0>;
 		pwm-names = "backlight";
Signature · 1 line
2.11.0
Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines

Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <[email protected]>:

The lcd display of the gta04 has a backlight but the backlight was not referenced in the lcd node, so screen blanking did not turn off the backlight. Fix that.

Works fine.

Quoted 36 lines

---
the backlight property for the driver was accepted here:
https://lore.kernel.org/lkml/[email protected]/

arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/omap3-gta04.dtsi +2 -1
index 8c55d33ff694..3b88eb5f1a72 100644
@@ -142,6 +142,7 @@
 			spi-cpol;
 			spi-cpha;
 
+			backlight= <&backlight>;
 			label = "lcd";
 			port {
 				lcd_in: endpoint {
@@ -151,7 +152,7 @@
 		};
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm11 0 12000000 0>;
 		pwm-names = "backlight";
Signature · 7 lines
2.11.0

_______________________________________________
http://projects.goldelico.com/p/gta04-kernel/
Letux-kernel mailing list
[email protected]
http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
#2 lore raw
Quoted 7 lines · H. Nikolaus Schaller
Quoted 7 lines

Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <[email protected]>:

The lcd display of the gta04 has a backlight but the backlight was not referenced in the lcd node, so screen blanking did not turn off the backlight. Fix that.

Quoted 5 lines
Quoted 1 line

Works fine.

Thanks applied into omap-for-v5.1/dt.

Tony