mfd: twl6040: Fix device init errors for ACCCTL register
Subsystems (2)
Tony Lindgren
maintainerPATCH 1/1 mfd: twl6040: Fix device init errors for ACCCTL register
I noticed that we can get a -EREMOTEIO errors on at least omap4 duovero:
twl6040 0-004b: Failed to write 2d = 19: -121
And then any following register access will produce errors.
There 2d offset above is register ACCCTL that gets written on twl6040 powerup. With error checking added to the related regcache_sync() call, the -EREMOTEIO error is reproducable on twl6040 powerup at least duovero.
To fix the error, we need to wait until twl6040 is accessible after the powerup. Based on tests on omap4 duovero, we need to wait over 8ms after powerup before register write will complete without failures. Let's also make sure we warn about possible errors too.
Note that we have twl6040_patch[] reg_sequence with the ACCCTL register configuration and regcache_sync() will write the new value to ACCCTL.
--- drivers/mfd/twl6040.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/mfd/twl6040.c +12 -1
@@ -322,8 +322,19 @@ int twl6040_power(struct twl6040 *twl6040, int on) } } +/* +* Register access can produce errors after power-up unless we +* wait at least 8ms based on measurements on duovero. +*/ +usleep_range (10000 ,12000 ); +/* Sync with the HW */ -regcache_sync (twl6040->regmap); + ret =regcache_sync (twl6040->regmap); +if (ret) { +dev_err (twl6040->dev,"%s register write failed: %i\n" , + __func__, ret); + goto out; + }/* Default PLL configuration after power up */ twl6040->pll =TWL6040_SYSCLK_SEL_LPPLL ;
Signature · 1 line
2.20.1
Quoted 11 lines · Tony Lindgren
I noticed that we can get a
-EREMOTEIOerrors on at least omap4 duovero:twl6040 0-004b: Failed to write 2d = 19: -121
And then any following register access will produce errors.
There 2d offset above is register ACCCTL that gets written on twl6040 powerup. With error checking added to the related
regcache_sync()call, the-EREMOTEIOerror is reproducable on twl6040 powerup at least duovero.
Quoted 7 lines
To fix the error, we need to wait until twl6040 is accessible after the powerup. Based on tests on omap4 duovero, we need to wait over 8ms after powerup before register write will complete without failures. Let's also make sure we warn about possible errors too.
Note that we have twl6040_patch[]
reg_sequencewith the ACCCTL register configuration andregcache_sync()will write the new value to ACCCTL.
Quoted 23 lines
Cc Florian Vaussard <[email protected]>Cc Peter Ujfalusi <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- drivers/mfd/twl6040.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)drivers/mfd/twl6040.c +6
-0@@ -322,8 +322,19 @@ int twl6040_power(struct twl6040 *twl6040, int on) } } +/* +* Register access can produce errors after power-up unless we +* wait at least 8ms based on measurements on duovero. +*/ +usleep_range (10000 ,12000 ); +/* Sync with the HW */
drivers/mfd/twl6040.c int twl6040_power(struct twl6040 *twl6040, int on) · line 340
Quoted 10 lines
drivers/mfd/twl6040.c +6
-1-regcache_sync (twl6040->regmap); + ret =regcache_sync (twl6040->regmap); +if (ret) { +dev_err (twl6040->dev,"%s register write failed: %i\n" , + __func__, ret); + goto out; + }/* Default PLL configuration after power up */ twl6040->pll =TWL6040_SYSCLK_SEL_LPPLL ;
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoted 35 lines · Tony Lindgren
I noticed that we can get a
-EREMOTEIOerrors on at least omap4 duovero:twl6040 0-004b: Failed to write 2d = 19: -121
And then any following register access will produce errors.
There 2d offset above is register ACCCTL that gets written on twl6040 powerup. With error checking added to the related
regcache_sync()call, the-EREMOTEIOerror is reproducable on twl6040 powerup at least duovero.To fix the error, we need to wait until twl6040 is accessible after the powerup. Based on tests on omap4 duovero, we need to wait over 8ms after powerup before register write will complete without failures. Let's also make sure we warn about possible errors too.
Note that we have twl6040_patch[]
reg_sequencewith the ACCCTL register configuration andregcache_sync()will write the new value to ACCCTL.Cc Florian Vaussard <[email protected]>Cc Peter Ujfalusi <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- drivers/mfd/twl6040.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)drivers/mfd/twl6040.c +2
-0@@ -322,8 +322,19 @@ int twl6040_power(struct twl6040 *twl6040, int on) } } +/* +* Register access can produce errors after power-up unless we
drivers/mfd/twl6040.c int twl6040_power(struct twl6040 *twl6040, int on) · line 335
Quoted 10 lines
drivers/mfd/twl6040.c +8
-1+* wait at least 8ms based on measurements on duovero. +*/ +usleep_range (10000 ,12000 ); +/* Sync with the HW */ -regcache_sync (twl6040->regmap); + ret =regcache_sync (twl6040->regmap); +if (ret) { +dev_err (twl6040->dev,"%s register write failed: %i\n" , + __func__, ret);
Please drop the __func__ and just use the standard format.
Wouldn't something a little more forthcoming be better?
"Failed to sync with the HW" ?
Quoted 5 lines
drivers/mfd/twl6040.c +2
-0+ goto out; + }/* Default PLL configuration after power up */ twl6040->pll =TWL6040_SYSCLK_SEL_LPPLL ;
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Tony Lindgren
maintainerQuoted 11 lines · Lee Jones
drivers/mfd/twl6040.c int twl6040_power(struct twl6040 *twl6040, int on) · line 335
Quoted 4 lines · Tony Lindgren
drivers/mfd/twl6040.c +4
-0+ ret =regcache_sync (twl6040->regmap); +if (ret) { +dev_err (twl6040->dev,"%s register write failed: %i\n" , + __func__, ret);Please drop the
__func__and just use the standard format.Wouldn't something a little more forthcoming be better?
"Failed to sync with the HW" ?
Sure I'll send an updated patch.
Regards,
Tony