Skip to contentSkip to conversation

dt-bindings: hwmon: Add missing documentation for lm75

PATCH Applied Jagan Teki 3 participants 7 messages Feb 12, 2019 – Feb 28, 2019

Subsystems (2)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v2 1/1 dt-bindings: hwmon: Add missing documentation for lm75

Add missing dt-binding documentation for lm75 hwmon sensor.

---
Changes for v2:
- Add all compatible nodes available in lm75.

 .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
Documentation/devicetree/bindings/hwmon/lm75.txt new file +37 -0
new file mode 100644
index 000000000000..12d8cf7cf592
@@ -0,0 +1,37 @@
+*LM75 hwmon sensor.
+
+Required properties:
+- compatible: manufacturer and chip name, one of
+		"adi,adt75",
+		"dallas,ds1775",
+		"dallas,ds75",
+		"dallas,ds7505",
+		"gmt,g751",
+		"national,lm75",
+		"national,lm75a",
+		"national,lm75b",
+		"maxim,max6625",
+		"maxim,max6626",
+		"maxim,max31725",
+		"maxim,max31726",
+		"maxim,mcp980x",
+		"st,stds75",
+		"st,stlm75",
+		"microchip,tcn75",
+		"ti,tmp100",
+		"ti,tmp101",
+		"ti,tmp105",
+		"ti,tmp112",
+		"ti,tmp175",
+		"ti,tmp275",
+		"ti,tmp75",
+		"ti,tmp75c",
+
+- reg: I2C bus address of the device
+
+Example:
+
+sensor@48 {
+	compatible = "st,stlm75";
+	reg = <0x48>;
+};
Signature · 1 line
2.18.0.321.gffc6fa0e3
author
#1 lore raw
Quoted 11 lines · Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

---
Changes for v2:
- Add all compatible nodes available in lm75.

 .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt

Any comments on this? It is blocking some dts changes to get merge into Mainline.

maintainer
#2 lore raw
Quoted 9 lines · Jagan Teki
Quoted 8 lines · Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

---
Changes for v2:
- Add all compatible nodes available in lm75.

Quoted 7 lines
Quoted 3 lines
  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
  1 file changed, 37 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt

Any comments on this? It is blocking some dts changes to get merge into Mainline.

Waiting for Rob's Ack.

Guenter

author
#3 lore raw

Rob,

Quoted 15 lines · Guenter Roeck
Quoted 13 lines · Jagan Teki
Quoted 11 lines · Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

---
Changes for v2:
- Add all compatible nodes available in lm75.

  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
  1 file changed, 37 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt

Quoted 5 lines
Quoted 3 lines

Any comments on this? It is blocking some dts changes to get merge into Mainline.

Waiting for Rob's Ack.

Any comments?

maintainer Acked-by on v2 1/1
#4 lore raw
In reply to Jagan Teki
Quoted 35 lines · Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

---
Changes for v2:

(quoted diff) +0 -1
-  Add all compatible nodes available in lm75.
 
 .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
Documentation/devicetree/bindings/hwmon/lm75.txt new file +18 -0
new file mode 100644
index 000000000000..12d8cf7cf592
@@ -0,0 +1,37 @@
+*LM75 hwmon sensor.
+
+Required properties:
+- compatible: manufacturer and chip name, one of
+		"adi,adt75",
+		"dallas,ds1775",
+		"dallas,ds75",
+		"dallas,ds7505",
+		"gmt,g751",
+		"national,lm75",
+		"national,lm75a",
+		"national,lm75b",
+		"maxim,max6625",
+		"maxim,max6626",
+		"maxim,max31725",
+		"maxim,max31726",
+		"maxim,mcp980x",
+		"st,stds75",

Documentation/devicetree/bindings/hwmon/lm75.txt line 28

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/lm75.txt new file +10 -0
+		"st,stlm75",
+		"microchip,tcn75",
+		"ti,tmp100",
+		"ti,tmp101",
+		"ti,tmp105",
+		"ti,tmp112",
+		"ti,tmp175",
+		"ti,tmp275",
+		"ti,tmp75",
+		"ti,tmp75c",

Some of these are in trivial-devices.yaml already. So you either need to remove them from there. Or you can move all these to trivial-devices and benefit from having a schema. I prefer the latter, but either way is fine. You can remove them from trivial-devices.yaml in a separate patch, so:

Rob

P.S. Third option is convert this doc to DT schema. Don't tell anyone, but you'll be a the top of my review queue.

author
#5 lore raw
Quoted 45 lines · Rob Herring
Quoted 43 lines · Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

---
Changes for v2:

(quoted diff) +0 -1
-  Add all compatible nodes available in lm75.
 
 .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
Documentation/devicetree/bindings/hwmon/lm75.txt new file +26 -0
new file mode 100644
index 000000000000..12d8cf7cf592
@@ -0,0 +1,37 @@
+*LM75 hwmon sensor.
+
+Required properties:
+- compatible: manufacturer and chip name, one of
+             "adi,adt75",
+             "dallas,ds1775",
+             "dallas,ds75",
+             "dallas,ds7505",
+             "gmt,g751",
+             "national,lm75",
+             "national,lm75a",
+             "national,lm75b",
+             "maxim,max6625",
+             "maxim,max6626",
+             "maxim,max31725",
+             "maxim,max31726",
+             "maxim,mcp980x",
+             "st,stds75",
+             "st,stlm75",
+             "microchip,tcn75",
+             "ti,tmp100",
+             "ti,tmp101",
+             "ti,tmp105",
+             "ti,tmp112",
+             "ti,tmp175",
+             "ti,tmp275",
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/lm75.txt line 28

Quoted 2 lines
Documentation/devicetree/bindings/hwmon/lm75.txt new file +2 -0
+             "ti,tmp75",
+             "ti,tmp75c",

Some of these are in trivial-devices.yaml already. So you either need to remove them from there. Or you can move all these to trivial-devices and benefit from having a schema. I prefer the latter, but either way is fine. You can remove them from trivial-devices.yaml in a separate patch, so:

Thanks, Rob.

I will remove trivial devices from here wrt trivial-devices.yaml in separate patch.

Guenter, could you please pick this.

maintainer Applied
#6 lore raw
Quoted 6 lines · Jagan Teki
Quoted 5 lines · Rob Herring
Quoted 3 lines · Jagan Teki

Add missing dt-binding documentation for lm75 hwmon sensor.

[ ... ]

Quoted 2 lines

Guenter, could you please pick this.

Applied to hwmon-next (and pushed).

Guenter