mmc: sdhci-xenon: Mark expected switch fall-through
Subsystems (3)
PATCH 1/1 mmc: sdhci-xenon: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/mmc/host/sdhci-xenon-phy.c: In function ‘xenon_emmc_phy_slow_mode’:drivers/mmc/host/sdhci-xenon-phy.c:527:47: warning: this statement may fall through [-Wimplicit-fallthrough=]
if ((priv->init_card_type == MMC_TYPE_SDIO) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
params->slow_mode) {
~~~~~~~~~~~~~~~~~drivers/mmc/host/sdhci-xenon-phy.c:534:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/mmc/host/sdhci-xenon-phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-xenon-phy.c +1 -1
@@ -530,7 +530,7 @@ static bool xenon_emmc_phy_slow_mode(struct sdhci_host *host, ret = true;break ; } -/* else: fall through */ +/* fall through */ default : reg &= ~XENON_TIMING_ADJUST_SLOW_MODE ; ret = false;
Signature · 1 line
2.20.1
Quoted 18 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/mmc/host/sdhci-xenon-phy.c: In function ‘xenon_emmc_phy_slow_mode’:drivers/mmc/host/sdhci-xenon-phy.c:527:47: warning: this statement may fall through [-Wimplicit-fallthrough=]
if ((priv->init_card_type==MMC_TYPE_SDIO) ||~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ params->slow_mode) { ~~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-xenon-phy.c:534:2: note: here
default:
^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Quoted 7 lines
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied for next - and by cleaning up the somewhat noisy change log, thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/host/sdhci-xenon-phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/sdhci-xenon-phy.c +1
-2@@ -530,7 +530,7 @@ static bool xenon_emmc_phy_slow_mode(struct sdhci_host *host, ret = true;break ; } -/* else: fall through */ +/* fall through */ default : reg &= ~XENON_TIMING_ADJUST_SLOW_MODE ; ret = false; --2.20.1
Quoted 23 lines · Ulf Hansson
Quoted 21 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/mmc/host/sdhci-xenon-phy.c: In function ‘xenon_emmc_phy_slow_mode’:drivers/mmc/host/sdhci-xenon-phy.c:527:47: warning: this statement may fall through [-Wimplicit-fallthrough=]
if ((priv->init_card_type==MMC_TYPE_SDIO) ||~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ params->slow_mode) { ~~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-xenon-phy.c:534:2: note: here
default:
^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Quoted 7 lines
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied for next - and by cleaning up the somewhat noisy change log, thanks!
Great.
Thanks, Uffe.
--
Gustavo