Skip to contentSkip to conversation

iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus

PATCH In review Christoph Hellwig 2 participants 2 messages Feb 11, 2019 – Feb 12, 2019 iSCSI boot firmware table (iBFT) driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iscsi_ibft: use virt_to_phys instead of isa_virt_to_bus

As far as I can tell IBFT is a firmware table and has nothing to do with the good old ISA bus. And even if it the two would be the same on x86 anyway. So remove the isa_virt_to_bus call in preparation of eventually removing that API entirely.

---
 drivers/firmware/iscsi_ibft_find.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/iscsi_ibft_find.c +1 -1
index 72d9ea18270b..85c656d04bb0 100644
@@ -104,7 +104,7 @@ unsigned long __init find_ibft_region(unsigned long *sizep)
 
 	if (ibft_addr) {
 		*sizep = PAGE_ALIGN(ibft_addr->header.length);
-		return (u64)isa_virt_to_bus(ibft_addr);
+		return (u64)virt_to_phys(ibft_addr);
 	}
 
 	*sizep = 0;
Signature · 1 line
2.20.1
#1 lore raw
Quoted 6 lines · Christoph Hellwig

As far as I can tell IBFT is a firmware table and has nothing to do with the good old ISA bus. And even if it the two would be the same on x86 anyway. So remove the isa_virt_to_bus call in preparation of eventually removing that API entirely.

Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git

Quoted 20 lines
---
 drivers/firmware/iscsi_ibft_find.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/iscsi_ibft_find.c +1 -1
index 72d9ea18270b..85c656d04bb0 100644
@@ -104,7 +104,7 @@ unsigned long __init find_ibft_region(unsigned long *sizep)
 
 	if (ibft_addr) {
 		*sizep = PAGE_ALIGN(ibft_addr->header.length);
-		return (u64)isa_virt_to_bus(ibft_addr);
+		return (u64)virt_to_phys(ibft_addr);
 	}
 
 	*sizep = 0;
Signature · 1 line
2.20.1