USB: musb: mark expected switch fall-through
Subsystems (2)
PATCH 1/1 USB: musb: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/usb/musb/musb_host.c: In function ‘musb_advance_schedule’:drivers/usb/musb/musb_host.c:374:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (qh->mux == 1) {
^drivers/usb/musb/musb_host.c:383:3: note: here
case USB_ENDPOINT_XFER_ISOC:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/usb/musb/musb_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/musb/musb_host.c +1 -1
@@ -378,7 +378,7 @@ static void musb_advance_schedule(struct musb *musb, struct urb *urb, qh =first_qh (head);break ; } -/* else: fall through */ +/* fall through */ case USB_ENDPOINT_XFER_ISOC :case USB_ENDPOINT_XFER_INT :
Hi Greg,
Quoted 15 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/usb/musb/musb_host.c: In function ‘musb_advance_schedule’:drivers/usb/musb/musb_host.c:374:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (qh->mux == 1) { ^ drivers/usb/musb/musb_host.c:383:3: note: here case USB_ENDPOINT_XFER_ISOC: ^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Quoted 7 lines
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
I've closed my musb tree for v5.1-rc1, if you want to directly pick this patch, here is my Acked-by, or I will take it for v5.2-rc1.
Quoted 19 lines
--- drivers/usb/musb/musb_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/musb/musb_host.c +1
-1@@ -378,7 +378,7 @@ static void musb_advance_schedule(struct musb *musb, struct urb *urb, qh =first_qh (head);break ; } -/* else: fall through */ +/* fall through */ case USB_ENDPOINT_XFER_ISOC :case USB_ENDPOINT_XFER_INT :Signature · 1 line
2.20.1
Regards,
-Bin.
Greg Kroah-Hartman
maintainerQuoted 24 lines · Bin Liu
Hi Greg,
Quoted 21 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/usb/musb/musb_host.c: In function ‘musb_advance_schedule’:drivers/usb/musb/musb_host.c:374:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (qh->mux == 1) { ^ drivers/usb/musb/musb_host.c:383:3: note: here case USB_ENDPOINT_XFER_ISOC: ^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Quoted 6 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>I've closed my musb tree for v5.1-rc1, if you want to directly pick this patch, here is my Acked-by, or I will take it for v5.2-rc1.
Acked-by Bin Liu <[email protected]>
I'll take it directly, thanks.
greg k-h
Quoted 25 lines · Greg Kroah-Hartman
Quoted 24 lines · Bin Liu
Hi Greg,
Quoted 21 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/usb/musb/musb_host.c: In function ‘musb_advance_schedule’:drivers/usb/musb/musb_host.c:374:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (qh->mux == 1) { ^ drivers/usb/musb/musb_host.c:383:3: note: here case USB_ENDPOINT_XFER_ISOC: ^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Quoted 9 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>I've closed my musb tree for v5.1-rc1, if you want to directly pick this patch, here is my Acked-by, or I will take it for v5.2-rc1.
Acked-by Bin Liu <[email protected]>I'll take it directly, thanks.
Thank you both, Bin and Greg.
---
Gustavo