mfd: sec: Add support for the RTC on S2MPA01
Subsystems (3)
PATCH v2 1/1 mfd: sec: Add support for the RTC on S2MPA01
The RTC portion of the S2MPA01 appears to have the same register layout as the S2MPS14.
Signed-off-by Stuart Menefy <[email protected]>
--- drivers/mfd/sec-core.c | 2 ++ drivers/mfd/sec-irq.c | 3 +++ 2 files changed, 5 insertions(+)
drivers/mfd/sec-core.c +2 -0
@@ -103,6 +103,8 @@ static const struct mfd_cell s2mps15_devs[] = {static const struct mfd_cell s2mpa01_devs[] = { { .name ="s2mpa01-pmic" , + }, { + .name ="s2mps14-rtc" , }, };
drivers/mfd/sec-irq.c +3 -0
@@ -455,6 +455,9 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)case S5M8767X : sec_irq_chip = &s5m8767_irq_chip;break ; +case S2MPA01 : + sec_irq_chip = &s2mps14_irq_chip; +break ;case S2MPS11X : sec_irq_chip = &s2mps11_irq_chip;break ;
Signature · 1 line
2.13.6
Good morning Stuart,
It's been a while. I hope all is well with you.
Quoted 14 lines
The RTC portion of the S2MPA01 appears to have the same register layout as the S2MPS14.
Signed-off-by Stuart Menefy <[email protected]>--- drivers/mfd/sec-core.c | 2 ++ drivers/mfd/sec-irq.c | 3 +++ 2 files changed, 5 insertions(+)drivers/mfd/sec-core.c +0
-0
drivers/mfd/sec-core.c static const struct mfd_cell s2mps15_devs[] = { · line 109
Quoted 7 lines
drivers/mfd/sec-core.c +2
-0@@ -103,6 +103,8 @@ static const struct mfd_cell s2mps15_devs[] = {static const struct mfd_cell s2mpa01_devs[] = { { .name ="s2mpa01-pmic" , + }, { + .name ="s2mps14-rtc" , }, };
Ideally one line entries should be on one line (see: s2mps13_devs).
Would you like to take a couple of minutes to make those changes file-wide and rework this patch on top of it please?
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 9 lines · Stuart Menefy
The RTC portion of the S2MPA01 appears to have the same register layout as the S2MPS14.
Signed-off-by Stuart Menefy <[email protected]>--- drivers/mfd/sec-core.c | 2 ++ drivers/mfd/sec-irq.c | 3 +++ 2 files changed, 5 insertions(+)
Reviewed-by Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof