Skip to contentSkip to conversation

perf trace: Fix potential USE_AFTER_FREE problem

PATCH In review Bo YU 2 participants 4 messages Feb 14, 2019 perf events

lore
Share & tools
lore

Bo YU

author
#0 lore raw

PATCH 1/1 perf trace: Fix potential USE_AFTER_FREE problem

From: Bo Yu <[email protected]>

There is a freed pointer "evsel", so fix it.

Detected by CoverityScan, CID#1442595("Memory-illegalaccesses (USE_AFTER_FREE)")

Fixes 6ab3bc240ade4("perf trace: Support multiple "vfs_getname" probes")
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-trace.c +1 -1
index b36061cd1ab8..4036b20a1067 100644
@@ -2515,7 +2515,7 @@ static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp);
 static bool perf_evlist__add_vfs_getname(struct perf_evlist *evlist)
 {
 	bool found = false;
-	struct perf_evsel *evsel, *tmp;
+	struct perf_evsel *evsel = NULL, *tmp;
 	struct parse_events_error err = { .idx = 0, };
 	int ret = parse_events(evlist, "probe:vfs_getname*", &err);
 
Signature · 1 line
2.11.0
#1 lore raw
Quoted 18 lines · Bo YU

From: Bo Yu <[email protected]>

There is a freed pointer "evsel", so fix it.

Detected by CoverityScan, CID#1442595("Memory-illegalaccesses (USE_AFTER_FREE)")

Fixes 6ab3bc240ade4("perf trace: Support multiple "vfs_getname" probes")
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-trace.c +0 -0
index b36061cd1ab8..4036b20a1067 100644

tools/perf/builtin-trace.c static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp); · line 2518

Quoted 5 lines
tools/perf/builtin-trace.c +1 -1
@@ -2515,7 +2515,7 @@ static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp);
 static bool perf_evlist__add_vfs_getname(struct perf_evlist *evlist)
 {
 	bool found = false;
-	struct perf_evsel *evsel, *tmp;
+	struct perf_evsel *evsel = NULL, *tmp;

hum, I can't see how this change could matter,
could you pelase explain?

jirka

Quoted 6 lines
tools/perf/builtin-trace.c +0 -0
 	struct parse_events_error err = { .idx = 0, };
 	int ret = parse_events(evlist, "probe:vfs_getname*", &err);
 
Signature · 1 line
2.11.0
author
#2 lore raw

Hi,

Quoted 14 lines · Jiri Olsa
Quoted 13 lines · Bo YU

From: Bo Yu <[email protected]>

There is a freed pointer "evsel", so fix it.

Detected by CoverityScan, CID#1442595("Memory-illegalaccesses (USE_AFTER_FREE)")

Fixes 6ab3bc240ade4("perf trace: Support multiple "vfs_getname" probes")
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

tools/perf/builtin-trace.c static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp); · line 2518

Quoted 10 lines
tools/perf/builtin-trace.c +1 -1
index b36061cd1ab8..4036b20a1067 100644
@@ -2515,7 +2515,7 @@ static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp);
 static bool perf_evlist__add_vfs_getname(struct perf_evlist *evlist)
 {
 	bool found = false;
-	struct perf_evsel *evsel, *tmp;
+	struct perf_evsel *evsel = NULL, *tmp;

hum, I can't see how this change could matter,
could you pelase explain

First, this is a warning reported by CoverityScan,but in fact i do not how to answer your question :(.
Second, if i remember right, temporary element of list_for_each_entry_safe should be initialized with NULL otherwise it will complain via gcc. Please correct me :)
Thanks,

Quoted 9 lines

jirka

Quoted 6 lines
tools/perf/builtin-trace.c +0 -1
 	struct parse_events_error err = { .idx = 0, };
 	int ret = parse_events(evlist, "probe:vfs_getname*", &err);
 
--

2.11.0

#3 lore raw
Quoted 29 lines · YU Bo

Hi,

Quoted 14 lines · Jiri Olsa
Quoted 13 lines · Bo YU

From: Bo Yu <[email protected]>

There is a freed pointer "evsel", so fix it.

Detected by CoverityScan, CID#1442595("Memory-illegalaccesses (USE_AFTER_FREE)")

Fixes 6ab3bc240ade4("perf trace: Support multiple "vfs_getname" probes")
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

tools/perf/builtin-trace.c static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp); · line 2518

Quoted 10 lines
tools/perf/builtin-trace.c +1 -1
index b36061cd1ab8..4036b20a1067 100644
@@ -2515,7 +2515,7 @@ static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp);
 static bool perf_evlist__add_vfs_getname(struct perf_evlist *evlist)
 {
 	bool found = false;
-	struct perf_evsel *evsel, *tmp;
+	struct perf_evsel *evsel = NULL, *tmp;

hum, I can't see how this change could matter,
could you pelase explain

Quoted 2 lines

First, this is a warning reported by CoverityScan,but in fact i do not how to answer your question :(.

I understand that, however at the same time I think it's good to have an idea what the patch is doing ;-)

Quoted 3 lines

Second, if i remember right, temporary element of list_for_each_entry_safe should be initialized with NULL otherwise it will complain via gcc. Please correct me :)

hum, from quick look:

	perf_evlist__add_vfs_getname
		struct perf_evsel *evsel;

		evlist__for_each_entry_safe(evlist, evsel, tmp)
		-> __evlist__for_each_entry_safe(&(evlist)->entries, tmp, evsel)

		__evlist__for_each_entry_safe(list, tmp, evsel) \
		-> list_for_each_entry_safe(evsel, tmp, list, node)

		list_for_each_entry_safe(pos, n, head, member)                  \
		-> for (pos = list_first_entry(head, typeof(*pos), member),        \
			n = list_next_entry(pos, member);                       \
			&pos->member != (head);                                    \
			pos = n, n = list_next_entry(n, member))

unless I'm missing something 'evsel' is being initialized in the for loop init section with this statement:

pos = list_first_entry(head, typeof(*pos), member)

jirka