eal/linux: fix log levels for unable to read pagemap
PATCH 1/1 eal/linux: fix log levels for unable to read pagemap
Commit cdc242f260e7 says:
For Linux kernel 4.0 and newer, the ability to obtain physical page frame numbers for unprivileged users from /proc/self/pagemap was removed. Instead, when an IOMMU is present, simply choose our own DMA addresses instead.
In this case the user still sees error messages, so adjust the log levels. Later, other checks will ensure that errors are logged in the appropriate cases.
--- lib/librte_eal/linuxapp/eal/eal_memory.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
lib/librte_eal/linuxapp/eal/eal_memory.c +4 -4
@@ -115,5 +115,5 @@ rte_mem_virt2phy(const void *virtaddr) fd =open ("/proc/self/pagemap" ,O_RDONLY );if (fd <0 ) { -RTE_LOG (ERR ,EAL ,"%s(): cannot open /proc/self/pagemap: %s\n" , +RTE_LOG (INFO ,EAL ,"%s(): cannot open /proc/self/pagemap: %s\n" , __func__,strerror (errno));return RTE_BAD_IOVA ;
@@ -123,5 +123,5 @@ rte_mem_virt2phy(const void *virtaddr) offset =sizeof (uint64_t ) * virt_pfn;if (lseek (fd, offset,SEEK_SET ) == (off_t) -1 ) { -RTE_LOG (ERR ,EAL ,"%s(): seek error in /proc/self/pagemap: %s\n" , +RTE_LOG (INFO ,EAL ,"%s(): seek error in /proc/self/pagemap: %s\n" , __func__,strerror (errno));close (fd);
@@ -132,9 +132,9 @@ rte_mem_virt2phy(const void *virtaddr)close (fd);if (retval <0 ) { -RTE_LOG (ERR ,EAL ,"%s(): cannot read /proc/self/pagemap: %s\n" , +RTE_LOG (INFO ,EAL ,"%s(): cannot read /proc/self/pagemap: %s\n" , __func__,strerror (errno));return RTE_BAD_IOVA ; }else if (retval !=PFN_MASK_SIZE ) { -RTE_LOG (ERR ,EAL ,"%s(): read %d bytes from /proc/self/pagemap " +RTE_LOG (INFO ,EAL ,"%s(): read %d bytes from /proc/self/pagemap " "but expected %d:\n" , __func__, retval,PFN_MASK_SIZE );
Signature · 1 line
2.20.1
Quoted 10 lines · Kevin Traynor
Commit
cdc242f260e7says:
For Linux kernel 4.0 and newer, the ability to obtain physical page frame numbers for unprivileged users from/proc/self/pagemapwas removed. Instead, when an IOMMU is present, simply choose our own DMA addresses instead.In this case the user still sees error messages, so adjust the log levels. Later, other checks will ensure that errors are logged in the appropriate cases.
Quoted 5 lines
Fixes cdc242f260e7 ("eal/linux: support running as unprivileged user")Signed-off-by Kevin Traynor <[email protected]>---
Thanks, Kevin!
Thomas Monjalon
Applied14/02/2019 20:31, Aaron Conole:
Quoted 12 lines
Quoted 10 lines · Kevin Traynor
Commit
cdc242f260e7says:
For Linux kernel 4.0 and newer, the ability to obtain physical page frame numbers for unprivileged users from/proc/self/pagemapwas removed. Instead, when an IOMMU is present, simply choose our own DMA addresses instead.In this case the user still sees error messages, so adjust the log levels. Later, other checks will ensure that errors are logged in the appropriate cases.
Quoted 7 lines
Quoted 5 lines
Fixes cdc242f260e7 ("eal/linux: support running as unprivileged user")Signed-off-by Kevin Traynor <[email protected]>---
Acked-by Aaron Conole <[email protected]>
Applied, thanks