watchdog: pc87413: Mark expected switch fall-through
PATCH 1/1 watchdog: pc87413: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
pc87413_refresh();
^~~~~~~~~~~~~~~~~drivers/watchdog/pc87413_wdt.c:441:2: note: here
case WDIOC_GETTIMEOUT:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/watchdog/pc87413_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/pc87413_wdt.c +1 -1
@@ -437,7 +437,7 @@ static long pc87413_ioctl(struct file *file, unsigned int cmd,return -EINVAL ; timeout = new_timeout;pc87413_refresh (); -/* fall through and return the new timeout... */ +/* fall through - and return the new timeout... */ case WDIOC_GETTIMEOUT : new_timeout = timeout *60 ;return put_user (new_timeout, uarg.i);
Signature · 1 line
2.20.1
Quoted 15 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]pc87413_refresh(); ^~~~~~~~~~~~~~~~~ drivers/watchdog/pc87413_wdt.c:441:2: note: here case WDIOC_GETTIMEOUT: ^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Quoted 7 lines
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Quoted 18 lines
--- drivers/watchdog/pc87413_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/pc87413_wdt.c +1
-1@@ -437,7 +437,7 @@ static long pc87413_ioctl(struct file *file, unsigned int cmd,return -EINVAL ; timeout = new_timeout;pc87413_refresh (); -/* fall through and return the new timeout... */ +/* fall through - and return the new timeout... */ case WDIOC_GETTIMEOUT : new_timeout = timeout *60 ;return put_user (new_timeout, uarg.i);
Quoted 19 lines · Guenter Roeck
Quoted 18 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]pc87413_refresh();
^~~~~~~~~~~~~~~~~drivers/watchdog/pc87413_wdt.c:441:2: note: here
caseWDIOC_GETTIMEOUT:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Quoted 7 lines
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Guenter Roeck <[email protected]>
Thanks, Guenter.
--
Gustavo
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
Quoted 35 lines · Gustavo A. R. Silva
Quoted 19 lines · Guenter Roeck
Quoted 18 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]pc87413_refresh();
^~~~~~~~~~~~~~~~~drivers/watchdog/pc87413_wdt.c:441:2: note: here
caseWDIOC_GETTIMEOUT:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Quoted 7 lines
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Guenter Roeck <[email protected]>Thanks, Guenter.
--
Gustavo
Guenter Roeck
maintainerQuoted 6 lines · Gustavo A. R. Silva
Hi all,
Friendly ping:
Who can take this?
Wim, presumably.
Guenter
Quoted 41 lines
Thanks
--
GustavoQuoted 35 lines · Gustavo A. R. Silva
Quoted 19 lines · Guenter Roeck
Quoted 18 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]pc87413_refresh();
^~~~~~~~~~~~~~~~~drivers/watchdog/pc87413_wdt.c:441:2: note: here
caseWDIOC_GETTIMEOUT:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Quoted 7 lines
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Guenter Roeck <[email protected]>Thanks, Guenter.
--
Gustavo
Quoted 9 lines · Guenter Roeck
Quoted 6 lines · Gustavo A. R. Silva
Hi all,
Friendly ping:
Who can take this?
Wim, presumably.
Oh OK. Hopefully, he'll notice this thread soon.
Thanks
--
Gustavo
Quoted 43 lines
Guenter
Quoted 41 lines
Thanks
--
GustavoQuoted 35 lines · Gustavo A. R. Silva
Quoted 19 lines · Guenter Roeck
Quoted 18 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]pc87413_refresh();
^~~~~~~~~~~~~~~~~drivers/watchdog/pc87413_wdt.c:441:2: note: here
caseWDIOC_GETTIMEOUT:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Quoted 7 lines
Quoted 4 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Guenter Roeck <[email protected]>Thanks, Guenter.
--
Gustavo