vhost: correctly check the return value of translate_desc() in log_used()
Subsystems (5)
PATCH 1/1 vhost: correctly check the return value of translate_desc() in log_used()
When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.
--- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vhost/vhost.c +1 -1
@@ -1788,7 +1788,7 @@ static int log_used(struct vhost_virtqueue *vq, u64 used_offset, u64 len) ret =translate_desc (vq, (uintptr_t )vq->used + used_offset, len, iov,64 ,VHOST_ACCESS_WO ); -if (ret) +if (ret <0 )return ret;for (i =0 ; i < ret; i++) {
Signature · 1 line
2.17.1
Quoted 7 lines · On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang <[email protected]> wrote:
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>
Looks good. It is best to put the Addresses-Coverity-Id tag on these kind of bug fixes so that the automated tools see it.
Quoted 7 lines · Stephen Hemminger
Quoted 4 lines · On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang <[email protected]> wrote:
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.
Quoted 5 lines
Quoted 3 lines
Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>Looks good. It is best to put the Addresses-Coverity-Id tag on these kind of bug fixes so that the automated tools see it.
Ok. Will do this in V2.
Thanks
Quoted 7 lines · Stephen Hemminger
Quoted 4 lines · On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang <[email protected]> wrote:
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.
Quoted 5 lines
Quoted 3 lines
Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>Looks good. It is best to put the Addresses-Coverity-Id tag on these kind of bug fixes so that the automated tools see it.
Ok. Will do this in V2.
Thanks
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 7 lines · On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang <[email protected]> wrote:
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>
Looks good. It is best to put the Addresses-Coverity-Id tag on these kind of bug fixes so that the automated tools see it.
David Miller
maintainerFrom: Jason Wang <[email protected]>
Date: Fri, 15 Feb 2019 15:53:24 +0800
Quoted 7 lines
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>
Jason, please put the Fixes tag first.
Thank you.
Quoted 7 lines · David Miller
From: Jason Wang<[email protected]>
Date: Fri, 15 Feb 2019 15:53:24 +0800Quoted 4 lines
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.
Quoted 6 lines
Quoted 3 lines
Reported-by Stephen Hemminger<[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang<[email protected]>Jason, please put the Fixes tag first.
Thank you.
Ok. Will post V2.
Thanks
Quoted 7 lines · David Miller
From: Jason Wang<[email protected]>
Date: Fri, 15 Feb 2019 15:53:24 +0800Quoted 4 lines
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.
Quoted 6 lines
Quoted 3 lines
Reported-by Stephen Hemminger<[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang<[email protected]>Jason, please put the Fixes tag first.
Thank you.
Ok. Will post V2.
Thanks
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
David Miller
maintainerFrom: Jason Wang <[email protected]>
Date: Fri, 15 Feb 2019 15:53:24 +0800
Quoted 7 lines
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>
Jason, please put the Fixes tag first.
Thank you.
Quoted 7 lines · Jason Wang
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>
and I guess the log was backported to stable so we want this backported too.
Quoted 19 lines
--- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vhost/vhost.c +1
-1@@ -1788,7 +1788,7 @@ static int log_used(struct vhost_virtqueue *vq, u64 used_offset, u64 len) ret =translate_desc (vq, (uintptr_t )vq->used + used_offset, len, iov,64 ,VHOST_ACCESS_WO ); -if (ret) +if (ret <0 )return ret;for (i =0 ; i < ret; i++) {Signature · 1 line
2.17.1
Quoted 7 lines · Jason Wang
When fail,
translate_desc()returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero.Reported-by Stephen Hemminger <[email protected]>Fixes cc5e71075947 ("vhost: log dirty page correctly")Signed-off-by Jason Wang <[email protected]>
and I guess the log was backported to stable so we want this backported too.
Quoted 19 lines
--- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vhost/vhost.c +1
-1@@ -1788,7 +1788,7 @@ static int log_used(struct vhost_virtqueue *vq, u64 used_offset, u64 len) ret =translate_desc (vq, (uintptr_t )vq->used + used_offset, len, iov,64 ,VHOST_ACCESS_WO ); -if (ret) +if (ret <0 )return ret;for (i =0 ; i < ret; i++) {Signature · 1 line
2.17.1