Skip to contentSkip to conversation

net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause

PATCH Applied Maxime Chevallier 3 participants 3 messages Feb 15, 2019 – Feb 17, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause

The PHY core expects PHY drivers not to set Pause and Asym_Pause bits, unless the driver only wants to specify one of them due to HW limitation. In the case of the Marvell10g driver, we don't need to set them.

---
 drivers/net/phy/marvell10g.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/phy/marvell10g.c +0 -3
index 496805c0ddfe..c04fe5a75129 100644
@@ -242,9 +242,6 @@ static int mv3310_config_init(struct phy_device *phydev)
 	    phydev->interface != PHY_INTERFACE_MODE_10GKR)
 		return -ENODEV;
 
-	__set_bit(ETHTOOL_LINK_MODE_Pause_BIT, phydev->supported);
-	__set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, phydev->supported);
-
 	if (phydev->c45_ids.devices_in_package & MDIO_DEVS_AN) {
 		val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_STAT1);
 		if (val < 0)
Signature · 1 line
2.19.2
maintainer Applied
#2 lore raw
In reply to Maxime Chevallier

From: Maxime Chevallier <[email protected]>
Date: Fri, 15 Feb 2019 09:33:47 +0100

Quoted 7 lines

The PHY core expects PHY drivers not to set Pause and Asym_Pause bits, unless the driver only wants to specify one of them due to HW limitation. In the case of the Marvell10g driver, we don't need to set them.

Applied, thanks.