Skip to contentSkip to conversation

usb: Select USB_MUSB_DSPS with USB_MUSB_TI

PATCH Superseded Alex Kiernan 2 participants 2 messages Feb 15, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: Select USB_MUSB_DSPS with USB_MUSB_TI

USB_MUSB_TI requires USB_MUSB_DSPS, failing at link time if it's not selected:

drivers/usb/musb-new/built-in.o: In function `ti_musb_host_ofdata_to_platdata':
drivers/usb/musb-new/ti-musb.c:193: undefined reference to `musb_dsps_ops'

---

 configs/am335x_boneblack_vboot_defconfig | 1 -
 configs/am335x_evm_defconfig             | 1 -
 configs/am335x_hs_evm_defconfig          | 1 -
 configs/am335x_hs_evm_uart_defconfig     | 1 -
 configs/brppt1_mmc_defconfig             | 1 -
 configs/brppt1_nand_defconfig            | 1 -
 configs/brppt1_spi_defconfig             | 1 -
 configs/chiliboard_defconfig             | 1 -
 drivers/usb/musb-new/Kconfig             | 1 +
 9 files changed, 1 insertion(+), 8 deletions(-)
configs/am335x_boneblack_vboot_defconfig +0 -1
index f455b01e1e81..f4bf88b5e094 100644
@@ -55,7 +55,6 @@ CONFIG_SPL_DM_USB_GADGET=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
configs/am335x_evm_defconfig +0 -1
index 924116835251..962feedd1279 100644
@@ -61,7 +61,6 @@ CONFIG_SPL_DM_USB_GADGET=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
configs/am335x_hs_evm_defconfig +0 -1
index faa6c2b05fcd..3c9d385b049a 100644
@@ -60,7 +60,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
configs/am335x_hs_evm_uart_defconfig +0 -1
index 02332db0a6e9..9d970849cf66 100644
@@ -62,7 +62,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
configs/brppt1_mmc_defconfig +0 -1
index f2d822012619..3d2f0737fdf2 100644
@@ -83,7 +83,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
 CONFIG_FAT_WRITE=y
configs/brppt1_nand_defconfig +0 -1
index 275727d11f32..02dc03542c1d 100644
@@ -87,7 +87,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
 CONFIG_FAT_WRITE=y
configs/brppt1_spi_defconfig +0 -1
index 668c4c22c27f..3619587bdc5c 100644
@@ -97,7 +97,6 @@ CONFIG_DM_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_GADGET=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
 CONFIG_FAT_WRITE=y
configs/chiliboard_defconfig +0 -1
index a6c36eda503d..944dd0db3c87 100644
@@ -50,6 +50,5 @@ CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_MUSB_HOST=y
 CONFIG_USB_MUSB_TI=y
-CONFIG_USB_MUSB_DSPS=y
 CONFIG_FAT_WRITE=y
 CONFIG_LZO=y
drivers/usb/musb-new/Kconfig +1 -0
index f8f2205a62d3..1dd823037bec 100644
@@ -21,6 +21,7 @@ config USB_MUSB_GADGET
 config USB_MUSB_TI
 	bool "Enable TI OTG USB controller"
 	depends on DM_USB
+	select USB_MUSB_DSPS
 	default n
 	help
 	  Say y here to enable support for the dual role high
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 usb: Select USB_MUSB_DSPS with USB_MUSB_TI

Alex Kiernan <[email protected]> schrieb am 15.02.2019 10:54:15:

Quoted 3 lines

Von: Alex Kiernan <[email protected]>
An: u-boot at lists.denx.de
Kopie: Alex Kiernan <[email protected]>, "Andrew F. Davis"

<[email protected]>,

Quoted 9 lines

Marek Vasut <[email protected]>, Hannes Schmelzer <hannes.schmelzer@br- automation.com>, Marcin Niestroj <[email protected]>
Datum: 15.02.2019 10:54
Betreff: [PATCH] usb: Select USB_MUSB_DSPS with USB_MUSB_TI

USB_MUSB_TI requires USB_MUSB_DSPS, failing at link time if it's not selected:

drivers/usb/musb-new/built-in.o: In function

`ti_musb_host_ofdata_to_platdata':

Quoted 1 line

drivers/usb/musb-new/ti-musb.c:193: undefined reference to

`musb_dsps_ops'

Quoted 4 lines

---

Quoted 14 lines
 configs/am335x_boneblack_vboot_defconfig | 1 -
 configs/am335x_evm_defconfig             | 1 -
 configs/am335x_hs_evm_defconfig          | 1 -
 configs/am335x_hs_evm_uart_defconfig     | 1 -
 configs/brppt1_mmc_defconfig             | 1 -
 configs/brppt1_nand_defconfig            | 1 -
 configs/brppt1_spi_defconfig             | 1 -
 configs/chiliboard_defconfig             | 1 -
 drivers/usb/musb-new/Kconfig             | 1 +
 9 files changed, 1 insertion(+), 8 deletions(-)
Signature · 1 line
2.17.1

For brppt1*: