ath9k: Make sure to zero status.tx_time before reporting TX status
PATCH 1/1 ath9k: Make sure to zero status.tx_time before reporting TX status
Since ath9k reports airtime usage directly using the ieee80211_report_airtime() callback, it shouldn't also report it using the tx_time in status. Make sure the field is zeroed before TX status is reported to avoid spurious airtime being accounted by bits being left over from earlier uses of the cb.
--- drivers/net/wireless/ath/ath9k/xmit.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath9k/xmit.c +3 -0
@@ -2552,6 +2552,9 @@ static void ath_tx_rc_status(struct ath_softc *sc, struct ath_buf *bf, } tx_info->status.rates[tx_rateindex].count = ts->ts_longretry +1 ; + +/* we report airtime in ath_tx_count_airtime(), don't report twice */ + tx_info->status.tx_time =0 ; }static void ath_tx_processq (struct ath_softc *sc,struct ath_txq *txq)
Signature · 1 line
2.20.1
Quoted 9 lines · Toke Høiland-Jørgensen
Since ath9k reports airtime usage directly using the
ieee80211_report_airtime()callback, it shouldn't also report it using thetx_timein status. Make sure the field is zeroed before TX status is reported to avoid spurious airtime being accounted by bits being left over from earlier uses of the cb.Fixes 89cea7493a34 ("ath9k: Switch to mac80211 TXQ scheduling and airtime APIs")Signed-off-by Toke Høiland-Jørgensen <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
cc591d77aba1 ath9k: Make sure to zero status.tx_time before reporting TX status
Signature · 3 lines
https://patchwork.kernel.org/patch/10815445/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches