Skip to contentSkip to conversation

drm/amdgpu/powerplay/polaris10_smumgr: Mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Feb 15, 2019 – Feb 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/powerplay/polaris10_smumgr: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c +1 -0
index 52abca065764..92de1bbb2e33 100644
@@ -2330,6 +2330,7 @@ static uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
 		case DRAM_LOG_BUFF_SIZE:
 			return offsetof(SMU74_SoftRegisters, DRAM_LOG_BUFF_SIZE);
 		}
+		/* fall through */
 	case SMU_Discrete_DpmTable:
 		switch (member) {
 		case UvdBootLevel:
Signature · 1 line
2.20.1
#1 lore raw
Quoted 19 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c +0 -0
index 52abca065764..92de1bbb2e33 100644

drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c static uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member) · line 2333

Quoted 4 lines
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c +1 -0
@@ -2330,6 +2330,7 @@ static uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
                case DRAM_LOG_BUFF_SIZE:
                        return offsetof(SMU74_SoftRegisters, DRAM_LOG_BUFF_SIZE);
                }
+               /* fall through */

These should be breaks, although I don't think we ever currently hit this case. I've sent out a patch to fix it and applied the rest of the radeon and amdgpu patches. Thanks!

Alex

Quoted 10 lines
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c +0 -1
        case SMU_Discrete_DpmTable:
                switch (member) {
                case UvdBootLevel:
--

2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 16 lines · Alex Deucher
Quoted 14 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c static uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member) · line 2333

Quoted 9 lines
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c +1 -0
index 52abca065764..92de1bbb2e33 100644
@@ -2330,6 +2330,7 @@ static uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
                case DRAM_LOG_BUFF_SIZE:
                        return offsetof(SMU74_SoftRegisters, DRAM_LOG_BUFF_SIZE);
                }
+               /* fall through */

These should be breaks, although I don't think we ever currently hit this case. I've sent out a patch to fix it and applied the rest of the radeon and amdgpu patches. Thanks!

Awesome!

Thanks, Alex.

--
Gustavo
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel