Skip to contentSkip to conversation

drm/radeon/evergreen_cs: fix missing break in switch statement

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Feb 15, 2019 – Feb 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/evergreen_cs: fix missing break in switch statement

Add missing break statement in order to prevent the code from falling through to case CB_TARGET_MASK.

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Fixes dd220a00e8bd ("drm/radeon/kms: add support for streamout v7")

---
NOTE: Notice that this code has been out there since 2012. So, it would be helpful if someone can double-check this.

 drivers/gpu/drm/radeon/evergreen_cs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/radeon/evergreen_cs.c +1 -0
index f471537c852f..1e14c6921454 100644
@@ -1299,6 +1299,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
 			return -EINVAL;
 		}
 		ib[idx] += (u32)((reloc->gpu_offset >> 8) & 0xffffffff);
+		break;
 	case CB_TARGET_MASK:
 		track->cb_target_mask = radeon_get_ib_value(p, idx);
 		track->cb_dirty = true;
Signature · 1 line
2.20.1
Applied
#1 lore raw
Quoted 7 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from falling through to case CB_TARGET_MASK.

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Quoted 6 lines
Fixes dd220a00e8bd ("drm/radeon/kms: add support for streamout v7")

---
NOTE: Notice that this code has been out there since 2012. So, it would be helpful if someone can double-check this.

Applied. thanks!

Alex

Quoted 19 lines
 drivers/gpu/drm/radeon/evergreen_cs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/radeon/evergreen_cs.c +1 -1
index f471537c852f..1e14c6921454 100644
@@ -1299,6 +1299,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
                        return -EINVAL;
                }
                ib[idx] += (u32)((reloc->gpu_offset >> 8) & 0xffffffff);
+               break;
        case CB_TARGET_MASK:
                track->cb_target_mask = radeon_get_ib_value(p, idx);
                track->cb_dirty = true;
--

2.20.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel