Skip to contentSkip to conversation

package/qwt: needs qt5base gui support

PATCH New Peter Seiderer 3 participants 5 messages Feb 15, 2019 – Feb 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qwt: needs qt5base gui support

Fixes the following qt5base configure error ([1]):

ERROR: Feature 'widgets' was enabled, but the pre-condition 'features.gui' failed.

[1] http://autobuild.buildroot.net/results/c771c2d5aac3e21f908e5a118f3755dbc9301a47

---
 package/qwt/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qwt/Config.in +1 -0
index f4132c8638..2e9cec19d7 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QWT
 	bool "qwt"
 	depends on BR2_PACKAGE_QT5
 	select BR2_PACKAGE_QT5BASE
+	select BR2_PACKAGE_QT5BASE_GUI
 	select BR2_PACKAGE_QT5BASE_WIDGETS # printsupport
 	select BR2_PACKAGE_QT5BASE_CONCURRENT
 	help
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/qwt: needs qt5base gui support

Hello Peter,

Quoted 16 lines · On Fri, 15 Feb 2019 21:25:04 +0100 Peter Seiderer <[email protected]> wrote:

Fixes the following qt5base configure error ([1]):

ERROR: Feature 'widgets' was enabled, but the pre-condition 'features.gui' failed.

[1] http://autobuild.buildroot.net/results/c771c2d5aac3e21f908e5a118f3755dbc9301a47

---
 package/qwt/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qwt/Config.in +0 -0
index f4132c8638..2e9cec19d7 100644

package/qwt/Config.in config BR2_PACKAGE_QWT · line 5

Quoted 4 lines
package/qwt/Config.in +1 -0
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QWT
 	bool "qwt"
 	depends on BR2_PACKAGE_QT5
 	select BR2_PACKAGE_QT5BASE
+	select BR2_PACKAGE_QT5BASE_GUI

Hm, the build error happens in qt5base, and to me reads as "if you have widgets support enabled in qt5base, you must have gui support enabled in qt5base". If that is what is happening, then what you want to do is have BR2_PACKAGE_QT5BASE_WIDGETS sleect BR2_PACKAGE_QT5BASE_GUI, and not touch qwt.

Indeed, to me, it seems like any other package that uses qt5 widgets without selecting qt5 gui would fall into the same build failure.

Also, any idea why this is popping up only now ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/qwt: needs qt5base gui support

Hello Thomas,

Quoted 16 lines · Thomas Petazzoni

Hello Peter,

Quoted 11 lines · On Fri, 15 Feb 2019 21:25:04 +0100 Peter Seiderer <[email protected]> wrote:

Fixes the following qt5base configure error ([1]):

ERROR: Feature 'widgets' was enabled, but the pre-condition 'features.gui' failed.

[1] http://autobuild.buildroot.net/results/c771c2d5aac3e21f908e5a118f3755dbc9301a47

---
 package/qwt/Config.in | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

package/qwt/Config.in config BR2_PACKAGE_QWT · line 5

Quoted 9 lines
package/qwt/Config.in +1 -0
index f4132c8638..2e9cec19d7 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QWT
 	bool "qwt"
 	depends on BR2_PACKAGE_QT5
 	select BR2_PACKAGE_QT5BASE
+	select BR2_PACKAGE_QT5BASE_GUI  

Hm, the build error happens in qt5base, and to me reads as "if you have widgets support enabled in qt5base, you must have gui support enabled in qt5base". If that is what is happening, then what you want to do is have BR2_PACKAGE_QT5BASE_WIDGETS sleect BR2_PACKAGE_QT5BASE_GUI, and not touch qwt.

Because until now qwt is the only package selecting widgets without gui (most packages directly, pulseview via qt5svg and qt5cinex via qt5base eglfs)...and from qt5base/Config.in:

if BR2_PACKAGE_QT5BASE_GUI

config BR2_PACKAGE_QT5BASE_WIDGETS
bool "widgets module"
[...]
endif

Quoted 5 lines

Indeed, to me, it seems like any other package that uses qt5 widgets without selecting qt5 gui would fall into the same build failure.

Also, any idea why this is popping up only now ?

No, did not search the autobuild database, but maybe since 'package/qwt: remove qt4 support'?

Regards,
Peter

Quoted 2 lines

Thomas

#3 lore raw

PATCH 1/1 package/qwt: needs qt5base gui support

Hello,

Quoted 10 lines · On Fri, 15 Feb 2019 21:58:59 +0100 Peter Seiderer <[email protected]> wrote:

Because until now qwt is the only package selecting widgets without gui (most packages directly, pulseview via qt5svg and qt5cinex via qt5base eglfs)...and from qt5base/Config.in:

if BR2_PACKAGE_QT5BASE_GUI

config BR2_PACKAGE_QT5BASE_WIDGETS
bool "widgets module"
[...]
endif

Ah, so there is already a "depends on" between widgets and gui in qt5base, which is good.

So it's indeed qwt that is bogus: it should not select QT5BASE_WIDGETS without selecting QT5BASE_GUI (or depending on it). So your patch is good, I'll apply.

Quoted 6 lines
Quoted 4 lines

Indeed, to me, it seems like any other package that uses qt5 widgets without selecting qt5 gui would fall into the same build failure.

Also, any idea why this is popping up only now ?

No, did not search the autobuild database, but maybe since 'package/qwt: remove qt4 support'?

It's indeed a bug from that patch! Look carefully at the diff of 3e99c8418af904b14b01455d68c84d7b5afd261f:

config BR2_PACKAGE_QWT
bool "qwt"

-       depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5
-       select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_QT
-       select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5
-       select BR2_PACKAGE_QT5BASE_WIDGETS if BR2_PACKAGE_QT5 # printsupport
-       select BR2_PACKAGE_QT5BASE_CONCURRENT if BR2_PACKAGE_QT5
+       depends on BR2_PACKAGE_QT5
+       select BR2_PACKAGE_QT5BASE
+       select BR2_PACKAGE_QT5BASE_WIDGETS # printsupport
+       select BR2_PACKAGE_QT5BASE_CONCURRENT

See how the line:

- select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5

gets removed ?

So I'll apply your patch after adjusting the commit log. Thanks!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/qwt: needs qt5base gui support

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 15 lines

It's indeed a bug from that patch! Look carefully at the diff of 3e99c8418af904b14b01455d68c84d7b5afd261f:

config BR2_PACKAGE_QWT
bool "qwt"

(quoted diff) +4 -5
-       depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5
-       select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_QT
-       select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5
-       select BR2_PACKAGE_QT5BASE_WIDGETS if BR2_PACKAGE_QT5 # printsupport
-       select BR2_PACKAGE_QT5BASE_CONCURRENT if BR2_PACKAGE_QT5
+       depends on BR2_PACKAGE_QT5
+       select BR2_PACKAGE_QT5BASE
+       select BR2_PACKAGE_QT5BASE_WIDGETS # printsupport
+       select BR2_PACKAGE_QT5BASE_CONCURRENT
Quoted 7 lines

See how the line:

- select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5

gets removed ?

So I'll apply your patch after adjusting the commit log. Thanks!

Yes, sorry about that. Thanks Peter!

Signature · 1 line
Bye, Peter Korsgaard