Skip to contentSkip to conversation

drm/i915/selftests: Fix resource leak in __sseu_prepare

PATCH In review Radhakrishna Sripada 4 participants 9 messages Feb 15, 2019 – Feb 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/selftests: Fix resource leak in __sseu_prepare

Fix the resource leak reported by static code checker.

---
 drivers/gpu/drm/i915/selftests/i915_gem_context.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/selftests/i915_gem_context.c +6 -5
index d00d0bb07784..0d821a679f74 100644
@@ -726,14 +726,13 @@ __sseu_prepare(struct drm_i915_private *i915,
 
 		ret = igt_spinner_init(spin, i915);
 		if (ret)
-			return ret;
+			goto clean;
 
 		rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
 		if (IS_ERR(rq)) {
 			ret = PTR_ERR(rq);
 			igt_spinner_fini(spin);
-			kfree(spin);
-			goto out;
+			goto clean;
 		}
 
 		i915_request_add(rq);
@@ -742,14 +741,16 @@ __sseu_prepare(struct drm_i915_private *i915,
 			pr_err("%s: Spinner failed to start!\n", name);
 			igt_spinner_end(spin);
 			igt_spinner_fini(spin);
-			kfree(spin);
 			ret = -ETIMEDOUT;
-			goto out;
+			goto clean;
 		}
 
 		*spin_out = spin;
+		goto out;
 	}
 
+clean:
+	kfree(spin);
 out:
 	return ret;
 }
Signature · 6 lines
2.20.0.rc2.7.g965798d1f299

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Quoting Chris Wilson (2019-02-15 19:40:06)

Quoted 5 lines

Quoting Radhakrishna Sripada (2019-02-15 19:35:54)

Quoted 1 line

Fix the resource leak reported by static code checker.

The caller already frees spin on error, so you just need to set the output and report the error.

Nah, doesn't look at tidy as a proper onion unwind. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

PATCH 1/1 drm/i915/selftests: Always free spinner on __sseu_prepare error

In reply to Radhakrishna Sripada

Prepare a nice little onion unwind to ensure that we always free the spinner if we __sseu_prepare fails.

Fixes c06ee6ff2cbc ("drm/i915/selftests: Context SSEU reconfiguration tests")
Cc Radhakrishna Sripada <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 .../gpu/drm/i915/selftests/i915_gem_context.c | 69 +++++++++----------
 1 file changed, 34 insertions(+), 35 deletions(-)
drivers/gpu/drm/i915/selftests/i915_gem_context.c +34 -35
index d00d0bb07784..7eb58a9d1319 100644
@@ -710,47 +710,45 @@ __sseu_prepare(struct drm_i915_private *i915,
 	       unsigned int flags,
 	       struct i915_gem_context *ctx,
 	       struct intel_engine_cs *engine,
-	       struct igt_spinner **spin_out)
+	       struct igt_spinner **spin)
 {
-	int ret = 0;
-
-	if (flags & (TEST_BUSY | TEST_RESET)) {
-		struct igt_spinner *spin;
-		struct i915_request *rq;
+	struct i915_request *rq;
+	int ret;
 
-		spin = kzalloc(sizeof(*spin), GFP_KERNEL);
-		if (!spin) {
-			ret = -ENOMEM;
-			goto out;
-		}
+	*spin = NULL;
+	if (!(flags & (TEST_BUSY | TEST_RESET)))
+		return 0;
 
-		ret = igt_spinner_init(spin, i915);
-		if (ret)
-			return ret;
+	*spin = kzalloc(sizeof(**spin), GFP_KERNEL);
+	if (!*spin)
+		return -ENOMEM;
 
-		rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
-		if (IS_ERR(rq)) {
-			ret = PTR_ERR(rq);
-			igt_spinner_fini(spin);
-			kfree(spin);
-			goto out;
-		}
+	ret = igt_spinner_init(*spin, i915);
+	if (ret)
+		goto err_free;
 
-		i915_request_add(rq);
+	rq = igt_spinner_create_request(*spin, ctx, engine, MI_NOOP);
+	if (IS_ERR(rq)) {
+		ret = PTR_ERR(rq);
+		goto err_fini;
+	}
 
-		if (!igt_wait_for_spinner(spin, rq)) {
-			pr_err("%s: Spinner failed to start!\n", name);
-			igt_spinner_end(spin);
-			igt_spinner_fini(spin);
-			kfree(spin);
-			ret = -ETIMEDOUT;
-			goto out;
-		}
+	i915_request_add(rq);
 
-		*spin_out = spin;
+	if (!igt_wait_for_spinner(*spin, rq)) {
+		pr_err("%s: Spinner failed to start!\n", name);
+		ret = -ETIMEDOUT;
+		goto err_end;
 	}
 
-out:
+	return 0;
+
+err_end:
+	igt_spinner_end(*spin);
+err_fini:
+	igt_spinner_fini(*spin);
+err_free:
+	kfree(fetch_and_zero(spin));
 	return ret;
 }
 
@@ -897,22 +895,23 @@ __sseu_test(struct drm_i915_private *i915,
 
 	ret = __sseu_prepare(i915, name, flags, ctx, engine, &spin);
 	if (ret)
-		goto out;
+		goto out_context;
 
 	ret = __i915_gem_context_reconfigure_sseu(ctx, engine, sseu);
 	if (ret)
-		goto out;
+		goto out_spin;
 
 	ret = __sseu_finish(i915, name, flags, ctx, kctx, engine, obj,
 			    hweight32(sseu.slice_mask), spin);
 
-out:
+out_spin:
 	if (spin) {
 		igt_spinner_end(spin);
 		igt_spinner_fini(spin);
 		kfree(spin);
 	}
 
+out_context:
 	kernel_context_close(kctx);
 
 	return ret;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author Reviewed-by on v1 1/1
#4 lore raw

Re: [PATCH] drm/i915/selftests: Always free spinner on __sseu_prepare error

Hi Chris,

Looks clean.

-Radhakrishna(RK) Sripada

Quoted 137 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Friday, February 15, 2019 11:50 AM
To: [email protected]
Cc: Chris Wilson <[email protected]>; Sripada, Radhakrishna <[email protected]>; Ursulin, Tvrtko <[email protected]>; Joonas Lahtinen <[email protected]>
Subject: [PATCH] drm/i915/selftests: Always free spinner on __sseu_prepare error

Prepare a nice little onion unwind to ensure that we always free the spinner if we __sseu_prepare fails.

Fixes c06ee6ff2cbc ("drm/i915/selftests: Context SSEU reconfiguration

tests")

Cc Radhakrishna Sripada <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 .../gpu/drm/i915/selftests/i915_gem_context.c | 69 +++++++++----------
 1 file changed, 34 insertions(+), 35 deletions(-)
drivers/gpu/drm/i915/selftests/i915_gem_context.c +34 -36
index d00d0bb07784..7eb58a9d1319 100644
@@ -710,47 +710,45 @@ __sseu_prepare(struct drm_i915_private *i915,
 	       unsigned int flags,
 	       struct i915_gem_context *ctx,
 	       struct intel_engine_cs *engine,
-	       struct igt_spinner **spin_out)
+	       struct igt_spinner **spin)
 {
-	int ret = 0;
-
-	if (flags & (TEST_BUSY | TEST_RESET)) {
-		struct igt_spinner *spin;
-		struct i915_request *rq;
+	struct i915_request *rq;
+	int ret;
 
-		spin = kzalloc(sizeof(*spin), GFP_KERNEL);
-		if (!spin) {
-			ret = -ENOMEM;
-			goto out;
-		}
+	*spin = NULL;
+	if (!(flags & (TEST_BUSY | TEST_RESET)))
+		return 0;
 
-		ret = igt_spinner_init(spin, i915);
-		if (ret)
-			return ret;
+	*spin = kzalloc(sizeof(**spin), GFP_KERNEL);
+	if (!*spin)
+		return -ENOMEM;
 
-		rq = igt_spinner_create_request(spin, ctx, engine,
 MI_NOOP);
-		if (IS_ERR(rq)) {
-			ret = PTR_ERR(rq);
-			igt_spinner_fini(spin);
-			kfree(spin);
-			goto out;
-		}
+	ret = igt_spinner_init(*spin, i915);
+	if (ret)
+		goto err_free;
 
-		i915_request_add(rq);
+	rq = igt_spinner_create_request(*spin, ctx, engine, MI_NOOP);
+	if (IS_ERR(rq)) {
+		ret = PTR_ERR(rq);
+		goto err_fini;
+	}
 
-		if (!igt_wait_for_spinner(spin, rq)) {
-			pr_err("%s: Spinner failed to start!\n", name);
-			igt_spinner_end(spin);
-			igt_spinner_fini(spin);
-			kfree(spin);
-			ret = -ETIMEDOUT;
-			goto out;
-		}
+	i915_request_add(rq);
 
-		*spin_out = spin;
+	if (!igt_wait_for_spinner(*spin, rq)) {
+		pr_err("%s: Spinner failed to start!\n", name);
+		ret = -ETIMEDOUT;
+		goto err_end;
 	}
 
-out:
+	return 0;
+
+err_end:
+	igt_spinner_end(*spin);
+err_fini:
+	igt_spinner_fini(*spin);
+err_free:
+	kfree(fetch_and_zero(spin));
 	return ret;
 }
@@ -897,22 +895,23 @@ __sseu_test(struct drm_i915_private *i915,
 
 	ret = __sseu_prepare(i915, name, flags, ctx, engine, &spin);
 	if (ret)
-		goto out;
+		goto out_context;
 
 	ret = __i915_gem_context_reconfigure_sseu(ctx, engine, sseu);
 	if (ret)
-		goto out;
+		goto out_spin;
 
 	ret = __sseu_finish(i915, name, flags, ctx, kctx, engine, obj,
 			    hweight32(sseu.slice_mask), spin);
 
-out:
+out_spin:
 	if (spin) {
 		igt_spinner_end(spin);
 		igt_spinner_fini(spin);
 		kfree(spin);
 	}
 
+out_context:
 	kernel_context_close(kctx);
 
 	return ret;
--
Quoted 1 line

2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✓ Fi.CI.BAT: success for drm/i915/selftests: Fix resource leak in __sseu_prepare (rev2)

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: drm/i915/selftests: Fix resource leak in __sseu_prepare (rev2)
URL : https://patchwork.freedesktop.org/series/56755/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5611 -> Patchwork_12229
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56755/revisions/2/mbox/

Known issues
------------

Here are the changes found in Patchwork_12229 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s4-devices:
- {fi-icl-y}: INCOMPLETE [fdo#107713] -> PASS

* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u3}: FAIL [fdo#103167] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109567]: https://bugs.freedesktop.org/show_bug.cgi?id=109567

Participating hosts (49 -> 42)
------------------------------

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-ivb-3770 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5611 -> Patchwork_12229

CI_DRM_5611: c09679e398a860df940ba35ad5102e396bf4acb5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4831: 616842ef493ead76ac6c75b2a93337439724655f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12229: 6a3e00cd6a15ae426cc8006606c74367c077dff9 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

6a3e00cd6a15 drm/i915/selftests: Always free spinner on __sseu_prepare error

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12229/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
In reply to Radhakrishna Sripada
Thank you for the patch! Yet something to improve:

Hi Radhakrishna,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190215]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Radhakrishna-Sripada/drm-i915-selftests-Fix-resource-leak-in-__sseu_prepare/20190216-081923
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-s1-201906 (attached as .config)
compiler: gcc-6 (Debian 6.5.0-2) 6.5.0 20181026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

In file included from drivers/gpu/drm/i915/i915_gem_context.c:1386:0:
drivers/gpu/drm/i915/selftests/i915_gem_context.c: In function '__sseu_prepare':

>> drivers/gpu/drm/i915/selftests/i915_gem_context.c:753:8: error: 'spin' undeclared (first use in this function)
     kfree(spin);
           ^~~~

drivers/gpu/drm/i915/selftests/i915_gem_context.c:753:8: note: each undeclared identifier is reported only once for each function it appears in

vim +/spin +753 drivers/gpu/drm/i915/selftests/i915_gem_context.c

706
707 static int
708 __sseu_prepare(struct drm_i915_private *i915,

   709		       const char *name,
   710		       unsigned int flags,
   711		       struct i915_gem_context *ctx,
   712		       struct intel_engine_cs *engine,
   713		       struct igt_spinner **spin_out)
   714	{
   715		int ret = 0;
   716	
   717		if (flags & (TEST_BUSY | TEST_RESET)) {
   718			struct igt_spinner *spin;
   719			struct i915_request *rq;
   720	
   721			spin = kzalloc(sizeof(*spin), GFP_KERNEL);
   722			if (!spin) {
   723				ret = -ENOMEM;
   724				goto out;
   725			}
   726	
   727			ret = igt_spinner_init(spin, i915);
   728			if (ret)
   729				goto clean;
   730	
   731			rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
   732			if (IS_ERR(rq)) {
   733				ret = PTR_ERR(rq);
   734				igt_spinner_fini(spin);
   735				goto clean;
   736			}
   737	
   738			i915_request_add(rq);
   739	
   740			if (!igt_wait_for_spinner(spin, rq)) {
   741				pr_err("%s: Spinner failed to start!\n", name);
   742				igt_spinner_end(spin);
   743				igt_spinner_fini(spin);
   744				ret = -ETIMEDOUT;
   745				goto clean;
   746			}
   747	
   748			*spin_out = spin;
   749			goto out;
   750		}
   751	
   752	clean:
 > 753		kfree(spin);

754 out:
755 return ret;
756 }
757

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
In reply to Radhakrishna Sripada
Thank you for the patch! Yet something to improve:

Hi Radhakrishna,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190215]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Radhakrishna-Sripada/drm-i915-selftests-Fix-resource-leak-in-__sseu_prepare/20190216-081923
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-k1-02151608 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-20) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

In file included from drivers/gpu/drm/i915/i915_gem_context.c:1386:
drivers/gpu/drm/i915/selftests/i915_gem_context.c: In function '__sseu_prepare':

>> drivers/gpu/drm/i915/selftests/i915_gem_context.c:753:8: error: 'spin' undeclared (first use in this function); did you mean 'fs_pin'?
     kfree(spin);
           ^~~~
           fs_pin

drivers/gpu/drm/i915/selftests/i915_gem_context.c:753:8: note: each undeclared identifier is reported only once for each function it appears in

vim +753 drivers/gpu/drm/i915/selftests/i915_gem_context.c

706
707 static int
708 __sseu_prepare(struct drm_i915_private *i915,

   709		       const char *name,
   710		       unsigned int flags,
   711		       struct i915_gem_context *ctx,
   712		       struct intel_engine_cs *engine,
   713		       struct igt_spinner **spin_out)
   714	{
   715		int ret = 0;
   716	
   717		if (flags & (TEST_BUSY | TEST_RESET)) {
   718			struct igt_spinner *spin;
   719			struct i915_request *rq;
   720	
   721			spin = kzalloc(sizeof(*spin), GFP_KERNEL);
   722			if (!spin) {
   723				ret = -ENOMEM;
   724				goto out;
   725			}
   726	
   727			ret = igt_spinner_init(spin, i915);
   728			if (ret)
   729				goto clean;
   730	
   731			rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
   732			if (IS_ERR(rq)) {
   733				ret = PTR_ERR(rq);
   734				igt_spinner_fini(spin);
   735				goto clean;
   736			}
   737	
   738			i915_request_add(rq);
   739	
   740			if (!igt_wait_for_spinner(spin, rq)) {
   741				pr_err("%s: Spinner failed to start!\n", name);
   742				igt_spinner_end(spin);
   743				igt_spinner_fini(spin);
   744				ret = -ETIMEDOUT;
   745				goto clean;
   746			}
   747	
   748			*spin_out = spin;
   749			goto out;
   750		}
   751	
   752	clean:
 > 753		kfree(spin);

754 out:
755 return ret;
756 }
757

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.IGT: success for drm/i915/selftests: Fix resource leak in __sseu_prepare (rev2)

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: drm/i915/selftests: Fix resource leak in __sseu_prepare (rev2)
URL : https://patchwork.freedesktop.org/series/56755/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5611_full -> Patchwork_12229_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_12229_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-iclb: NOTRUN -> FAIL [fdo#107725]

* igt@kms_color@pipe-a-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]

* igt@kms_cursor_crc@cursor-128x42-random:
- shard-iclb: NOTRUN -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +2

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-kbl: PASS -> DMESG-WARN [fdo#108566]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: PASS -> FAIL [fdo#103167] +4

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167]

* igt@kms_hdmi_inject@inject-audio:
- shard-iclb: NOTRUN -> FAIL [fdo#102370]

* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-iclb: NOTRUN -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +2

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-iclb: PASS -> FAIL [fdo#103166] +1

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> FAIL [fdo#104894] +1

* igt@pm_rpm@debugfs-read:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +2

#### Possible fixes ####

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-iclb: FAIL [fdo#103833] / [fdo#105681] -> PASS

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#102887] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS
- shard-glk: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: FAIL [fdo#103167] -> PASS

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-iclb: INCOMPLETE [fdo#107713] -> PASS

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS

* igt@kms_sysfs_edid_timing:
- shard-iclb: FAIL [fdo#100047] -> PASS

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-hsw: FAIL [fdo#104894] -> PASS

* igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
- shard-apl: FAIL [fdo#104894] -> PASS +2

* igt@pm_rpm@drm-resources-equal:
- shard-iclb: INCOMPLETE [fdo#108840] -> PASS

* igt@pm_rpm@gem-pread:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +3

#### Warnings ####

* igt@i915_suspend@shrink:
- shard-glk: INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133] -> DMESG-WARN [fdo#109244]

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-iclb: INCOMPLETE [fdo#107713] -> FAIL [fdo#103232]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102370]: https://bugs.freedesktop.org/show_bug.cgi?id=102370
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105681]: https://bugs.freedesktop.org/show_bug.cgi?id=105681
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109275]: https://bugs.freedesktop.org/show_bug.cgi?id=109275
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109281]: https://bugs.freedesktop.org/show_bug.cgi?id=109281
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109287]: https://bugs.freedesktop.org/show_bug.cgi?id=109287
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109624]: https://bugs.freedesktop.org/show_bug.cgi?id=109624
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (7 -> 6)
------------------------------

Missing (1): shard-skl

Build changes
-------------

* Linux: CI_DRM_5611 -> Patchwork_12229

CI_DRM_5611: c09679e398a860df940ba35ad5102e396bf4acb5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4831: 616842ef493ead76ac6c75b2a93337439724655f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12229: 6a3e00cd6a15ae426cc8006606c74367c077dff9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12229/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx