Skip to contentSkip to conversation

package/upmpdcli: needs NPTL

PATCH New Fabrice Fontaine 3 participants 3 messages Feb 16, 2019 – Feb 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/upmpdcli: needs NPTL

The software uses pthread_mutexattr_setrobust which isn't available in uClibc-ng Linuxthreads support.

Fixes:
- http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555

---
 package/upmpdcli/Config.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
package/upmpdcli/Config.in +5 -3
index 938024e8a2..74eb768830 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11, libupnpp
 	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_LIBMICROHTTPD
@@ -15,6 +15,8 @@ config BR2_PACKAGE_UPMPDCLI
 
 	  http://www.lesbonscomptes.com/upmpdcli/
 
-comment "upmpdcli needs a toolchain w/ C++, threads, gcc >= 4.9"
+comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 4.9"
 	depends on BR2_USE_MMU
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/upmpdcli: needs NPTL

Quoted 25 lines · Fabrice Fontaine

The software uses pthread_mutexattr_setrobust which isn't available in uClibc-ng Linuxthreads support.

Fixes:
- http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555

---
 package/upmpdcli/Config.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
package/upmpdcli/Config.in +1 -1
index 938024e8a2..74eb768830 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11, libupnpp
 	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_LIBMICROHTTPD

package/upmpdcli/Config.in config BR2_PACKAGE_UPMPDCLI · line 22

Quoted 10 lines
package/upmpdcli/Config.in +4 -2
@@ -15,6 +15,8 @@ config BR2_PACKAGE_UPMPDCLI
 
 	  http://www.lesbonscomptes.com/upmpdcli/
 
-comment "upmpdcli needs a toolchain w/ C++, threads, gcc >= 4.9"
+comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 4.9"
 	depends on BR2_USE_MMU
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

pthread_mutexattr_setrobust and PTHREAD_MUTEXATTR_FLAG_ROBUST are only available in NPTL [1]. Therefore:

[1] https://elixir.bootlin.com/uclibc-ng/v1.0.31/ident/PTHREAD_MUTEXATTR_FLAG_ROBUST

#2 lore raw

PATCH 1/1 package/upmpdcli: needs NPTL

In reply to Fabrice Fontaine

Hello Fabrice,

Quoted 7 lines · On Sat, 16 Feb 2019 11:42:02 +0100 Fabrice Fontaine…

The software uses pthread_mutexattr_setrobust which isn't available in uClibc-ng Linuxthreads support.

Fixes:
- http://autobuild.buildroot.org/results/197615ad077b0a719954024c3ba182dac43a0555

Applied to master, thanks. However...

package/upmpdcli/Config.in config BR2_PACKAGE_UPMPDCLI · line 5

Quoted 13 lines
---
 package/upmpdcli/Config.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
package/upmpdcli/Config.in +0 -1
index 938024e8a2..74eb768830 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp

... I'm not sure on which commit you based this on, but in master, this line looked like this:

depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp, libmicrohttpd

so your patch didn't apply. I fixed this up manually.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com