Skip to contentSkip to conversation

drm/audio: declaration of struct device

PATCH In review Ramalingam C via dri-devel 3 participants 3 messages Feb 16, 2019 – Feb 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/audio: declaration of struct device

Header has used the references to struct device without it definition or declaration. Hence resulting in compilation warning such as

"'struct device' declared inside parameter list..."

This changes adds a declaration to struct device in the header to avoid any such warnings.

cc Takashi Iwai <[email protected]>
cc Daniel Vetter <[email protected]>
---
 include/drm/drm_audio_component.h | 1 +
 1 file changed, 1 insertion(+)
include/drm/drm_audio_component.h +1 -0
index d0c7444319f5..a45f93487039 100644
@@ -5,6 +5,7 @@
 #define _DRM_AUDIO_COMPONENT_H_
 
 struct drm_audio_component;
+struct device;
 
 /**
  * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

✗ Fi.CI.BAT: failure for drm/audio: declaration of struct device (rev2)

== Series Details ==

== Series Details ==

Series: drm/audio: declaration of struct device (rev2)
URL : https://patchwork.freedesktop.org/series/56757/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5615 -> Patchwork_12236
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12236 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12236, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56757/revisions/2/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12236:

### IGT changes ###

#### Possible regressions ####

* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6770hq: PASS -> DMESG-WARN +2

Known issues
------------

Here are the changes found in Patchwork_12236 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_content_protection@atomic:
- fi-skl-gvtdvm: NOTRUN -> FAIL [fdo#108597] +1

* igt@kms_content_protection@legacy:
- fi-skl-6770hq: NOTRUN -> FAIL [fdo#108597]
- fi-cfl-8109u: NOTRUN -> FAIL [fdo#108739] +1

* igt@kms_pipe_crc_basic@bad-source:
- fi-skl-6770hq: PASS -> DMESG-WARN [fdo#108833]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS

* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108833]: https://bugs.freedesktop.org/show_bug.cgi?id=108833
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527

Participating hosts (43 -> 39)
------------------------------

Missing (4): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-apl-guc

Build changes
-------------

* IGT: IGT_4833 -> IGTPW_2356
* Linux: CI_DRM_5615 -> Patchwork_12236

CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2356: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2356/
IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12236: 4c1aa9392e301de54a97dd3086fe6d0b654fbc18 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

4c1aa9392e30 drm/audio: declaration of struct device

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12236/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Ramalingam C via dri-devel
Quoted 11 lines · Ramalingam C

Header has used the references to struct device without it definition or declaration. Hence resulting in compilation warning such as

"'struct device' declared inside parameter list..."

This changes adds a declaration to struct device in the header to avoid any such warnings.

cc Takashi Iwai <[email protected]>
cc Daniel Vetter <[email protected]>

Ok, I'll pick this one up for the mei-hdcp topic branch too. -Daniel

Quoted 19 lines
---
 include/drm/drm_audio_component.h | 1 +
 1 file changed, 1 insertion(+)
include/drm/drm_audio_component.h +1 -0
index d0c7444319f5..a45f93487039 100644
@@ -5,6 +5,7 @@
 #define _DRM_AUDIO_COMPONENT_H_
 
 struct drm_audio_component;
+struct device;
 
 /**
  * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
Signature · 1 line
2.7.4
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx