Skip to contentSkip to conversation

package/ipmiutil: fix build with openssl 1.1.x

PATCH New Fabrice Fontaine 3 participants 5 messages Feb 17, 2019 – Feb 20, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ipmiutil: fix build with openssl 1.1.x

Fixes:
- http://autobuild.buildroot.org/results/1d868798c5b80d7b41123f988449ef548dd95490

---
 package/ipmiutil/ipmiutil.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ipmiutil/ipmiutil.mk +1 -1
index 5d8c45665d..0d9a4509b3 100644
@@ -18,7 +18,7 @@ ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
 # tests against distro libcrypto so it might get a false positive when
 # the openssl version is old, so force it off
 # SKIP_MD2 can be used only if ALLOW_GNU is defined.
-IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2"
+IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2 -DSSL11"
 IPMIUTIL_DEPENDENCIES += openssl
 else
 IPMIUTIL_CONF_OPTS += --disable-lanplus
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/ipmiutil: fix build with openssl 1.1.x

Hello,

Quoted 13 lines · On Sun, 17 Feb 2019 17:24:32 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/1d868798c5b80d7b41123f988449ef548dd95490

---
 package/ipmiutil/ipmiutil.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ipmiutil/ipmiutil.mk +0 -0
index 5d8c45665d..0d9a4509b3 100644

package/ipmiutil/ipmiutil.mk ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx) · line 21

Quoted 5 lines
package/ipmiutil/ipmiutil.mk +1 -1
@@ -18,7 +18,7 @@ ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
 # tests against distro libcrypto so it might get a false positive when
 # the openssl version is old, so force it off
 # SKIP_MD2 can be used only if ALLOW_GNU is defined.
-IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2"
+IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2 -DSSL11"

How does that play with LibreSSL instead of OpenSSL ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/ipmiutil: fix build with openssl 1.1.x

Dear Thomas,
Le dim. 17 f?vr. 2019 ? 20:56, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 14 lines

Hello,

Quoted 8 lines · On Sun, 17 Feb 2019 17:24:32 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/1d868798c5b80d7b41123f988449ef548dd95490

---
 package/ipmiutil/ipmiutil.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

package/ipmiutil/ipmiutil.mk ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx) · line 21

Quoted 10 lines
package/ipmiutil/ipmiutil.mk +1 -1
index 5d8c45665d..0d9a4509b3 100644
@@ -18,7 +18,7 @@ ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
 # tests against distro libcrypto so it might get a false positive when
 # the openssl version is old, so force it off
 # SKIP_MD2 can be used only if ALLOW_GNU is defined.
-IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2"
+IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2 -DSSL11"

How does that play with LibreSSL instead of OpenSSL ?

I didn't think about LibreSSL, I think it'll probably break, I'll test it and will probably send a v2.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice

#3 lore raw

PATCH 1/1 package/ipmiutil: fix build with openssl 1.1.x

Dear Thomas,
Le dim. 17 f?vr. 2019 ? 21:03, Fabrice Fontaine
<[email protected]> a ?crit :

Quoted 30 lines

Dear Thomas,
Le dim. 17 f?vr. 2019 ? 20:56, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 14 lines

Hello,

Quoted 8 lines · On Sun, 17 Feb 2019 17:24:32 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/1d868798c5b80d7b41123f988449ef548dd95490

---
 package/ipmiutil/ipmiutil.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

package/ipmiutil/ipmiutil.mk ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx) · line 21

Quoted 10 lines
package/ipmiutil/ipmiutil.mk +1 -1
index 5d8c45665d..0d9a4509b3 100644
@@ -18,7 +18,7 @@ ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
 # tests against distro libcrypto so it might get a false positive when
 # the openssl version is old, so force it off
 # SKIP_MD2 can be used only if ALLOW_GNU is defined.
-IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2"
+IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2 -DSSL11"

How does that play with LibreSSL instead of OpenSSL ?

Quoted 2 lines

I didn't think about LibreSSL, I think it'll probably break, I'll test it and will probably send a v2.

Finally, the test was successful as EVP_CIPHER_CTX_new is also available in LibreSSL.

Quoted 11 lines
Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice

Best Regards,

Fabrice

#4 lore raw

PATCH 1/1 package/ipmiutil: fix build with openssl 1.1.x

Quoted 30 lines · Fabrice Fontaine

Dear Thomas,
Le dim. 17 f?vr. 2019 ? 21:03, Fabrice Fontaine
<[email protected]> a ?crit :

Quoted 27 lines

Dear Thomas,
Le dim. 17 f?vr. 2019 ? 20:56, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 24 lines

Hello,

Quoted 13 lines · On Sun, 17 Feb 2019 17:24:32 +0100 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/1d868798c5b80d7b41123f988449ef548dd95490

---
 package/ipmiutil/ipmiutil.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ipmiutil/ipmiutil.mk +0 -0
index 5d8c45665d..0d9a4509b3 100644

package/ipmiutil/ipmiutil.mk ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx) · line 21

Quoted 5 lines
package/ipmiutil/ipmiutil.mk +1 -1
@@ -18,7 +18,7 @@ ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
 # tests against distro libcrypto so it might get a false positive when
 # the openssl version is old, so force it off
 # SKIP_MD2 can be used only if ALLOW_GNU is defined.
-IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2"
+IPMIUTIL_CONF_OPTS += CPPFLAGS="$(TARGET_CPPFLAGS) -DALLOW_GNU -DSKIP_MD2 -DSSL11"

How does that play with LibreSSL instead of OpenSSL ?

Quoted 4 lines
Quoted 2 lines

I didn't think about LibreSSL, I think it'll probably break, I'll test it and will probably send a v2.

Finally, the test was successful as EVP_CIPHER_CTX_new is also available in LibreSSL.

I've added this observation to the commit message and applied to master, thanks.

Regards,
Arnout