Skip to contentSkip to conversation

net: vrf: remove MTU limits for vrf device

PATCH Applied Hangbin Liu 3 participants 4 messages Feb 18, 2019 – Feb 21, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: vrf: remove MTU limits for vrf device

Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and ifb device"), MTU is irrelevant for VRF device. We init it as 64K while limit it to [68, 1500] may make users feel confused.

---
 drivers/net/vrf.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/vrf.c +3 -0
index 95909e262ba4..7c1430ed0244 100644
@@ -1273,6 +1273,9 @@ static void vrf_setup(struct net_device *dev)
 
 	/* default to no qdisc; user can add if desired */
 	dev->priv_flags |= IFF_NO_QUEUE;
+
+	dev->min_mtu = 0;
+	dev->max_mtu = 0;
 }
 
 static int vrf_validate(struct nlattr *tb[], struct nlattr *data[],
Signature · 1 line
2.19.2
#1 lore raw
Quoted 1 line · Hangbin Liu

Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and

Similar...

Thanks Davide help point it out.

Regards
Hangbin

Reviewed-by on v1 1/1
#2 lore raw
In reply to Hangbin Liu
Quoted 16 lines · Hangbin Liu

Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and ifb device"), MTU is irrelevant for VRF device. We init it as 64K while limit it to [68, 1500] may make users feel confused.

---
 drivers/net/vrf.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/vrf.c +0 -0
index 95909e262ba4..7c1430ed0244 100644

drivers/net/vrf.c static void vrf_setup(struct net_device *dev) · line 1281

Quoted 9 lines
drivers/net/vrf.c +3 -0
@@ -1273,6 +1273,9 @@ static void vrf_setup(struct net_device *dev)
 
 	/* default to no qdisc; user can add if desired */
 	dev->priv_flags |= IFF_NO_QUEUE;
+
+	dev->min_mtu = 0;
+	dev->max_mtu = 0;
 }
 
 static int vrf_validate(struct nlattr *tb[], struct nlattr *data[],