Skip to contentSkip to conversation

s390: vsie: Use effective CRYCBD.31 to check CRYCBD validity

GIT PULL Christian Borntraeger 1 participant 1 message Feb 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: Pierre Morel <[email protected]>

When facility.76 MSAX3 is present for the guest we must issue a validity interception if the CRYCBD is not valid.

The bit CRYCBD.31 is an effective field and tested at each guest level and has for effect to mask the facility.76

It follows that if CRYCBD.31 is clear and AP is not in use we do not have to test the CRYCBD validatity even if facility.76 is present in the host.

Fixes 6ee74098201b ("KVM: s390: vsie: allow CRYCB FORMAT-0")

Message-Id: <[email protected]>

---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +1 -1
index a153257bf7d98..d62fa148558b9 100644
@@ -297,7 +297,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 	scb_s->crycbd = 0;
 
 	apie_h = vcpu->arch.sie_block->eca & ECA_APIE;
-	if (!apie_h && !key_msk)
+	if (!apie_h && (!key_msk || fmt_o == CRYCB_FORMAT0))
 		return 0;
 
 	if (!crycb_addr)
Signature · 1 line
2.19.1