Skip to contentSkip to conversation

mips_fulong2e: Add on-board graphics chip

PATCH In review BALATON Zoltan 3 participants 4 messages Feb 18, 2019 – Feb 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mips_fulong2e: Add on-board graphics chip

Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet.

Based-on: [email protected]

---
 hw/mips/mips_fulong2e.c | 6 ++++++
 1 file changed, 6 insertions(+)
hw/mips/mips_fulong2e.c +6 -0
index eec6fd02c8..68bd030fc1 100644
@@ -287,6 +287,7 @@ static void mips_fulong2e_init(MachineState *machine)
     I2CBus *smbus;
     MIPSCPU *cpu;
     CPUMIPSState *env;
+    DeviceState *dev;
 
     /* init CPUs */
     cpu = MIPS_CPU(cpu_create(machine->cpu_type));
@@ -347,6 +348,11 @@ static void mips_fulong2e_init(MachineState *machine)
     vt82c686b_southbridge_init(pci_bus, FULONG2E_VIA_SLOT, env->irq[5],
                                &smbus, &isa_bus);
 
+    /* GPU */
+    dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
+    qdev_prop_set_uint16(dev, "device_id", 0x5159);
+    qdev_init_nofail(dev);
+
     /* Populate SPD eeprom data */
     spd_data = spd_data_generate(DDR, ram_size, &err);
     if (err) {
Signature · 1 line
2.13.7
#1 lore raw
Quoted 7 lines · BALATON Zoltan

Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet.

Mojibake :S

---

Quoted 1 line

Based-on: [email protected]

The 'based-on' tag goes below the '---' separator to avoid to keep it indefinitely in the git history.

Quoted 29 lines
---
 hw/mips/mips_fulong2e.c | 6 ++++++
 1 file changed, 6 insertions(+)
hw/mips/mips_fulong2e.c +6 -0
index eec6fd02c8..68bd030fc1 100644
@@ -287,6 +287,7 @@ static void mips_fulong2e_init(MachineState *machine)
     I2CBus *smbus;
     MIPSCPU *cpu;
     CPUMIPSState *env;
+    DeviceState *dev;
 
     /* init CPUs */
     cpu = MIPS_CPU(cpu_create(machine->cpu_type));
@@ -347,6 +348,11 @@ static void mips_fulong2e_init(MachineState *machine)
     vt82c686b_southbridge_init(pci_bus, FULONG2E_VIA_SLOT, env->irq[5],
                                &smbus, &isa_bus);
 
+    /* GPU */
+    dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
+    qdev_prop_set_uint16(dev, "device_id", 0x5159);
+    qdev_init_nofail(dev);
+
     /* Populate SPD eeprom data */
     spd_data = spd_data_generate(DDR, ram_size, &err);
     if (err) {
Reviewed-by on v2 1/1
#2 lore raw
In reply to BALATON Zoltan
Quoted 7 lines

From: BALATON Zoltan <[email protected]>
Subject: [PATCH v2] mips_fulong2e: Add on-board graphics chip

Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet.

Quoted 8 lines

Based-on: [email protected]
---
hw/mips/mips_fulong2e.c | 6 ++++++

1 file changed, 6 insertions(+)

Zoltan, perhaps you ought to create a mini series consisting of the patch

https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg02471.html

and this patch.

I would like to apply this patch independently to MIPS queue, but I can't, because of interdependencies og the two patches.

I would feel comfortable with both patches going through graphics pull request.

Thanks again for all efforts!

Aleksandar

#3 lore raw
Quoted 22 lines · Aleksandar Markovic
Quoted 7 lines

From: BALATON Zoltan <[email protected]>
Subject: [PATCH v2] mips_fulong2e: Add on-board graphics chip

Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet.

Quoted 8 lines

Based-on: [email protected]
---
hw/mips/mips_fulong2e.c | 6 ++++++

1 file changed, 6 insertions(+)

Zoltan, perhaps you ought to create a mini series consisting of the patch

https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg02471.html

Quoted 7 lines

and this patch.

I would like to apply this patch independently to MIPS queue, but I can't, because of interdependencies og the two patches.

I would feel comfortable with both patches going through graphics pull request.

OK, I'll resubmit this together with the next version of the prerequisite ATI patch cc-ing Gerd so he can take them together. Thanks for review. (The ATI VGA patch is still under review so maybe we will have a few more versions before it will be merged.)

Regards,
BALATON Zoltan