scripts/gdb: fix linux constants
A message that is not in the archive (sent off-list or not yet received): 20190215191713.GA28287@nessie
Kieran Bingham
Reviewed-byHi Dan,
Thank you for the patch,
Quoted 7 lines · Dan Robertson
The linux constants
MS_RDONLY,MS_SYNCHRONOUS,MS_MANDLOCK,MS_DIRSYNC,MS_NOATIME, andMS_NODIRATIMEwere previously defined inlinux/fs.h. Followinge262e32d6bde0f77fb0c95d977482fc872c51996the constants are now defined inuapi/linux/mount.h. The new location of the defined constants needs to be included inconstants.pytemplate in order for the correct constants to be generated.
This commit was pipped to the post by a similar patch [0] from Felipe Balbi
[0]
https://lore.kernel.org/lkml/[email protected]/
Combined together they would form a complete patch, but this one could do with the Fixes: tag such as
unless explicitly enabled"
With a Fixes: tag:
Quoted 10 lines
Signed-off-by Dan Robertson <[email protected]>--- scripts/gdb/linux/constants.py.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)scripts/gdb/linux/constants.py.in +0
-0
scripts/gdb/linux/constants.py.in line 15
Quoted 4 lines
scripts/gdb/linux/constants.py.in +0
-1@@ -12,9 +12,9 @@ * */ -#include <linux/fs.h>
Whereas Felipe's patch does not include this change (which I think it looks like it should)
How should we proceed with these two competing patches? Any preference from anyone?
Content wise, I feel like this one is in the lead - just missing the
Fixes: tag, but Felipe's won the race...
--
Kieran
Quoted 16 lines
scripts/gdb/linux/constants.py.in +2
-1#include <linux/mount.h> #include <linux/of_fdt.h> +#include <uapi/linux/mount.h> /* We need to stringify expanded macros so that they can be parsed */@@ -36,7 +36,7 @@ import gdb -/* linux/fs.h */ +/* uapi/linux/mount.h */ LX_VALUE(MS_RDONLY) LX_VALUE(MS_SYNCHRONOUS) LX_VALUE(MS_MANDLOCK)
Signature · 3 lines
Regards -- Kieran
Kieran,
Quoted 1 line
This commit was pipped to the post by a similar patch [0] from Felipe Balbi
No problem! I probably should watch the LKML closer.
Go with the patch from Felipe, but like you men there is definitely no need for the include linux/fs.h now.
Thanks for the tip on the Fixes tag. As a kernel newbie tips like this are appreciated.
Cheers,
Dan
cover scripts/gdb: fix linux constants
In reply to Kieran BinghamAdd Fixes tag to commit
Dan Robertson (1):
scripts/gdb: fix linux constants
scripts/gdb/linux/constants.py.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/1 scripts/gdb: fix linux constants
The linux constants MS_RDONLY, MS_SYNCHRONOUS, MS_MANDLOCK, MS_DIRSYNC, MS_NOATIME, and MS_NODIRATIME were previously defined in linux/fs.h. Following e262e32d6bde0f77fb0c95d977482fc872c51996 the constants are now defined in uapi/linux/mount.h. The new location of the defined constants needs to be included in constants.py template in order for the correct constants to be generated.
--- scripts/gdb/linux/constants.py.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/gdb/linux/constants.py.in +2 -2
@@ -12,9 +12,9 @@ * */ -#include <linux/fs.h> #include <linux/mount.h> #include <linux/of_fdt.h> +#include <uapi/linux/mount.h> /* We need to stringify expanded macros so that they can be parsed */
@@ -36,7 +36,7 @@ import gdb -/* linux/fs.h */ +/* uapi/linux/mount.h */ LX_VALUE(MS_RDONLY) LX_VALUE(MS_SYNCHRONOUS) LX_VALUE(MS_MANDLOCK)
Signature · 1 line
2.20.1