Skip to contentSkip to conversation

drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

PATCH In review David Santamaría Rogado via dri-devel 4 participants 5 messages Feb 16, 2019 – Feb 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

From: howl <[email protected]>

The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +9 -9
index 52e445bb1aa5..61d3361381b7 100644
@@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
 		},
-		.driver_data = (void *)&acer_s1003,
+		.driver_data = &acer_s1003,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
 		},
-		.driver_data = (void *)&asus_t100ha,
+		.driver_data = &asus_t100ha,
 	}, {	/*
 		 * GPD Pocket, note that the the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_pocket,
+		.driver_data = &gpd_pocket,
 	}, {	/* GPD Win (same note on DMI match as GPD Pocket) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_win,
+		.driver_data = &gpd_win,
 	}, {	/* GPD Win 2 (too generic strings, also match on bios date) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_win2,
+		.driver_data = &gpd_win2,
 	}, {	/* I.T.Works TW891 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
 		},
-		.driver_data = (void *)&itworks_tw891,
+		.driver_data = &itworks_tw891,
 	}, {	/*
 		 * Lenovo Ideapad Miix 310 laptop, only some production batches
 		 * have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	}, {	/* Lenovo Ideapad Miix 320 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	},
 	{}
 };
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH 2/2 drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

From: howl <[email protected]>

Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console ouput gets rotated at boot as Miix 310.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +13 -0
index 61d3361381b7..835574e2d5bf 100644
@@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
+	.width = 1200,
+	.height = 1920,
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct dmi_system_id orientation_data[] = {
 	{	/* Acer One 10 (S1003) */
 		.matches = {
@@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
 		},
 		.driver_data = &itworks_tw891,
+	}, {	/* Lenovo Ideapad D330 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+		},
+		.driver_data = &lcd1200x1920_rightside_up,
 	}, {	/*
 		 * Lenovo Ideapad Miix 310 laptop, only some production batches
 		 * have a portrait screen, the resolution checks makes the quirk
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/2
#2 lore raw
In reply to David Santamaría Rogado via dri-devel
Quoted 6 lines · David Santamaría Rogado

From: howl <[email protected]>

The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula.

Quoted 84 lines
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +9 -9
index 52e445bb1aa5..61d3361381b7 100644
@@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
 		},
-		.driver_data = (void *)&acer_s1003,
+		.driver_data = &acer_s1003,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
 		},
-		.driver_data = (void *)&asus_t100ha,
+		.driver_data = &asus_t100ha,
 	}, {	/*
 		 * GPD Pocket, note that the the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_pocket,
+		.driver_data = &gpd_pocket,
 	}, {	/* GPD Win (same note on DMI match as GPD Pocket) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_win,
+		.driver_data = &gpd_win,
 	}, {	/* GPD Win 2 (too generic strings, also match on bios date) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_win2,
+		.driver_data = &gpd_win2,
 	}, {	/* I.T.Works TW891 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
 		},
-		.driver_data = (void *)&itworks_tw891,
+		.driver_data = &itworks_tw891,
 	}, {	/*
 		 * Lenovo Ideapad Miix 310 laptop, only some production batches
 		 * have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	}, {	/* Lenovo Ideapad Miix 320 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	},
 	{}
 };
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw
In reply to David Santamaría Rogado via dri-devel
Quoted 1 line · David Santamaría Rogado

From: howl <[email protected]>

Any reason why this differs from the Signed-off-by line? Perhaps check your git configuration if this wasn't on purpose. Or perhaps you've fixed the configuration since you authored the commits, in which case you should be able to fix this by doing this:

	$ git commit --reset-author --amend

You'd need to run that for each of the commits.

Thierry

Quoted 92 lines

The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +9 -9
index 52e445bb1aa5..61d3361381b7 100644
@@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
 		},
-		.driver_data = (void *)&acer_s1003,
+		.driver_data = &acer_s1003,
 	}, {	/* Asus T100HA */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
 		},
-		.driver_data = (void *)&asus_t100ha,
+		.driver_data = &asus_t100ha,
 	}, {	/*
 		 * GPD Pocket, note that the the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_pocket,
+		.driver_data = &gpd_pocket,
 	}, {	/* GPD Win (same note on DMI match as GPD Pocket) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_win,
+		.driver_data = &gpd_win,
 	}, {	/* GPD Win 2 (too generic strings, also match on bios date) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
 		},
-		.driver_data = (void *)&gpd_win2,
+		.driver_data = &gpd_win2,
 	}, {	/* I.T.Works TW891 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
 		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
 		},
-		.driver_data = (void *)&itworks_tw891,
+		.driver_data = &itworks_tw891,
 	}, {	/*
 		 * Lenovo Ideapad Miix 310 laptop, only some production batches
 		 * have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	}, {	/* Lenovo Ideapad Miix 320 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
 		},
-		.driver_data = (void *)&lcd800x1280_rightside_up,
+		.driver_data = &lcd800x1280_rightside_up,
 	},
 	{}
 };
Signature · 1 line
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

I have my mail and real name in git configuration but it has taken my computer's username. I suppose there should be a way to make git to take the real name I have set in it's configuration. Will check it and resend as I won't do ammend cause I have signed of by all public commits as in these patches. Wanted to bring this up at time for 5.0 to have it out of the box in the next Fedora but I suppose is not going to be possible.

Thanks for the guidance you are giving to me.

Quoted 8 lines · Thierry Reding
Quoted 1 line · David Santamaría Rogado

From: howl <[email protected]>

Any reason why this differs from the Signed-off-by line? Perhaps check your git configuration if this wasn't on purpose. Or perhaps you've fixed the configuration since you authored the commits, in which case you should be able to fix this by doing this:

Quoted 8 lines
        $ git commit --reset-author --amend

You'd need to run that for each of the commits.

Thierry

Quoted 2 lines

The (void *) casting in the driver_data variable assignment is

superfluous.

Quoted 8 lines

Review

Quoted 8 lines

Spotted by Jani Nikula.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/drm_panel_orientation_quirks.c

Quoted 4 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[]

Quoted 4 lines

index 52e445bb1aa5..61d3361381b7 100644

drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
@@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[]

= {

Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
              },
-             .driver_data = (void *)&acer_s1003,
+             .driver_data = &acer_s1003,
      }, {    /* Asus T100HA */
Quoted 8 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] = {

Quoted 8 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
              },
-             .driver_data = (void *)&asus_t100ha,
+             .driver_data = &asus_t100ha,
      }, {    /*
               * GPD Pocket, note that the the DMI data is less generic

then

Quoted 1 line

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] · line 98

Quoted 1 line
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
               * it seems, devices with a board-vendor of "AMI

Corporation"

Quoted 1 line

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[]

Quoted 1 line
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[]

= {

Quoted 9 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[]

Quoted 9 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
                DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
              },
-             .driver_data = (void *)&gpd_pocket,
+             .driver_data = &gpd_pocket,
      }, {    /* GPD Win (same note on DMI match as GPD Pocket) */
              .matches = {
                DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[]

= {

Quoted 6 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] = {

Quoted 6 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
                DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
              },
-             .driver_data = (void *)&gpd_win,
+             .driver_data = &gpd_win,
      }, {    /* GPD Win 2 (too generic strings, also match on bios

date) */

Quoted 3 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[]

Quoted 3 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[]

= {

Quoted 8 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] = {

Quoted 8 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
                DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
                DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
              },
-             .driver_data = (void *)&gpd_win2,
+             .driver_data = &gpd_win2,
      }, {    /* I.T.Works TW891 */
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by

O.E.M."),

Quoted 1 line

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[]

Quoted 1 line
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[]

= {

Quoted 1 line

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] · line 129

Quoted 1 line
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
                DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by

O.E.M."),

Quoted 6 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] = {

Quoted 6 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
                DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
              },
-             .driver_data = (void *)&itworks_tw891,
+             .driver_data = &itworks_tw891,
      }, {    /*
               * Lenovo Ideapad Miix 310 laptop, only some production

batches

Quoted 1 line

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] · line 135

Quoted 1 line
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
               * have a portrait screen, the resolution checks makes the

quirk

Quoted 1 line

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id

Quoted 1 line
drivers/gpu/drm/drm_panel_orientation_quirks.c +0 -0
@@ -140,20 +140,20 @@ static const struct dmi_system_id

orientation_data[] = {

Quoted 10 lines

drivers/gpu/drm/drm_panel_orientation_quirks.c static const struct dmi_system_id orientation_data[] = {

Quoted 10 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
                DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
              },
-             .driver_data = (void *)&lcd800x1280_rightside_up,
+             .driver_data = &lcd800x1280_rightside_up,
      }, {    /* Lenovo Ideapad Miix 320 */
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX

320-10ICR"),

Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -1
              },
-             .driver_data = (void *)&lcd800x1280_rightside_up,
+             .driver_data = &lcd800x1280_rightside_up,
      }, {    /* VIOS LTH17 */
              .matches = {
                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
              },
Quoted 9 lines
Quoted 8 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +1 -2
-             .driver_data = (void *)&lcd800x1280_rightside_up,
+             .driver_data = &lcd800x1280_rightside_up,
      },
      {}
 };
--

2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel