Skip to contentSkip to conversation

pvh/dom0/shadow/amd fixes

PATCH Superseded Roger Pau Monne 4 participants 18 messages Feb 18, 2019 – Feb 21, 2019

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v4 cover pvh/dom0/shadow/amd fixes

The remaining set of patches contain changes to the p2m code that could affect HVM guests. Note that without those changes a PVH dom0 running on AMD hardware will be unable to create guests. Overall the patches are a nice cleanup to the handling of p2m_ioreq_server and p2m_map_foreign types IMO.

The series can also be found at:

git://xenbits.xen.org/people/royger/xen.git fixes-v4

Thanks, Roger.

Roger Pau Monne (4):
x86/mm: split p2m ioreq server pages special handling into helper
p2m: change write_p2m_entry to return an error code x86/mm: handle foreign mappings in p2m_entry_modify npt/shadow: allow getting foreign page table entries

 xen/arch/x86/mm/hap/hap.c        |  15 ++++-
 xen/arch/x86/mm/hap/nested_hap.c |   4 +-
 xen/arch/x86/mm/p2m-ept.c        | 107 ++++++-------------------------
 xen/arch/x86/mm/p2m-pt.c         |  92 +++++++++++++-------------
 xen/arch/x86/mm/paging.c         |  12 ++--
 xen/arch/x86/mm/shadow/common.c  |   8 ++-
 xen/arch/x86/mm/shadow/none.c    |   7 +-
 xen/arch/x86/mm/shadow/private.h |   6 +-
 xen/include/asm-x86/p2m.h        |  62 +++++++++++++++++-
 xen/include/asm-x86/paging.h     |   8 +--
 10 files changed, 171 insertions(+), 150 deletions(-)
Signature · 7 lines
2.17.2 (Apple Git-113)


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw

PATCH v4 1/4 x86/mm: split p2m ioreq server pages special handling into helper

So that it can be shared by both ept, npt and shadow code, instead of duplicating it.

No change in functionality intended.

---
Cc: George Dunlap <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Jun Nakajima <[email protected]>
Cc: Kevin Tian <[email protected]>
Cc: Paul Durrant <[email protected]>
---
Changes since v1:
- Remove unused p2mt_old from p2m_pt_set_entry.

---
 xen/arch/x86/mm/hap/hap.c       |  3 ++
 xen/arch/x86/mm/p2m-ept.c       | 55 +++++++++++----------------------
 xen/arch/x86/mm/p2m-pt.c        | 24 --------------
 xen/arch/x86/mm/shadow/common.c |  3 ++
 xen/include/asm-x86/p2m.h       | 32 +++++++++++++++++++
 5 files changed, 56 insertions(+), 61 deletions(-)
xen/arch/x86/mm/hap/hap.c +3 -0
index 3d651b94c3..dc46d5e14f 100644
@@ -734,6 +734,9 @@ hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p,
             && perms_strictly_increased(old_flags, l1e_get_flags(new)) );
     }
 
+    p2m_entry_modify(p2m_get_hostp2m(d), p2m_flags_to_type(l1e_get_flags(new)),
+                     p2m_flags_to_type(old_flags), level);
+
     safe_write_pte(p, new);
     if ( old_flags & _PAGE_PRESENT )
         flush_tlb_mask(d->dirty_cpumask);
xen/arch/x86/mm/p2m-ept.c +18 -37

146 lines not on this page · raw message

xen/arch/x86/mm/p2m-pt.c +0 -24
index 52eaa24b18..04e9d81cf6 100644
@@ -436,13 +436,6 @@ static int do_recalc(struct p2m_domain *p2m, unsigned long gfn)
                 flags |= _PAGE_PSE;
             }
 
-            if ( ot == p2m_ioreq_server )
-            {
-                ASSERT(p2m->ioreq.entry_count > 0);
-                ASSERT(level == 0);
-                p2m->ioreq.entry_count--;
-            }
-
             e = l1e_from_pfn(mfn, flags);
             p2m_add_iommu_flags(&e, level,
                                 (nt == p2m_ram_rw)
@@ -616,8 +609,6 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
 
     if ( page_order == PAGE_ORDER_4K )
     {
-        p2m_type_t p2mt_old;
-
         rc = p2m_next_level(p2m, &table, &gfn_remainder, gfn,
                             L2_PAGETABLE_SHIFT - PAGE_SHIFT,
                             L2_PAGETABLE_ENTRIES, 1, 1);
@@ -641,21 +632,6 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
         if ( entry_content.l1 != 0 )
             p2m_add_iommu_flags(&entry_content, 0, iommu_pte_flags);
 
-        p2mt_old = p2m_flags_to_type(l1e_get_flags(*p2m_entry));
-
-        /*
-         * p2m_ioreq_server is only used for 4K pages, so
-         * the count is only done for level 1 entries.
-         */
-        if ( p2mt == p2m_ioreq_server )
-            p2m->ioreq.entry_count++;
-
-        if ( p2mt_old == p2m_ioreq_server )
-        {
-            ASSERT(p2m->ioreq.entry_count > 0);
-            p2m->ioreq.entry_count--;
-        }
-
         /* level 1 entry */
         p2m->write_p2m_entry(p2m, gfn, p2m_entry, entry_content, 1);
         /* NB: paging_write_p2m_entry() handles tlb flushes properly */
xen/arch/x86/mm/shadow/common.c +3 -0
index 07840ff727..0576c3c2d2 100644
@@ -3188,6 +3188,9 @@ shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
     if ( likely(d->arch.paging.shadow.total_pages != 0) )
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
+    p2m_entry_modify(p2m_get_hostp2m(d), p2m_flags_to_type(l1e_get_flags(new)),
+                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+
     /* Update the entry with new content */
     safe_write_pte(p, new);
 
xen/include/asm-x86/p2m.h +32 -0
index 2095076556..834d49d2d4 100644
@@ -932,6 +932,38 @@ int p2m_set_ioreq_server(struct domain *d, unsigned int flags,
 struct hvm_ioreq_server *p2m_get_ioreq_server(struct domain *d,
                                               unsigned int *flags);
 
+static inline void p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,
+                                    p2m_type_t ot, unsigned int level)
+{
+    if ( level != 1 || nt == ot )
+        return;
+
+    switch ( nt )
+    {
+    case p2m_ioreq_server:
+        /*
+         * p2m_ioreq_server is only used for 4K pages, so
+         * the count is only done for level 1 entries.
+         */
+        p2m->ioreq.entry_count++;
+        break;
+
+    default:
+        break;
+    }
+
+    switch ( ot )
+    {
+    case p2m_ioreq_server:
+        ASSERT(p2m->ioreq.entry_count > 0);
+        p2m->ioreq.entry_count--;
+        break;
+
+    default:
+        break;
+    }
+}
+
 #endif /* _XEN_ASM_X86_P2M_H */
 
 /*
Signature · 7 lines
2.17.2 (Apple Git-113)


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v4 1/4
#2 lore raw

Re: [PATCH v4 1/4] x86/mm: split p2m ioreq server pages special handling into helper

Quoted 11 lines

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

So that it can be shared by both ept, npt and shadow code, instead of duplicating it.

No change in functionality intended.

small comment:

xen/include/asm-x86/p2m.h int p2m_set_ioreq_server(struct domain *d, unsigned int flags, · line 939

Quoted 6 lines

+static inline void p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,

xen/include/asm-x86/p2m.h +4 -0
+                                    p2m_type_t ot, unsigned int level)
+{
+    if ( level != 1 || nt == ot )
+        return;

based on type check, does it make more sense to call it p2m_entry_modify_type?

Thanks
Kevin
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw

Re: [PATCH v4 1/4] x86/mm: split p2m ioreq server pages special handling into helper

Quoted 15 lines · Kevin
Quoted 11 lines

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

So that it can be shared by both ept, npt and shadow code, instead of duplicating it.

No change in functionality intended.

small comment:

Quoted 9 lines

xen/include/asm-x86/p2m.h int p2m_set_ioreq_server(struct domain *d, unsigned int flags, · line 939

Quoted 6 lines

+static inline void p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,

xen/include/asm-x86/p2m.h +4 -0
+                                    p2m_type_t ot, unsigned int level)
+{
+    if ( level != 1 || nt == ot )
+        return;

based on type check, does it make more sense to call it p2m_entry_modify_type?

Later on the function will be expanded to also take a new/old mfn pair of parameters, so I think the name is fine taking into account the expansion of the function later in the patch series.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw

Re: [PATCH v4 1/4] x86/mm: split p2m ioreq server pages special handling into helper

In reply to Roger Pau Monne

xen/arch/x86/mm/shadow/common.c shadow_write_p2m_entry(struct domain *d, unsigned long gfn, · line 3195

Quoted 12 lines
Quoted 1 line
Quoted 1 line · On 18.02.19 at 18:27, <[email protected]> wrote:
xen/arch/x86/mm/shadow/common.c +3 -0
@@ -3188,6 +3188,9 @@ shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
     if ( likely(d->arch.paging.shadow.total_pages != 0) )
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
+    p2m_entry_modify(p2m_get_hostp2m(d), p2m_flags_to_type(l1e_get_flags(new)),
+                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+
     /* Update the entry with new content */
     safe_write_pte(p, new);

Strictly speaking you should Cc Tim for this change.

Also at this example (a possible issue elsewhere as well) - is acting on the host P2M (only) really the right thing to do here?

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw

Re: [PATCH v4 1/4] x86/mm: split p2m ioreq server pages special handling into helper

Quoted 7 lines · Jan Beulich
Quoted 7 lines
Quoted 1 line
Quoted 1 line · On 18.02.19 at 18:27, <[email protected]> wrote:
xen/arch/x86/mm/shadow/common.c +0 -0
@@ -3188,6 +3188,9 @@ shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
     if ( likely(d->arch.paging.shadow.total_pages != 0) )
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
Quoted 7 lines

xen/arch/x86/mm/shadow/common.c shadow_write_p2m_entry(struct domain *d, unsigned long gfn, · line 3195

Quoted 5 lines
xen/arch/x86/mm/shadow/common.c +3 -0
+    p2m_entry_modify(p2m_get_hostp2m(d), p2m_flags_to_type(l1e_get_flags(new)),
+                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+
     /* Update the entry with new content */
     safe_write_pte(p, new);

Strictly speaking you should Cc Tim for this change.

sorry, I guess I didn't rerun get_maintainer after changing the patch.

Quoted 2 lines

Also at this example (a possible issue elsewhere as well) - is acting on the host P2M (only) really the right thing to do here?

I've wondered the same while working on this, what's even worse is that paging_write_p2m_entry takes a p2m as it's first argument, but then the write_p2m_entry expect a domain instead of a p2m.

I have the following patch that pushes the p2m up to the write_p2m_entry handlers, thus removing the need to do a p2m_get_hostp2m in the write_p2m_entry handlers.

I'm planning to add this as a pre-patch to my series.

Thanks, Roger.
---8<---

xen/arch/x86/mm/hap/hap.c +2 -1
index 3d651b94c3..28fe48d158 100644
@@ -709,9 +709,10 @@ static void hap_update_paging_modes(struct vcpu *v)
 }
 
 static void
-hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p,
+hap_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn, l1_pgentry_t *p,
                     l1_pgentry_t new, unsigned int level)
 {
+    struct domain *d = p2m->domain;
     uint32_t old_flags;
     bool_t flush_nestedp2m = 0;
 
xen/arch/x86/mm/paging.c +1 -1
index d5836eb688..e6ed3006fe 100644
@@ -941,7 +941,7 @@ void paging_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
     if ( v->domain != d )
         v = d->vcpu ? d->vcpu[0] : NULL;
     if ( likely(v && paging_mode_enabled(d) && paging_get_hostmode(v) != NULL) )
-        paging_get_hostmode(v)->write_p2m_entry(d, gfn, p, new, level);
+        paging_get_hostmode(v)->write_p2m_entry(p2m, gfn, p, new, level);
     else
         safe_write_pte(p, new);
 }
xen/arch/x86/mm/shadow/common.c +3 -1
index 07840ff727..6c67ef4996 100644
@@ -3177,10 +3177,12 @@ static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
 }
 
 void
-shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
+shadow_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
                        l1_pgentry_t *p, l1_pgentry_t new,
                        unsigned int level)
 {
+    struct domain *d = p2m->domain;
+
     paging_lock(d);
 
     /* If there are any shadows, update them.  But if shadow_teardown()
xen/arch/x86/mm/shadow/none.c +1 -1
index 4de645a433..316002771d 100644
@@ -60,7 +60,7 @@ static void _update_paging_modes(struct vcpu *v)
     ASSERT_UNREACHABLE();
 }
 
-static void _write_p2m_entry(struct domain *d, unsigned long gfn,
+static void _write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
                              l1_pgentry_t *p, l1_pgentry_t new,
                              unsigned int level)
 {
xen/arch/x86/mm/shadow/private.h +1 -1
index e8ed7ac714..0aaed1edfc 100644
@@ -372,7 +372,7 @@ extern int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn,
                                   unsigned long fault_addr);
 
 /* Functions that atomically write PT/P2M entries and update state */
-void shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
+void shadow_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
                             l1_pgentry_t *p, l1_pgentry_t new,
                             unsigned int level);
 
xen/include/asm-x86/paging.h +2 -1
index fdcc22844b..7ec09d7b11 100644
@@ -124,7 +124,8 @@ struct paging_mode {
     void          (*update_cr3            )(struct vcpu *v, int do_locking,
                                             bool noflush);
     void          (*update_paging_modes   )(struct vcpu *v);
-    void          (*write_p2m_entry       )(struct domain *d, unsigned long gfn,
+    void          (*write_p2m_entry       )(struct p2m_domain *p2m,
+                                            unsigned long gfn,
                                             l1_pgentry_t *p, l1_pgentry_t new,
                                             unsigned int level);
 

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw

PATCH v4 2/4 p2m: change write_p2m_entry to return an error code

In reply to Roger Pau Monne

This is in preparation for also changing p2m_entry_modify to return an error code.

No functional change intended.

---
Cc: George Dunlap <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Tim Deegan <[email protected]>
---
Changes since v3:
- Use asserts instead of bugs to check return code from write_p2m_entry from callers that don't support or expect write_p2m_entry to fail.

Changes since v2:
- New in this version.

---
 xen/arch/x86/mm/hap/hap.c        |  4 ++-
 xen/arch/x86/mm/hap/nested_hap.c |  4 ++-
 xen/arch/x86/mm/p2m-pt.c         | 57 +++++++++++++++++++++++++-------
 xen/arch/x86/mm/paging.c         | 12 ++++---
 xen/arch/x86/mm/shadow/common.c  |  4 ++-
 xen/arch/x86/mm/shadow/none.c    |  7 ++--
 xen/arch/x86/mm/shadow/private.h |  6 ++--
 xen/include/asm-x86/p2m.h        |  4 +--
 xen/include/asm-x86/paging.h     |  8 ++---
 9 files changed, 75 insertions(+), 31 deletions(-)
xen/arch/x86/mm/hap/hap.c +3 -1
index dc46d5e14f..5b507376bc 100644
@@ -708,7 +708,7 @@ static void hap_update_paging_modes(struct vcpu *v)
     put_gfn(d, cr3_gfn);
 }
 
-static void
+static int
 hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p,
                     l1_pgentry_t new, unsigned int level)
 {
@@ -745,6 +745,8 @@ hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p,
 
     if ( flush_nestedp2m )
         p2m_flush_nestedp2m(d);
+
+    return 0;
 }
 
 static unsigned long hap_gva_to_gfn_real_mode(
xen/arch/x86/mm/hap/nested_hap.c +3 -1
index d2a07a5c79..abe5958a52 100644
@@ -71,7 +71,7 @@
 /*        NESTED VIRT P2M FUNCTIONS         */
 /********************************************/
 
-void
+int
 nestedp2m_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
     l1_pgentry_t *p, l1_pgentry_t new, unsigned int level)
 {
@@ -87,6 +87,8 @@ nestedp2m_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
         flush_tlb_mask(p2m->dirty_cpumask);
 
     paging_unlock(d);
+
+    return 0;
 }
 
 /********************************************/
xen/arch/x86/mm/p2m-pt.c +45 -12

132 lines not on this page · raw message

xen/arch/x86/mm/paging.c +8 -4
index d5836eb688..6d46aa967b 100644
@@ -932,18 +932,22 @@ void paging_update_nestedmode(struct vcpu *v)
 }
 #endif
 
-void paging_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
-                            l1_pgentry_t *p, l1_pgentry_t new,
-                            unsigned int level)
+int paging_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
+                           l1_pgentry_t *p, l1_pgentry_t new,
+                           unsigned int level)
 {
     struct domain *d = p2m->domain;
     struct vcpu *v = current;
+    int rc = 0;
+
     if ( v->domain != d )
         v = d->vcpu ? d->vcpu[0] : NULL;
     if ( likely(v && paging_mode_enabled(d) && paging_get_hostmode(v) != NULL) )
-        paging_get_hostmode(v)->write_p2m_entry(d, gfn, p, new, level);
+        rc = paging_get_hostmode(v)->write_p2m_entry(d, gfn, p, new, level);
     else
         safe_write_pte(p, new);
+
+    return rc;
 }
 
 int paging_set_allocation(struct domain *d, unsigned int pages, bool *preempted)
xen/arch/x86/mm/shadow/common.c +3 -1
index 0576c3c2d2..fe48c4a02b 100644
@@ -3176,7 +3176,7 @@ static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
     }
 }
 
-void
+int
 shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
                        l1_pgentry_t *p, l1_pgentry_t new,
                        unsigned int level)
@@ -3209,6 +3209,8 @@ shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
 #endif
 
     paging_unlock(d);
+
+    return 0;
 }
 
 /**************************************************************************/
xen/arch/x86/mm/shadow/none.c +4 -3
index 4de645a433..6344d755ab 100644
@@ -60,11 +60,12 @@ static void _update_paging_modes(struct vcpu *v)
     ASSERT_UNREACHABLE();
 }
 
-static void _write_p2m_entry(struct domain *d, unsigned long gfn,
-                             l1_pgentry_t *p, l1_pgentry_t new,
-                             unsigned int level)
+static int _write_p2m_entry(struct domain *d, unsigned long gfn,
+                            l1_pgentry_t *p, l1_pgentry_t new,
+                            unsigned int level)
 {
     ASSERT_UNREACHABLE();
+    return -ENOSYS;
 }
 
 static const struct paging_mode sh_paging_none = {
xen/arch/x86/mm/shadow/private.h +3 -3
index e8ed7ac714..e331771d3e 100644
@@ -372,9 +372,9 @@ extern int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn,
                                   unsigned long fault_addr);
 
 /* Functions that atomically write PT/P2M entries and update state */
-void shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
-                            l1_pgentry_t *p, l1_pgentry_t new,
-                            unsigned int level);
+int shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
+                           l1_pgentry_t *p, l1_pgentry_t new,
+                           unsigned int level);
 
 /* Update all the things that are derived from the guest's CR0/CR3/CR4.
  * Called to initialize paging structures if the paging mode
xen/include/asm-x86/p2m.h +2 -2
index 834d49d2d4..f4ec2becbd 100644
@@ -265,7 +265,7 @@ struct p2m_domain {
                                                   unsigned long last_gfn);
     void               (*memory_type_changed)(struct p2m_domain *p2m);
     
-    void               (*write_p2m_entry)(struct p2m_domain *p2m,
+    int                (*write_p2m_entry)(struct p2m_domain *p2m,
                                           unsigned long gfn, l1_pgentry_t *p,
                                           l1_pgentry_t new, unsigned int level);
     long               (*audit_p2m)(struct p2m_domain *p2m);
@@ -837,7 +837,7 @@ void p2m_flush_nestedp2m(struct domain *d);
 /* Flushes the np2m specified by np2m_base (if it exists) */
 void np2m_flush_base(struct vcpu *v, unsigned long np2m_base);
 
-void nestedp2m_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
+int nestedp2m_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
     l1_pgentry_t *p, l1_pgentry_t new, unsigned int level);
 
 /*
xen/include/asm-x86/paging.h +4 -4
index fdcc22844b..81031bb79b 100644
@@ -124,7 +124,7 @@ struct paging_mode {
     void          (*update_cr3            )(struct vcpu *v, int do_locking,
                                             bool noflush);
     void          (*update_paging_modes   )(struct vcpu *v);
-    void          (*write_p2m_entry       )(struct domain *d, unsigned long gfn,
+    int           (*write_p2m_entry       )(struct domain *d, unsigned long gfn,
                                             l1_pgentry_t *p, l1_pgentry_t new,
                                             unsigned int level);
 
@@ -339,9 +339,9 @@ static inline void safe_write_pte(l1_pgentry_t *p, l1_pgentry_t new)
  * we are writing. */
 struct p2m_domain;
 
-void paging_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
-                            l1_pgentry_t *p, l1_pgentry_t new,
-                            unsigned int level);
+int paging_write_p2m_entry(struct p2m_domain *p2m, unsigned long gfn,
+                           l1_pgentry_t *p, l1_pgentry_t new,
+                           unsigned int level);
 
 /*
  * Called from the guest to indicate that the a process is being
Signature · 7 lines
2.17.2 (Apple Git-113)


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#7 lore raw

Re: [PATCH v4 2/4] p2m: change write_p2m_entry to return an error code

Quoted 46 lines
Quoted 1 line
Quoted 1 line · On 18.02.19 at 18:27, <[email protected]> wrote:
xen/arch/x86/mm/p2m-pt.c +16 -3
@@ -184,6 +184,7 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
     l1_pgentry_t *p2m_entry, new_entry;
     void *next;
     unsigned int flags;
+    int rc;
 
     if ( !(p2m_entry = p2m_find_entry(*table, gfn_remainder, gfn,
                                       shift, max)) )
@@ -202,7 +203,13 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
         new_entry = l1e_from_mfn(mfn, P2M_BASE_FLAGS | _PAGE_RW);
 
         p2m_add_iommu_flags(&new_entry, level, IOMMUF_readable|IOMMUF_writable);
-        p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        rc = p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        if ( rc )
+        {
+            ASSERT_UNREACHABLE();
+            p2m_free_ptp(p2m, mfn_to_page(mfn));
+            return rc;
+        }
     }
     else if ( flags & _PAGE_PSE )
     {
@@ -250,14 +257,27 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
         {
             new_entry = l1e_from_pfn(pfn | (i << ((level - 1) * PAGETABLE_ORDER)),
                                      flags);
-            p2m->write_p2m_entry(p2m, gfn, l1_entry + i, new_entry, level);
+            rc = p2m->write_p2m_entry(p2m, gfn, l1_entry + i, new_entry, level);
+            if ( rc )
+            {
+                ASSERT_UNREACHABLE();
+                unmap_domain_page(l1_entry);
+                p2m_free_ptp(p2m, mfn_to_page(mfn));
+                return rc;
+            }
         }
 
         unmap_domain_page(l1_entry);
 
         new_entry = l1e_from_mfn(mfn, P2M_BASE_FLAGS | _PAGE_RW);
         p2m_add_iommu_flags(&new_entry, level, IOMMUF_readable|IOMMUF_writable);
-        p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);

xen/arch/x86/mm/p2m-pt.c p2m_next_level(struct p2m_domain *p2m, void **table, · line 283

Quoted 10 lines
xen/arch/x86/mm/p2m-pt.c +7 -0
+        rc = p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        if ( rc )
+        {
+            ASSERT_UNREACHABLE();
+            p2m_free_ptp(p2m, mfn_to_page(mfn));
+            return rc;
+        }
     }
     else
         ASSERT(flags & _PAGE_PRESENT);

Personally I would find it quite desirable if there was just one instance of this error handling you add, which doesn't look overly difficult to arrange for.

xen/arch/x86/mm/p2m-pt.c static int p2m_pt_set_recalc_range(struct p2m_domain *p2m, · line 348

Quoted 10 lines
xen/arch/x86/mm/p2m-pt.c +2 -1
@@ -321,7 +341,8 @@ static int p2m_pt_set_recalc_range(struct p2m_domain *p2m,
             if ( (l1e_get_flags(e) & _PAGE_PRESENT) && !needs_recalc(l1, e) )
             {
                 set_recalc(l1, e);
-                p2m->write_p2m_entry(p2m, first_gfn, pent, e, level);
+                err = p2m->write_p2m_entry(p2m, first_gfn, pent, e, level);
+                ASSERT(!err);
             }
             first_gfn += 1UL << (i * PAGETABLE_ORDER);
         }

So on a release build what result the caller would observe in case there is an (unexpected) error depends on whether this occurs on the last iteration. I don't consider this very helpful behavior in terms of debuggability. (Along these lines also again further down).

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#8 lore raw

Re: [PATCH v4 2/4] p2m: change write_p2m_entry to return an error code

Quoted 52 lines · Jan Beulich
Quoted 52 lines
Quoted 1 line
Quoted 1 line · On 18.02.19 at 18:27, <[email protected]> wrote:
xen/arch/x86/mm/p2m-pt.c +22 -3
@@ -184,6 +184,7 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
     l1_pgentry_t *p2m_entry, new_entry;
     void *next;
     unsigned int flags;
+    int rc;
 
     if ( !(p2m_entry = p2m_find_entry(*table, gfn_remainder, gfn,
                                       shift, max)) )
@@ -202,7 +203,13 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
         new_entry = l1e_from_mfn(mfn, P2M_BASE_FLAGS | _PAGE_RW);
 
         p2m_add_iommu_flags(&new_entry, level, IOMMUF_readable|IOMMUF_writable);
-        p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        rc = p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        if ( rc )
+        {
+            ASSERT_UNREACHABLE();
+            p2m_free_ptp(p2m, mfn_to_page(mfn));
+            return rc;
+        }
     }
     else if ( flags & _PAGE_PSE )
     {
@@ -250,14 +257,27 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
         {
             new_entry = l1e_from_pfn(pfn | (i << ((level - 1) * PAGETABLE_ORDER)),
                                      flags);
-            p2m->write_p2m_entry(p2m, gfn, l1_entry + i, new_entry, level);
+            rc = p2m->write_p2m_entry(p2m, gfn, l1_entry + i, new_entry, level);
+            if ( rc )
+            {
+                ASSERT_UNREACHABLE();
+                unmap_domain_page(l1_entry);
+                p2m_free_ptp(p2m, mfn_to_page(mfn));
+                return rc;
+            }
         }
 
         unmap_domain_page(l1_entry);
 
         new_entry = l1e_from_mfn(mfn, P2M_BASE_FLAGS | _PAGE_RW);
         p2m_add_iommu_flags(&new_entry, level, IOMMUF_readable|IOMMUF_writable);
-        p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        rc = p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        if ( rc )
+        {
+            ASSERT_UNREACHABLE();
+            p2m_free_ptp(p2m, mfn_to_page(mfn));
+            return rc;
Quoted 8 lines

xen/arch/x86/mm/p2m-pt.c p2m_next_level(struct p2m_domain *p2m, void **table, · line 283

Quoted 4 lines
xen/arch/x86/mm/p2m-pt.c +1 -0
+        }
     }
     else
         ASSERT(flags & _PAGE_PRESENT);

Personally I would find it quite desirable if there was just one instance of this error handling you add, which doesn't look overly difficult to arrange for.

Sure. Would you be fine with me adding a label?

Quoted 7 lines
Quoted 7 lines
xen/arch/x86/mm/p2m-pt.c +2 -1
@@ -321,7 +341,8 @@ static int p2m_pt_set_recalc_range(struct p2m_domain *p2m,
             if ( (l1e_get_flags(e) & _PAGE_PRESENT) && !needs_recalc(l1, e) )
             {
                 set_recalc(l1, e);
-                p2m->write_p2m_entry(p2m, first_gfn, pent, e, level);
+                err = p2m->write_p2m_entry(p2m, first_gfn, pent, e, level);
+                ASSERT(!err);
Quoted 8 lines

xen/arch/x86/mm/p2m-pt.c static int p2m_pt_set_recalc_range(struct p2m_domain *p2m, · line 348

Quoted 3 lines
xen/arch/x86/mm/p2m-pt.c +0 -0
             }
             first_gfn += 1UL << (i * PAGETABLE_ORDER);
         }

So on a release build what result the caller would observe in case there is an (unexpected) error depends on whether this occurs on the last iteration. I don't consider this very helpful behavior in terms of debuggability. (Along these lines also again further down).

Done, thanks for spotting those.

Roger.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#9 lore raw

Re: [PATCH v4 2/4] p2m: change write_p2m_entry to return an error code

Quoted 63 lines
Quoted 1 line
Quoted 1 line · On 19.02.19 at 12:56, <[email protected]> wrote:
Quoted 9 lines · Jan Beulich
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 18.02.19 at 18:27, <[email protected]> wrote:
xen/arch/x86/mm/p2m-pt.c +1 -0
@@ -184,6 +184,7 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
     l1_pgentry_t *p2m_entry, new_entry;
     void *next;
     unsigned int flags;
+    int rc;
 
Quoted 6 lines

xen/arch/x86/mm/p2m-pt.c p2m_next_level(struct p2m_domain *p2m, void **table, · line 205

Quoted 6 lines
xen/arch/x86/mm/p2m-pt.c +0 -0
     if ( !(p2m_entry = p2m_find_entry(*table, gfn_remainder, gfn,
                                       shift, max)) )
@@ -202,7 +203,13 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
         new_entry = l1e_from_mfn(mfn, P2M_BASE_FLAGS | _PAGE_RW);
 
         p2m_add_iommu_flags(&new_entry, level, 

IOMMUF_readable|IOMMUF_writable);

Quoted 2 lines

xen/arch/x86/mm/p2m-pt.c p2m_next_level(struct p2m_domain *p2m, void **table, · line 206

Quoted 2 lines
xen/arch/x86/mm/p2m-pt.c +1 -1
-        p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        rc = p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 

1);

Quoted 4 lines
Quoted 4 lines
xen/arch/x86/mm/p2m-pt.c +4 -0
+        if ( rc )
+        {
+            ASSERT_UNREACHABLE();
+            p2m_free_ptp(p2m, mfn_to_page(mfn));
Quoted 8 lines

xen/arch/x86/mm/p2m-pt.c p2m_next_level(struct p2m_domain *p2m, void **table, · line 258

Quoted 8 lines
xen/arch/x86/mm/p2m-pt.c +2 -0
+            return rc;
+        }
     }
     else if ( flags & _PAGE_PSE )
     {
@@ -250,14 +257,27 @@ p2m_next_level(struct p2m_domain *p2m, void **table,
         {
             new_entry = l1e_from_pfn(pfn | (i << ((level - 1) * 

PAGETABLE_ORDER)),

Quoted 3 lines

xen/arch/x86/mm/p2m-pt.c p2m_next_level(struct p2m_domain *p2m, void **table,

Quoted 3 lines
xen/arch/x86/mm/p2m-pt.c +1 -1
                                      flags);
-            p2m->write_p2m_entry(p2m, gfn, l1_entry + i, new_entry, level);
+            rc = p2m->write_p2m_entry(p2m, gfn, l1_entry + i, new_entry, 

level);

Quoted 25 lines
Quoted 24 lines
xen/arch/x86/mm/p2m-pt.c +14 -1
+            if ( rc )
+            {
+                ASSERT_UNREACHABLE();
+                unmap_domain_page(l1_entry);
+                p2m_free_ptp(p2m, mfn_to_page(mfn));
+                return rc;
+            }
         }
 
         unmap_domain_page(l1_entry);
 
         new_entry = l1e_from_mfn(mfn, P2M_BASE_FLAGS | _PAGE_RW);
         p2m_add_iommu_flags(&new_entry, level, IOMMUF_readable|IOMMUF_writable);
-        p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        rc = p2m->write_p2m_entry(p2m, gfn, p2m_entry, new_entry, level + 1);
+        if ( rc )
+        {
+            ASSERT_UNREACHABLE();
+            p2m_free_ptp(p2m, mfn_to_page(mfn));
+            return rc;
+        }
     }
     else
         ASSERT(flags & _PAGE_PRESENT);
Quoted 5 lines
Quoted 3 lines

Personally I would find it quite desirable if there was just one instance of this error handling you add, which doesn't look overly difficult to arrange for.

Sure. Would you be fine with me adding a label?

Personally (again) I'd prefer if you got away without, which (as said before) doesn't look overly difficult to arrange for.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#10 lore raw

PATCH v4 3/4 x86/mm: handle foreign mappings in p2m_entry_modify

In reply to Roger Pau Monne

So that the specific handling can be removed from atomic_write_ept_entry and be shared with npt and shadow code.

This commit also removes the check that prevent non-ept PVH dom0 from mapping foreign pages.

---
Cc: George Dunlap <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Jun Nakajima <[email protected]>
Cc: Kevin Tian <[email protected]>
Cc: Tim Deegan <[email protected]>
---
Changes since v3:
- Replace the mfn_valid BUG_ONs with an assert & return.

Changes since v2:
- Return an error code from p2m_entry_modify and propagate it to the callers.

Changes since v1:
- Simply code since mfn_to_page cannot return NULL.
- Check if the mfn is valid before getting/dropping the page reference.
- Use BUG_ON instead of ASSERTs, since getting the reference counting wrong is more dangerous than a DoS.

---
 xen/arch/x86/mm/hap/hap.c       | 12 +++++--
 xen/arch/x86/mm/p2m-ept.c       | 56 +++------------------------------
 xen/arch/x86/mm/p2m-pt.c        |  7 -----
 xen/arch/x86/mm/shadow/common.c |  3 +-
 xen/include/asm-x86/p2m.h       | 34 +++++++++++++++++---
 5 files changed, 47 insertions(+), 65 deletions(-)
xen/arch/x86/mm/hap/hap.c +10 -2
index 5b507376bc..2daf8424f6 100644
@@ -714,6 +714,7 @@ hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p,
 {
     uint32_t old_flags;
     bool_t flush_nestedp2m = 0;
+    int rc;
 
     /* We know always use the host p2m here, regardless if the vcpu
      * is in host or guest mode. The vcpu can be in guest mode by
@@ -734,8 +735,15 @@ hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p,
             && perms_strictly_increased(old_flags, l1e_get_flags(new)) );
     }
 
-    p2m_entry_modify(p2m_get_hostp2m(d), p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(old_flags), level);
+    rc = p2m_entry_modify(p2m_get_hostp2m(d),
+                          p2m_flags_to_type(l1e_get_flags(new)),
+                          p2m_flags_to_type(old_flags), l1e_get_mfn(new),
+                          l1e_get_mfn(*p), level);
+    if ( rc )
+    {
+        paging_unlock(d);
+        return rc;
+    }
 
     safe_write_pte(p, new);
     if ( old_flags & _PAGE_PRESENT )
xen/arch/x86/mm/p2m-ept.c +5 -51

70 lines not on this page · raw message

xen/arch/x86/mm/p2m-pt.c +0 -7
index 3a8dc04efc..57afa37c71 100644
@@ -564,13 +564,6 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
         __trace_var(TRC_MEM_SET_P2M_ENTRY, 0, sizeof(t), &t);
     }
 
-    if ( unlikely(p2m_is_foreign(p2mt)) )
-    {
-        /* hvm fixme: foreign types are only supported on ept at present */
-        gdprintk(XENLOG_WARNING, "Unimplemented foreign p2m type.\n");
-        return -EINVAL;
-    }
-
     /* Carry out any eventually pending earlier changes first. */
     rc = do_recalc(p2m, gfn);
     if ( rc < 0 )
xen/arch/x86/mm/shadow/common.c +2 -1
index fe48c4a02b..ad670de515 100644
@@ -3189,7 +3189,8 @@ shadow_write_p2m_entry(struct domain *d, unsigned long gfn,
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
     p2m_entry_modify(p2m_get_hostp2m(d), p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+                     p2m_flags_to_type(l1e_get_flags(*p)), l1e_get_mfn(new),
+                     l1e_get_mfn(*p), level);
 
     /* Update the entry with new content */
     safe_write_pte(p, new);
xen/include/asm-x86/p2m.h +30 -4
index f4ec2becbd..2801a8ccca 100644
@@ -932,11 +932,14 @@ int p2m_set_ioreq_server(struct domain *d, unsigned int flags,
 struct hvm_ioreq_server *p2m_get_ioreq_server(struct domain *d,
                                               unsigned int *flags);
 
-static inline void p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,
-                                    p2m_type_t ot, unsigned int level)
+static inline int p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,
+                                   p2m_type_t ot, mfn_t nfn, mfn_t ofn,
+                                   unsigned int level)
 {
-    if ( level != 1 || nt == ot )
-        return;
+    BUG_ON(level > 1 && (nt == p2m_ioreq_server || nt == p2m_map_foreign));
+
+    if ( level != 1 || (nt == ot && mfn_eq(nfn, ofn)) )
+        return 0;
 
     switch ( nt )
     {
@@ -948,6 +951,18 @@ static inline void p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,
         p2m->ioreq.entry_count++;
         break;
 
+    case p2m_map_foreign:
+        if ( !mfn_valid(nfn) )
+        {
+            ASSERT_UNREACHABLE();
+            return -EINVAL;
+        }
+
+        if ( !page_get_owner_and_reference(mfn_to_page(nfn)) )
+            return -EBUSY;
+
+        break;
+
     default:
         break;
     }
@@ -959,9 +974,20 @@ static inline void p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t nt,
         p2m->ioreq.entry_count--;
         break;
 
+    case p2m_map_foreign:
+        if ( !mfn_valid(ofn) )
+        {
+            ASSERT_UNREACHABLE();
+            return -EINVAL;
+        }
+        put_page(mfn_to_page(ofn));
+        break;
+
     default:
         break;
     }
+
+    return 0;
 }
 
 #endif /* _XEN_ASM_X86_P2M_H */
Signature · 7 lines
2.17.2 (Apple Git-113)


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#11 lore raw

Re: [PATCH v4 3/4] x86/mm: handle foreign mappings in p2m_entry_modify

Quoted 8 lines

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

So that the specific handling can be removed from atomic_write_ept_entry and be shared with npt and shadow code.

This commit also removes the check that prevent non-ept PVH dom0 from mapping foreign pages.

ah, so please ignore my comment to [1/4]. p2m_entry_modify is used more than type change now. :-)

Quoted 46 lines

---
Cc: George Dunlap <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Jun Nakajima <[email protected]>
Cc: Kevin Tian <[email protected]>
Cc: Tim Deegan <[email protected]>
---
Changes since v3:
- Replace the mfn_valid BUG_ONs with an assert & return.

Changes since v2:
- Return an error code from p2m_entry_modify and propagate it to the callers.

Changes since v1:
- Simply code since mfn_to_page cannot return NULL.
- Check if the mfn is valid before getting/dropping the page reference.
- Use BUG_ON instead of ASSERTs, since getting the reference counting wrong is more dangerous than a DoS.

---
 xen/arch/x86/mm/hap/hap.c       | 12 +++++--
 xen/arch/x86/mm/p2m-ept.c       | 56 +++------------------------------
 xen/arch/x86/mm/p2m-pt.c        |  7 -----
 xen/arch/x86/mm/shadow/common.c |  3 +-
 xen/include/asm-x86/p2m.h       | 34 +++++++++++++++++---
 5 files changed, 47 insertions(+), 65 deletions(-)
xen/arch/x86/mm/hap/hap.c +1 -0
index 5b507376bc..2daf8424f6 100644
@@ -714,6 +714,7 @@ hap_write_p2m_entry(struct domain *d, unsigned
 long gfn, l1_pgentry_t *p,
 {
     uint32_t old_flags;
     bool_t flush_nestedp2m = 0;
+    int rc;
 
     /* We know always use the host p2m here, regardless if the vcpu

* is in host or guest mode. The vcpu can be in guest mode by

xen/arch/x86/mm/hap/hap.c +0 -0
@@ -734,8 +735,15 @@ hap_write_p2m_entry(struct domain *d, unsigned
 long gfn, l1_pgentry_t *p,

xen/arch/x86/mm/hap/hap.c hap_write_p2m_entry(struct domain *d, unsigned · line 743

Quoted 10 lines
xen/arch/x86/mm/hap/hap.c +4 -2
             && perms_strictly_increased(old_flags, l1e_get_flags(new)) );
     }
 
-    p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(old_flags), level);
+    rc = p2m_entry_modify(p2m_get_hostp2m(d),
+                          p2m_flags_to_type(l1e_get_flags(new)),
+                          p2m_flags_to_type(old_flags), l1e_get_mfn(new),
+                          l1e_get_mfn(*p), level);

why not passing old/new pte to reduce #parameters and thus stable against future changes?

Quoted 142 lines
xen/arch/x86/mm/hap/hap.c +5 -0
+    if ( rc )
+    {
+        paging_unlock(d);
+        return rc;
+    }
 

safe_write_pte(p, new);
if ( old_flags & _PAGE_PRESENT )

xen/arch/x86/mm/p2m-ept.c +5 -51
index 0ece6608cb..83bd602fc4 100644
@@ -45,65 +45,19 @@ static inline bool_t is_epte_valid(ept_entry_t *e)
     return ((e->epte & ~(1ul << 63)) != 0 && e->sa_p2mt != p2m_invalid);
 }
 
-/* returns : 0 for success, -errno otherwise */
 static int atomic_write_ept_entry(struct p2m_domain *p2m,
                                   ept_entry_t *entryptr, ept_entry_t new,
                                   int level)
 {
-    int rc;
-    unsigned long oldmfn = mfn_x(INVALID_MFN);
-    bool_t check_foreign = (new.mfn != entryptr->mfn ||
-                            new.sa_p2mt != entryptr->sa_p2mt);
-
-    if ( level )
-    {
-        ASSERT(!is_epte_superpage(&new)
 || !p2m_is_foreign(new.sa_p2mt));
-        write_atomic(&entryptr->epte, new.epte);
-        return 0;
-    }
-
-    if ( unlikely(p2m_is_foreign(new.sa_p2mt)) )
-    {
-        rc = -EINVAL;
-        if ( !is_epte_present(&new) )
-                goto out;
-
-        if ( check_foreign )
-        {
-            struct domain *fdom;
-
-            if ( !mfn_valid(_mfn(new.mfn)) )
-                goto out;
-
-            rc = -ESRCH;
-            fdom = page_get_owner(mfn_to_page(_mfn(new.mfn)));
-            if ( fdom == NULL )
-                goto out;
+    int rc = p2m_entry_modify(p2m, new.sa_p2mt, entryptr->sa_p2mt,
+                              _mfn(new.mfn), _mfn(entryptr->mfn), level);
 
-            /* get refcount on the page */
-            rc = -EBUSY;
-            if ( !get_page(mfn_to_page(_mfn(new.mfn)), fdom) )
-                goto out;
-        }
-    }
-
-    if ( unlikely(p2m_is_foreign(entryptr->sa_p2mt)) && check_foreign )
-        oldmfn = entryptr->mfn;
-
-    p2m_entry_modify(p2m, new.sa_p2mt, entryptr->sa_p2mt, level);
+    if ( rc )
+        return rc;
 
     write_atomic(&entryptr->epte, new.epte);
 
-    if ( unlikely(oldmfn != mfn_x(INVALID_MFN)) )
-        put_page(mfn_to_page(_mfn(oldmfn)));
-
-    rc = 0;
-
- out:
-    if ( rc )
-        gdprintk(XENLOG_ERR, "epte o:%"PRIx64" n:%"PRIx64" rc:%d\n",
-                 entryptr->epte, new.epte, rc);
-    return rc;
+    return 0;
 }
 

static void ept_p2m_type_to_flags(struct p2m_domain *p2m, ept_entry_t
*entry,

xen/arch/x86/mm/p2m-pt.c +0 -7
index 3a8dc04efc..57afa37c71 100644
@@ -564,13 +564,6 @@ p2m_pt_set_entry(struct p2m_domain *p2m,
 gfn_t gfn_, mfn_t mfn,
         __trace_var(TRC_MEM_SET_P2M_ENTRY, 0, sizeof(t), &t);
     }
 
-    if ( unlikely(p2m_is_foreign(p2mt)) )
-    {
-        /* hvm fixme: foreign types are only supported on ept at present */
-        gdprintk(XENLOG_WARNING, "Unimplemented foreign p2m type.\n");
-        return -EINVAL;
-    }
-
     /* Carry out any eventually pending earlier changes first. */
     rc = do_recalc(p2m, gfn);
     if ( rc < 0 )
xen/arch/x86/mm/shadow/common.c +2 -1
index fe48c4a02b..ad670de515 100644
@@ -3189,7 +3189,8 @@ shadow_write_p2m_entry(struct domain *d,
 unsigned long gfn,
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
     p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+                     p2m_flags_to_type(l1e_get_flags(*p)), l1e_get_mfn(new),
+                     l1e_get_mfn(*p), level);
 
     /* Update the entry with new content */
     safe_write_pte(p, new);
xen/include/asm-x86/p2m.h +4 -4
index f4ec2becbd..2801a8ccca 100644
@@ -932,11 +932,14 @@ int p2m_set_ioreq_server(struct domain *d,
 unsigned int flags,
 struct hvm_ioreq_server *p2m_get_ioreq_server(struct domain *d,
                                               unsigned int *flags);
 
-static inline void p2m_entry_modify(struct p2m_domain *p2m,
 p2m_type_t nt,
-                                    p2m_type_t ot, unsigned int level)
+static inline int p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t
 nt,
+                                   p2m_type_t ot, mfn_t nfn, mfn_t ofn,
+                                   unsigned int level)
 {
-    if ( level != 1 || nt == ot )
-        return;
+    BUG_ON(level > 1 && (nt == p2m_ioreq_server || nt ==

p2m_map_foreign));

xen/include/asm-x86/p2m.h int p2m_set_ioreq_server(struct domain *d, unsigned int flags, · line 942

Quoted 3 lines
xen/include/asm-x86/p2m.h +3 -0
+
+    if ( level != 1 || (nt == ot && mfn_eq(nfn, ofn)) )
+        return 0;

could also return here in case of nt==ot==p2m_ioreq_server, otherwise p2m->ioreq.entry_count might be unnecessarily inc/dec if mfn changes while type stays as p2m_ioreq_server...

Quoted 44 lines

switch ( nt )
{

xen/include/asm-x86/p2m.h +12 -0
@@ -948,6 +951,18 @@ static inline void p2m_entry_modify(struct
 p2m_domain *p2m, p2m_type_t nt,
         p2m->ioreq.entry_count++;
         break;
 
+    case p2m_map_foreign:
+        if ( !mfn_valid(nfn) )
+        {
+            ASSERT_UNREACHABLE();
+            return -EINVAL;
+        }
+
+        if ( !page_get_owner_and_reference(mfn_to_page(nfn)) )
+            return -EBUSY;
+
+        break;
+
     default:
         break;
     }
xen/include/asm-x86/p2m.h +11 -0
@@ -959,9 +974,20 @@ static inline void p2m_entry_modify(struct
 p2m_domain *p2m, p2m_type_t nt,
         p2m->ioreq.entry_count--;
         break;
 
+    case p2m_map_foreign:
+        if ( !mfn_valid(ofn) )
+        {
+            ASSERT_UNREACHABLE();
+            return -EINVAL;
+        }
+        put_page(mfn_to_page(ofn));
+        break;
+
     default:
         break;
     }
+
+    return 0;
 }
 
Quoted 3 lines

#endif /* _XEN_ASM_X86_P2M_H */
--
2.17.2 (Apple Git-113)

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#12 lore raw

Re: [PATCH v4 3/4] x86/mm: handle foreign mappings in p2m_entry_modify

Quoted 9 lines
Quoted 9 lines
Quoted 1 line · On 19.02.19 at 07:14, <[email protected]> wrote:

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

xen/arch/x86/mm/hap/hap.c +0 -0
@@ -734,8 +735,15 @@ hap_write_p2m_entry(struct domain *d, unsigned
 long gfn, l1_pgentry_t *p,
             && perms_strictly_increased(old_flags, l1e_get_flags(new)) );
     }
 
Quoted 10 lines

xen/arch/x86/mm/hap/hap.c hap_write_p2m_entry(struct domain *d, unsigned long gfn, l1_pgentry_t *p, · line 741

Quoted 7 lines
xen/arch/x86/mm/hap/hap.c +4 -2
-    p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(old_flags), level);
+    rc = p2m_entry_modify(p2m_get_hostp2m(d),
+                          p2m_flags_to_type(l1e_get_flags(new)),
+                          p2m_flags_to_type(old_flags), l1e_get_mfn(new),
+                          l1e_get_mfn(*p), level);

why not passing old/new pte to reduce #parameters and thus stable against future changes?

The PTE layout is different between EPT and shadow/NPT, yet the function here is generic. It's not impossible to do what you suggest, but it would require field extraction abstraction functions, which I don't think is worth it.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#13 lore raw

Re: [PATCH v4 3/4] x86/mm: handle foreign mappings in p2m_entry_modify

In reply to Tian, Kevin
Quoted 213 lines · Kevin
Quoted 8 lines

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

So that the specific handling can be removed from atomic_write_ept_entry and be shared with npt and shadow code.

This commit also removes the check that prevent non-ept PVH dom0 from mapping foreign pages.

ah, so please ignore my comment to [1/4]. p2m_entry_modify is used more than type change now. :-)

Quoted 46 lines

---
Cc: George Dunlap <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Jun Nakajima <[email protected]>
Cc: Kevin Tian <[email protected]>
Cc: Tim Deegan <[email protected]>
---
Changes since v3:
- Replace the mfn_valid BUG_ONs with an assert & return.

Changes since v2:
- Return an error code from p2m_entry_modify and propagate it to the callers.

Changes since v1:
- Simply code since mfn_to_page cannot return NULL.
- Check if the mfn is valid before getting/dropping the page reference.
- Use BUG_ON instead of ASSERTs, since getting the reference counting wrong is more dangerous than a DoS.

---
 xen/arch/x86/mm/hap/hap.c       | 12 +++++--
 xen/arch/x86/mm/p2m-ept.c       | 56 +++------------------------------
 xen/arch/x86/mm/p2m-pt.c        |  7 -----
 xen/arch/x86/mm/shadow/common.c |  3 +-
 xen/include/asm-x86/p2m.h       | 34 +++++++++++++++++---
 5 files changed, 47 insertions(+), 65 deletions(-)
xen/arch/x86/mm/hap/hap.c +1 -0
index 5b507376bc..2daf8424f6 100644
@@ -714,6 +714,7 @@ hap_write_p2m_entry(struct domain *d, unsigned
 long gfn, l1_pgentry_t *p,
 {
     uint32_t old_flags;
     bool_t flush_nestedp2m = 0;
+    int rc;
 
     /* We know always use the host p2m here, regardless if the vcpu

* is in host or guest mode. The vcpu can be in guest mode by

xen/arch/x86/mm/hap/hap.c +0 -0
@@ -734,8 +735,15 @@ hap_write_p2m_entry(struct domain *d, unsigned
 long gfn, l1_pgentry_t *p,

xen/arch/x86/mm/hap/hap.c hap_write_p2m_entry(struct domain *d, unsigned · line 743

Quoted 10 lines
xen/arch/x86/mm/hap/hap.c +4 -2
             && perms_strictly_increased(old_flags, l1e_get_flags(new)) );
     }
 
-    p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(old_flags), level);
+    rc = p2m_entry_modify(p2m_get_hostp2m(d),
+                          p2m_flags_to_type(l1e_get_flags(new)),
+                          p2m_flags_to_type(old_flags), l1e_get_mfn(new),
+                          l1e_get_mfn(*p), level);

why not passing old/new pte to reduce #parameters and thus stable against future changes?

Quoted 141 lines
xen/arch/x86/mm/hap/hap.c +5 -0
+    if ( rc )
+    {
+        paging_unlock(d);
+        return rc;
+    }
 

safe_write_pte(p, new);
if ( old_flags & _PAGE_PRESENT )

xen/arch/x86/mm/p2m-ept.c +5 -51
index 0ece6608cb..83bd602fc4 100644
@@ -45,65 +45,19 @@ static inline bool_t is_epte_valid(ept_entry_t *e)
     return ((e->epte & ~(1ul << 63)) != 0 && e->sa_p2mt != p2m_invalid);
 }
 
-/* returns : 0 for success, -errno otherwise */
 static int atomic_write_ept_entry(struct p2m_domain *p2m,
                                   ept_entry_t *entryptr, ept_entry_t new,
                                   int level)
 {
-    int rc;
-    unsigned long oldmfn = mfn_x(INVALID_MFN);
-    bool_t check_foreign = (new.mfn != entryptr->mfn ||
-                            new.sa_p2mt != entryptr->sa_p2mt);
-
-    if ( level )
-    {
-        ASSERT(!is_epte_superpage(&new)
 || !p2m_is_foreign(new.sa_p2mt));
-        write_atomic(&entryptr->epte, new.epte);
-        return 0;
-    }
-
-    if ( unlikely(p2m_is_foreign(new.sa_p2mt)) )
-    {
-        rc = -EINVAL;
-        if ( !is_epte_present(&new) )
-                goto out;
-
-        if ( check_foreign )
-        {
-            struct domain *fdom;
-
-            if ( !mfn_valid(_mfn(new.mfn)) )
-                goto out;
-
-            rc = -ESRCH;
-            fdom = page_get_owner(mfn_to_page(_mfn(new.mfn)));
-            if ( fdom == NULL )
-                goto out;
+    int rc = p2m_entry_modify(p2m, new.sa_p2mt, entryptr->sa_p2mt,
+                              _mfn(new.mfn), _mfn(entryptr->mfn), level);
 
-            /* get refcount on the page */
-            rc = -EBUSY;
-            if ( !get_page(mfn_to_page(_mfn(new.mfn)), fdom) )
-                goto out;
-        }
-    }
-
-    if ( unlikely(p2m_is_foreign(entryptr->sa_p2mt)) && check_foreign )
-        oldmfn = entryptr->mfn;
-
-    p2m_entry_modify(p2m, new.sa_p2mt, entryptr->sa_p2mt, level);
+    if ( rc )
+        return rc;
 
     write_atomic(&entryptr->epte, new.epte);
 
-    if ( unlikely(oldmfn != mfn_x(INVALID_MFN)) )
-        put_page(mfn_to_page(_mfn(oldmfn)));
-
-    rc = 0;
-
- out:
-    if ( rc )
-        gdprintk(XENLOG_ERR, "epte o:%"PRIx64" n:%"PRIx64" rc:%d\n",
-                 entryptr->epte, new.epte, rc);
-    return rc;
+    return 0;
 }
 

static void ept_p2m_type_to_flags(struct p2m_domain *p2m, ept_entry_t
*entry,

xen/arch/x86/mm/p2m-pt.c +0 -7
index 3a8dc04efc..57afa37c71 100644
@@ -564,13 +564,6 @@ p2m_pt_set_entry(struct p2m_domain *p2m,
 gfn_t gfn_, mfn_t mfn,
         __trace_var(TRC_MEM_SET_P2M_ENTRY, 0, sizeof(t), &t);
     }
 
-    if ( unlikely(p2m_is_foreign(p2mt)) )
-    {
-        /* hvm fixme: foreign types are only supported on ept at present */
-        gdprintk(XENLOG_WARNING, "Unimplemented foreign p2m type.\n");
-        return -EINVAL;
-    }
-
     /* Carry out any eventually pending earlier changes first. */
     rc = do_recalc(p2m, gfn);
     if ( rc < 0 )
xen/arch/x86/mm/shadow/common.c +2 -1
index fe48c4a02b..ad670de515 100644
@@ -3189,7 +3189,8 @@ shadow_write_p2m_entry(struct domain *d,
 unsigned long gfn,
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
     p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+                     p2m_flags_to_type(l1e_get_flags(*p)), l1e_get_mfn(new),
+                     l1e_get_mfn(*p), level);
 
     /* Update the entry with new content */
     safe_write_pte(p, new);
xen/include/asm-x86/p2m.h +4 -4
index f4ec2becbd..2801a8ccca 100644
@@ -932,11 +932,14 @@ int p2m_set_ioreq_server(struct domain *d,
 unsigned int flags,
 struct hvm_ioreq_server *p2m_get_ioreq_server(struct domain *d,
                                               unsigned int *flags);
 
-static inline void p2m_entry_modify(struct p2m_domain *p2m,
 p2m_type_t nt,
-                                    p2m_type_t ot, unsigned int level)
+static inline int p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t
 nt,
+                                   p2m_type_t ot, mfn_t nfn, mfn_t ofn,
+                                   unsigned int level)
 {
-    if ( level != 1 || nt == ot )
-        return;
+    BUG_ON(level > 1 && (nt == p2m_ioreq_server || nt ==
Quoted 8 lines

xen/include/asm-x86/p2m.h int p2m_set_ioreq_server(struct domain *d, unsigned int flags, · line 942

Quoted 4 lines

p2m_map_foreign));

xen/include/asm-x86/p2m.h +3 -0
+
+    if ( level != 1 || (nt == ot && mfn_eq(nfn, ofn)) )
+        return 0;

could also return here in case of nt==ot==p2m_ioreq_server, otherwise p2m->ioreq.entry_count might be unnecessarily inc/dec if mfn changes while type stays as p2m_ioreq_server...

That's an interesting idea. But it would have you do an extra check for all operations, rather than doing an extra increment / decrement in a very unusual corner case. Probably faster just to let the uncommon case be a tiny bit slower.

-George

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#14 lore raw

Re: [PATCH v4 3/4] x86/mm: handle foreign mappings in p2m_entry_modify

In reply to Tian, Kevin
Quoted 39 lines · Kevin
Quoted 39 lines

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

xen/arch/x86/mm/shadow/common.c +2 -1
index fe48c4a02b..ad670de515 100644
@@ -3189,7 +3189,8 @@ shadow_write_p2m_entry(struct domain *d,
 unsigned long gfn,
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
     p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+                     p2m_flags_to_type(l1e_get_flags(*p)), l1e_get_mfn(new),
+                     l1e_get_mfn(*p), level);
 
     /* Update the entry with new content */
     safe_write_pte(p, new);
xen/include/asm-x86/p2m.h +4 -4
index f4ec2becbd..2801a8ccca 100644
@@ -932,11 +932,14 @@ int p2m_set_ioreq_server(struct domain *d,
 unsigned int flags,
 struct hvm_ioreq_server *p2m_get_ioreq_server(struct domain *d,
                                               unsigned int *flags);
 
-static inline void p2m_entry_modify(struct p2m_domain *p2m,
 p2m_type_t nt,
-                                    p2m_type_t ot, unsigned int level)
+static inline int p2m_entry_modify(struct p2m_domain *p2m, p2m_type_t
 nt,
+                                   p2m_type_t ot, mfn_t nfn, mfn_t ofn,
+                                   unsigned int level)
 {
-    if ( level != 1 || nt == ot )
-        return;
+    BUG_ON(level > 1 && (nt == p2m_ioreq_server || nt ==
Quoted 8 lines

xen/include/asm-x86/p2m.h int p2m_set_ioreq_server(struct domain *d, unsigned int flags, · line 942

Quoted 4 lines

p2m_map_foreign));

xen/include/asm-x86/p2m.h +3 -0
+
+    if ( level != 1 || (nt == ot && mfn_eq(nfn, ofn)) )
+        return 0;

could also return here in case of nt==ot==p2m_ioreq_server, otherwise p2m->ioreq.entry_count might be unnecessarily inc/dec if mfn changes while type stays as p2m_ioreq_server...

The original code that open-coded the handling of p2m_ioreq_server didn't have this optimization, and as said by George I'm not sure the extra check is going to be worth it. I expect changing the mfn of an entry with type p2m_ioreq_server is not something very common.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#15 lore raw

Re: [PATCH v4 3/4] x86/mm: handle foreign mappings in p2m_entry_modify

Quoted 49 lines

From: Roger Pau Monné [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 10:01 PM

Quoted 28 lines · Kevin
Quoted 28 lines

From: Roger Pau Monne [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:27 AM

xen/arch/x86/mm/shadow/common.c +2 -1
index fe48c4a02b..ad670de515 100644
@@ -3189,7 +3189,8 @@ shadow_write_p2m_entry(struct domain *d,
 unsigned long gfn,
          sh_unshadow_for_p2m_change(d, gfn, p, new, level);
 
     p2m_entry_modify(p2m_get_hostp2m(d),
 p2m_flags_to_type(l1e_get_flags(new)),
-                     p2m_flags_to_type(l1e_get_flags(*p)), level);
+                     p2m_flags_to_type(l1e_get_flags(*p)), l1e_get_mfn(new),
+                     l1e_get_mfn(*p), level);
 
     /* Update the entry with new content */
     safe_write_pte(p, new);
xen/include/asm-x86/p2m.h +0 -0
index f4ec2becbd..2801a8ccca 100644
@@ -932,11 +932,14 @@ int p2m_set_ioreq_server(struct domain *d,
 unsigned int flags,
 struct hvm_ioreq_server *p2m_get_ioreq_server(struct domain *d,
                                               unsigned int *flags);
 
Quoted 4 lines

xen/include/asm-x86/p2m.h int p2m_set_ioreq_server(struct domain *d, · line 937

Quoted 4 lines
xen/include/asm-x86/p2m.h +1 -2
-static inline void p2m_entry_modify(struct p2m_domain *p2m,
 p2m_type_t nt,
-                                    p2m_type_t ot, unsigned int level)
+static inline int p2m_entry_modify(struct p2m_domain *p2m,

p2m_type_t

Quoted 12 lines
Quoted 11 lines
xen/include/asm-x86/p2m.h +3 -2
 nt,
+                                   p2m_type_t ot, mfn_t nfn, mfn_t ofn,
+                                   unsigned int level)
 {
-    if ( level != 1 || nt == ot )
-        return;
+    BUG_ON(level > 1 && (nt == p2m_ioreq_server || nt ==

p2m_map_foreign));

xen/include/asm-x86/p2m.h +3 -0
+
+    if ( level != 1 || (nt == ot && mfn_eq(nfn, ofn)) )
+        return 0;
Quoted 9 lines
Quoted 3 lines

could also return here in case of nt==ot==p2m_ioreq_server, otherwise p2m->ioreq.entry_count might be unnecessarily inc/dec if mfn changes while type stays as p2m_ioreq_server...

The original code that open-coded the handling of p2m_ioreq_server didn't have this optimization, and as said by George I'm not sure the extra check is going to be worth it. I expect changing the mfn of an entry with type p2m_ioreq_server is not something very common.

OK. Reviewed-by: Kevin Tian <[email protected]>

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#16 lore raw

PATCH v4 4/4 npt/shadow: allow getting foreign page table entries

In reply to Roger Pau Monne

Current npt and shadow code to get an entry will always return INVALID_MFN for foreign entries. Allow to return the entry mfn for foreign entries, like it's done for grant table entries.

---
Cc: George Dunlap <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
Cc: Wei Liu <[email protected]>
---
Changes since v2:
- Use p2m_is_any_ram.

---
 xen/arch/x86/mm/p2m-pt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
xen/arch/x86/mm/p2m-pt.c +2 -2
index 57afa37c71..17969643b8 100644
@@ -893,8 +893,8 @@ pod_retry_l1:
     *t = p2m_recalc_type(recalc || _needs_recalc(flags), l1t, p2m, gfn);
     unmap_domain_page(l1e);
 
-    ASSERT(mfn_valid(mfn) || !p2m_is_ram(*t) || p2m_is_paging(*t));
-    return (p2m_is_valid(*t) || p2m_is_grant(*t)) ? mfn : INVALID_MFN;
+    ASSERT(mfn_valid(mfn) || !p2m_is_any_ram(*t) || p2m_is_paging(*t));
+    return (p2m_is_valid(*t) || p2m_is_any_ram(*t)) ? mfn : INVALID_MFN;
 }
 
 static void p2m_pt_change_entry_type_global(struct p2m_domain *p2m,
Signature · 7 lines
2.17.2 (Apple Git-113)


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v4 4/4
#17 lore raw

Re: [PATCH v4 4/4] npt/shadow: allow getting foreign page table entries

Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 18.02.19 at 18:27, <[email protected]> wrote:

Current npt and shadow code to get an entry will always return INVALID_MFN for foreign entries. Allow to return the entry mfn for foreign entries, like it's done for grant table entries.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel