Skip to contentSkip to conversation

net: hns: Fixes the missing put_device in positive leg for roce reset

PATCH Applied Salil Mehta 2 participants 2 messages Feb 18, 2019 – Feb 19, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: hns: Fixes the missing put_device in positive leg for roce reset

This patch fixes the missing device reference release-after-use in the positive leg of the roce reset API of the HNS DSAF.

Fixes c969c6e7ab8c ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()")
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +3 -0
index b8155f5..ac55db0 100644
@@ -3128,6 +3128,9 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
 		dsaf_set_bit(credit, DSAF_SBM_ROCEE_CFG_CRD_EN_B, 1);
 		dsaf_write_dev(dsaf_dev, DSAF_SBM_ROCEE_CFG_REG_REG, credit);
 	}
+
+	put_device(&pdev->dev);
+
 	return 0;
 }
 EXPORT_SYMBOL(hns_dsaf_roce_reset);
Signature · 1 line
2.7.4