pwm: hibvt: Use individual struct per of-data.
Subsystems (2)
PATCH v2 1/3 pwm: hibvt: Use individual struct per of-data.
Split pwm-soc array in one struct per soc and point to the corresponding on in of-data.
--- drivers/pwm/pwm-hibvt.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/pwm/pwm-hibvt.c +12 -5
@@ -49,15 +49,19 @@ struct hibvt_pwm_chip {struct clk *clk;void __iomem *base;struct reset_control *rstc; +const struct hibvt_pwm_soc *soc; };struct hibvt_pwm_soc {u32 num_pwms; }; -static const struct hibvt_pwm_soc pwm_soc[2 ] = { - { .num_pwms =4 }, - { .num_pwms =8 }, +static const struct hibvt_pwm_soc hi3516cv300_soc_info = { + .num_pwms =4 , +}; + +static const struct hibvt_pwm_soc hi3519v100_soc_info = { + .num_pwms =8 , };static inline struct hibvt_pwm_chip *to_hibvt_pwm_chip (struct pwm_chip *chip)
@@ -198,6 +202,7 @@ static int hibvt_pwm_probe(struct platform_device *pdev) pwm_chip->chip.npwm = soc->num_pwms; pwm_chip->chip.of_xlate = of_pwm_xlate_with_flags; pwm_chip->chip.of_pwm_n_cells =3 ; + pwm_chip->soc = soc; res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); pwm_chip->base =devm_ioremap_resource (&pdev->dev, res);
@@ -250,8 +255,10 @@ static int hibvt_pwm_remove(struct platform_device *pdev) }static const struct of_device_id hibvt_pwm_of_match[] = { - { .compatible ="hisilicon,hi3516cv300-pwm" , .data = &pwm_soc[0 ] }, - { .compatible ="hisilicon,hi3519v100-pwm" , .data = &pwm_soc[1 ] }, + { .compatible ="hisilicon,hi3516cv300-pwm" , + .data = &hi3516cv300_soc_info }, + { .compatible ="hisilicon,hi3519v100-pwm" , + .data = &hi3519v100_soc_info }, { } };MODULE_DEVICE_TABLE (of, hibvt_pwm_of_match);
Signature · 1 line
2.17.1
PATCH v2 2/3 dt-bindings: pwm: hibvt: Add hi3559v100 support
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm platforms.
--- Documentation/devicetree/bindings/pwm/pwm-hibvt.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/pwm/pwm-hibvt.txt +2 -0
@@ -5,6 +5,8 @@ Required properties: The SoC specific strings supported including: "hisilicon,hi3516cv300-pwm" "hisilicon,hi3519v100-pwm" + "hisilicon,hi3559v100-shub-pwm" + "hisilicon,hi3559v100-pwm - reg: physical base address and length of the controller's registers. - clocks: phandle and clock specifier of the PWM reference clock. - resets: phandle and reset specifier for the PWM controller reset.
Signature · 1 line
2.17.1
Re: [PATCH v2 2/3] dt-bindings: pwm: hibvt: Add hi3559v100 support
Quoted 8 lines · Mathieu Othacehe
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm platforms.
Signed-off-by Mathieu Othacehe <[email protected]>--- Documentation/devicetree/bindings/pwm/pwm-hibvt.txt | 2 ++ 1 file changed, 2 insertions(+)
PATCH v2 3/3 pwm: hibvt: Add hi3559v100 support
In reply to Mathieu OthaceheAdd support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm platforms. They require a special quirk: pwm has to be enabled again to force duty_cycle refresh.
--- drivers/pwm/pwm-hibvt.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
drivers/pwm/pwm-hibvt.c +27 -1
@@ -54,6 +54,7 @@ struct hibvt_pwm_chip {struct hibvt_pwm_soc {u32 num_pwms; +bool quirk_force_enable; };static const struct hibvt_pwm_soc hi3516cv300_soc_info = {
@@ -64,6 +65,16 @@ static const struct hibvt_pwm_soc hi3519v100_soc_info = { .num_pwms = 8, }; +static const struct hibvt_pwm_soc hi3559v100_shub_soc_info = { + .num_pwms =8 , + .quirk_force_enable = true, +}; + +static const struct hibvt_pwm_soc hi3559v100_soc_info = { + .num_pwms =2 , + .quirk_force_enable = true, +}; +static inline struct hibvt_pwm_chip *to_hibvt_pwm_chip (struct pwm_chip *chip) { return container_of(chip, struct hibvt_pwm_chip, chip);
@@ -152,13 +163,24 @@ static void hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,static int hibvt_pwm_apply (struct pwm_chip *chip,struct pwm_device *pwm,struct pwm_state *state) { +struct hibvt_pwm_chip *hi_pwm_chip =to_hibvt_pwm_chip (chip); +if (state->polarity != pwm->state.polarity)hibvt_pwm_set_polarity (chip, pwm, state->polarity);if (state->period != pwm->state.period || - state->duty_cycle != pwm->state.duty_cycle) + state->duty_cycle != pwm->state.duty_cycle) {hibvt_pwm_config (chip, pwm, state->duty_cycle, state->period); +/* +* On those platforms, it is required to enable the +* pwm again each time we want to refresh the duty +* cycle. +*/ +if (hi_pwm_chip->soc->quirk_force_enable && state->enabled) +hibvt_pwm_enable (chip, pwm); + } +if (state->enabled != pwm->state.enabled) {if (state->enabled)hibvt_pwm_enable (chip, pwm);
@@ -259,6 +281,10 @@ static const struct of_device_id hibvt_pwm_of_match[] = { .data = &hi3516cv300_soc_info }, { .compatible = "hisilicon,hi3519v100-pwm", .data = &hi3519v100_soc_info }, + { .compatible = "hisilicon,hi3559v100-shub-pwm", + .data = &hi3559v100_shub_soc_info }, + { .compatible = "hisilicon,hi3559v100-pwm", + .data = &hi3559v100_soc_info }, { } };MODULE_DEVICE_TABLE (of, hibvt_pwm_of_match);
Signature · 1 line
2.17.1
Re: [PATCH v2 3/3] pwm: hibvt: Add hi3559v100 support
Quoted 41 lines · Mathieu Othacehe
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm platforms. They require a special quirk: pwm has to be enabled again to force
duty_cyclerefresh.Signed-off-by Mathieu Othacehe <[email protected]>--- drivers/pwm/pwm-hibvt.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)drivers/pwm/pwm-hibvt.c +11
-0@@ -54,6 +54,7 @@ struct hibvt_pwm_chip {struct hibvt_pwm_soc {u32 num_pwms; +bool quirk_force_enable; };static const struct hibvt_pwm_soc hi3516cv300_soc_info = {@@ -64,6 +65,16 @@ static const struct hibvt_pwm_soc hi3519v100_soc_info = { .num_pwms = 8, }; +static const struct hibvt_pwm_soc hi3559v100_shub_soc_info = { + .num_pwms =8 , + .quirk_force_enable = true, +}; + +static const struct hibvt_pwm_soc hi3559v100_soc_info = { + .num_pwms =2 , + .quirk_force_enable = true, +}; +static inline struct hibvt_pwm_chip *to_hibvt_pwm_chip (struct pwm_chip *chip) { return container_of(chip, struct hibvt_pwm_chip, chip);@@ -152,13 +163,24 @@ static void hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,static int hibvt_pwm_apply (struct pwm_chip *chip,struct pwm_device *pwm,struct pwm_state *state)
drivers/pwm/pwm-hibvt.c static void hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, · line 173
Quoted 10 lines
drivers/pwm/pwm-hibvt.c +3
-1{ +struct hibvt_pwm_chip *hi_pwm_chip =to_hibvt_pwm_chip (chip); +if (state->polarity != pwm->state.polarity)hibvt_pwm_set_polarity (chip, pwm, state->polarity);if (state->period != pwm->state.period || - state->duty_cycle != pwm->state.duty_cycle) + state->duty_cycle != pwm->state.duty_cycle) {hibvt_pwm_config (chip, pwm, state->duty_cycle, state->period);
I would prefer to have the continued line in the if condition aligned to the opening parenthesis. Then it is optically separated from the first expression in the body of the if.
drivers/pwm/pwm-hibvt.c static void hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, · line 176
Quoted 3 lines
drivers/pwm/pwm-hibvt.c +2
-0+/* +* On those platforms, it is required to enable the
Which platforms? I think in a previous round it was obvious what was meant here because there was a test against two specific compatibles. Now something like
Some implementations require the pwm to be enabled once more each time the duty cycle is refreshed.
would be more suitable.
Is there a publicly available reference manual available for the newly supported hardware?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Re: [PATCH v2 3/3] pwm: hibvt: Add hi3559v100 support
Hi Uwe,
Is there a publicly available reference manual available for the newly
Quoted 2 lines
supported hardware?
No sadly I don't think so :(
I'll send a v3 fixing both of your remarks.
Thanks,
Mathieu