Skip to contentSkip to conversation

package/stm32flash: bump to version 0.5

PATCH New Steinhilber 4 participants 5 messages Feb 18, 2019 – Feb 22, 2019 1 message not in the archive Arm STM32

lore
Share & tools
lore

Steinhilber

#0 lore raw

PATCH 1/1 package/stm32flash: bump to version 0.5

Bump to latest official version.

---
 package/stm32flash/stm32flash.hash | 2 ++
 package/stm32flash/stm32flash.mk   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)  create mode 100644 package/stm32flash/stm32flash.hash
package/stm32flash/stm32flash.hash new file +2 -0
new file mode 100644
index 0000000000..dc97c10972
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 73afcbd317ca3eb080c14b6ed1451e5a74a3bbae8f8fb5fe24ea496333f03ead

+stm32flash-1f934ae86babdeea47afdfae1d856d5fd5da6c53.tar.gz

package/stm32flash/stm32flash.mk +1 -1
index c41fc76d01..9bb05ab730 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-STM32FLASH_VERSION = 4ac0566f188f39eace0223d966d349cd2f2c5895
+STM32FLASH_VERSION = 1f934ae86babdeea47afdfae1d856d5fd5da6c53
 STM32FLASH_SITE = git://git.code.sf.net/p/stm32flash/code
 STM32FLASH_LICENSE = GPL-2.0+
 STM32FLASH_LICENSE_FILES = gpl-2.0.txt

--
2.11.0

________________________________

Erbe Elektromedizin GmbH Firmensitz: 72072 Tuebingen Geschaeftsfuehrer: Christian O. Erbe, Reiner Thede Registergericht: Stuttgart HRB 380137

#1 lore raw

PATCH 1/1 package/stm32flash: bump to version 0.5

Hello Markus,

Thanks for your contribution! I have applied your patch to our next branch, but I have a few comments, see below.

Quoted 3 lines · Markus

Bump to latest official version.

Your From: doesn't match your Signed-off-by: line. Your From is:

LastName, FirstName <email>

While your SoB is:

FirstName LastName <email>

We have some checks that verify that both are consistent, so I fixed up the author name of your commit. Indeed, we have a preference for the:

FirstName LastName <email>

formatting.

package/stm32flash/stm32flash.hash

Quoted 9 lines
package/stm32flash/stm32flash.hash new file +3 -0
new file mode 100644
index 0000000000..dc97c10972
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 73afcbd317ca3eb080c14b6ed1451e5a74a3bbae8f8fb5fe24ea496333f03ead
+stm32flash-1f934ae86babdeea47afdfae1d856d5fd5da6c53.tar.gz

This line was wrapped. I suspect you haven't sent this patch using "git send-email", and due to this, it was line-wrapped by your e-mail client. Using "git send-email" would avoid such issues.

A possible follow-up improvement to this package would be to add the hash of the gpl-2.0.txt license file to the .hash file.

Thanks again for your contribution!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

A message that is not in the archive (sent off-list or not yet received): 2748BB04F99E7E45A3203C831E8B20FE34D35C13@SERBE4I2.intra.erbe-med.de

#3 lore raw

[Buildroot] git send-email with Outlook / NTLM ?

Hello,

I've re-added the Buildroot mailing list in Cc, please keep the list Cc'ed for this discussion.

Quoted 7 lines · Markus

The mismatch and also the line wrapping was most likely happening because I needed to send the mail with Outlook. Our SMTP server only allows NTLM auth and I couldn't get git-email-send to work with it (The git-email-send-ntlm project is also not working for me). I don't think I can change the From: within outlook. But I could change the
Signed-off-by: to match it if this is better. If you know any way to use git-email-send with NTLM please let me know.

I am in the lucky situation that I don't have to use an Outlook e-mail server, so I have no idea if git send-email can work with NTLM. Perhaps other people in the list will know ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

[Buildroot] git send-email with Outlook / NTLM ?

Hello,

El mar., 19 feb. 2019 a las 10:15, Thomas Petazzoni (<[email protected]>) escribi?:

Quoted 17 lines

Hello,

I've re-added the Buildroot mailing list in Cc, please keep the list Cc'ed for this discussion.

Quoted 7 lines · Markus

The mismatch and also the line wrapping was most likely happening because I needed to send the mail with Outlook. Our SMTP server only allows NTLM auth and I couldn't get git-email-send to work with it (The git-email-send-ntlm project is also not working for me). I don't think I can change the From: within outlook. But I could change the
Signed-off-by: to match it if this is better. If you know any way to use git-email-send with NTLM please let me know.

Quoted 3 lines

I am in the lucky situation that I don't have to use an Outlook e-mail server, so I have no idea if git send-email can work with NTLM. Perhaps other people in the list will know ?

First question is: do you really need to use your company's SMTP server for sending to the Buildroot mailing list. You might be better off using e.g. gmail SMTP.

You probably have a proxy server that you need to route through, but it is not impossible.

Previously I used socat to set up a tunnel through the proxy, to gmail smtp.

remotehost=smtp.gmail.com
remoteport=587
localport=10587
proxy=your.proxy.com # or IP address
proxyport=8080
socat TCP4-LISTEN:$localport,reuseaddr,fork PROXY:$proxy:$remotehost:$remoteport,proxyport=$proxyport,resolve

In your gitconfig, you would then specify 'localhost' and port 10587 as smtp server.

For some reason, this no longer works for me, with error:
STARTTLS failed! hostname verification failed at /usr/libexec/git-core/git-send-email line 1503.

But git-send-email also allows to specify an external program to send email. For example, use '/usr/bin/msmtp' as 'smtpserver'. Additional options can be specified as 'smtpserveroption'.
In my case, I can also use a socks proxy. In .msmtprc I have:

account gmail
host smtp.gmail.com
port 587
tls on
tls_trust_file /etc/ssl/certs/ca-certificates.crt
logfile /home/user/msmtp.log
proxy_host your-socks-proxy
auth on
from user at gmail.com
user user at gmail.com
password your-app-password-for-gmail

and then in .gitconfig

[sendemail]
smtpserver = /usr/bin/msmtp
smtpserveroption = -agmail

If gmail is not an option, you might be able to configure msmtp to autenticate using NTLM to your company SMTP. The internet suggests that msmtp supports NTLM via GNU SASL, which in turn uses libntlm. See:
https://marlam.de/msmtp/
http://josefsson.org/libgsasl/

Best regards,
Thomas

#5 lore raw

PATCH 1/1 package/stm32flash: bump to version 0.5

In reply to Steinhilber
Quoted 23 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Steinhilber," == Steinhilber, Markus <[email protected]> writes:

Bump to latest official version.

---
 package/stm32flash/stm32flash.hash | 2 ++
 package/stm32flash/stm32flash.mk   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)  create mode 100644 package/stm32flash/stm32flash.hash
package/stm32flash/stm32flash.hash new file +3 -0
new file mode 100644
index 0000000000..dc97c10972
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 73afcbd317ca3eb080c14b6ed1451e5a74a3bbae8f8fb5fe24ea496333f03ead
+stm32flash-1f934ae86babdeea47afdfae1d856d5fd5da6c53.tar.gz
package/stm32flash/stm32flash.mk +0 -0
index c41fc76d01..9bb05ab730 100644

package/stm32flash/stm32flash.mk line 7

Quoted 5 lines
package/stm32flash/stm32flash.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-STM32FLASH_VERSION = 4ac0566f188f39eace0223d966d349cd2f2c5895
+STM32FLASH_VERSION = 1f934ae86babdeea47afdfae1d856d5fd5da6c53

If this is latest official version, why isn't this a git tag?

Looking at git, this corresponds to the v0.5 tag.

Signature · 1 line
Bye, Peter Korsgaard