regulator: da9062: Select maximum current in specific range for set_current_limit
PATCH 1/2 regulator: da9062: Select maximum current in specific range for set_current_limit
Selecting the minimal value is only true for voltage regulators. For current regulators the maximum in the given range should be selected instead.
--- drivers/regulator/da9062-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/da9062-regulator.c +1 -1
@@ -126,7 +126,7 @@ static int da9062_set_current_limit(struct regulator_dev *rdev,const struct da9062_regulator_info *rinfo = regl->info;int n, tval; -for (n =0 ; n < rinfo->n_current_limits; n++) { +for (n = rinfo->n_current_limits -1 ; n >=0 ; n--) { tval = rinfo->current_limits[n];if (tval >= min_ua && tval <= max_ua)return regmap_field_write (regl->ilimit, n);
Signature · 1 line
2.17.1
PATCH 2/2 regulator: da9063: Select maximum current in specific range for set_current_limit
Selecting the minimal value is only true for voltage regulators. For current regulators the maximum in the given range should be selected instead.
--- drivers/regulator/da9063-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/da9063-regulator.c +1 -1
@@ -167,7 +167,7 @@ static int da9063_set_current_limit(struct regulator_dev *rdev,const struct da9063_regulator_info *rinfo = regl->info;int n, tval; -for (n =0 ; n < rinfo->n_current_limits; n++) { +for (n = rinfo->n_current_limits -1 ; n >=0 ; n--) { tval = rinfo->current_limits[n];if (tval >= min_uA && tval <= max_uA)return regmap_field_write (regl->ilimit, n);
Signature · 1 line
2.17.1
RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit
Quoted 26 lines · Axel Lin
To: Mark Brown <[email protected]>
Subject: [PATCH 2/2] regulator: da9063: Select maximum current in specific range forset_current_limitSelecting the minimal value is only true for voltage regulators. For current regulators the maximum in the given range should be selected instead.
Signed-off-by Axel Lin <[email protected]>--- drivers/regulator/da9063-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/regulator/da9063- renamed from drivers/regulator/da9063-regulator.c +0
-0
regulator.c
index85c45577bad1..a83bbd3dbc37100644drivers/regulator/da9063-regulator.c +1
-1@@ -167,7 +167,7 @@ static int da9063_set_current_limit(struct regulator_dev *rdev, const struct da9063_regulator_info *rinfo = regl->info;int n, tval; -for (n =0 ; n < rinfo->n_current_limits; n++) { +for (n = rinfo->n_current_limits -1 ; n >=0 ; n--) { tval = rinfo->current_limits[n];if (tval >= min_uA && tval <= max_uA)
Quoted 1 line
return
regmap_field_write(regl->ilimit, n);
Hi Axel,
Quoted 26 lines · Axel Lin
To: Mark Brown <[email protected]>
Subject: [PATCH 1/2] regulator: da9062: Select maximum current in specific range forset_current_limitSelecting the minimal value is only true for voltage regulators. For current regulators the maximum in the given range should be selected instead.
Signed-off-by Axel Lin <[email protected]>--- drivers/regulator/da9062-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/regulator/da9062- renamed from drivers/regulator/da9062-regulator.c +0
-0
regulator.c
indexd06e9600fa18..4c5d6ad853f8100644drivers/regulator/da9062-regulator.c +1
-1@@ -126,7 +126,7 @@ static int da9062_set_current_limit(struct regulator_dev *rdev, const struct da9062_regulator_info *rinfo = regl->info;int n, tval; -for (n =0 ; n < rinfo->n_current_limits; n++) { +for (n = rinfo->n_current_limits -1 ; n >=0 ; n--) { tval = rinfo->current_limits[n];if (tval >= min_ua && tval <= max_ua)
Quoted 3 lines
return
regmap_field_write(regl->ilimit, n);
--
2.17.1
Thanks and regards,
Steve