Skip to contentSkip to conversation

runner: Exit with 0 on dry-run

PATCH Superseded Petri Latvala 3 participants 6 messages Feb 19, 2019

lore
Share & tools
lore

Petri Latvala

author
#0 lore raw

PATCH 1/1 runner: Exit with 0 on dry-run

Signed-off-by Petri Latvala <[email protected]>
Cc Arkadiusz Hiler <[email protected]>
Cc Tomi Sarvela <[email protected]>
---
 runner/executor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
runner/executor.c +1 -1
index 3f1eb010..d535c276 100644
@@ -1208,7 +1208,7 @@ bool execute(struct execute_state *state,
 
 	if (state->dry) {
 		printf("Dry run, not executing. Invoke igt_resume if you want to execute.\n");
-		return false;
+		return true;
 	}
 
 	if ((resdirfd = open(settings->results_path, O_DIRECTORY | O_RDONLY)) < 0) {
Signature · 6 lines
2.19.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
CI
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for runner: Exit with 0 on dry-run

== Series Details ==

== Series Details ==

Series: runner: Exit with 0 on dry-run
URL : https://patchwork.freedesktop.org/series/56887/
State : failure

== Summary ==

IGT patchset build failed on latest successful build 368e76156f752e6ed6ac32ed9f400567aef7d3fc runner: Exit with 2 when overall timeout exceeded

A file containing a list of tests to run
-o, --overwrite If the results-path already exists, delete it
--ignore-missing Ignored but accepted, for piglit compatibility

Incompatible options:
-m, --multiple-mode Run multiple subtests in the same binary execution.
If a testlist file is given, consecutive subtests are
run in the same execution if they are from the same
binary. Note that in that case relative ordering of the
subtest execution is dictated by the test binary, not
the testlist
--inactivity-timeout <seconds>
Kill the running test after <seconds> of inactivity in
the test's stdout, stderr, or dmesg
--overall-timeout <seconds>
Don't execute more tests after <seconds> has elapsed
--use-watchdog Use hardware watchdog for lethal enforcement of the
above timeout. Killing the test process is still
attempted at timeout trigger.
--piglit-style-dmesg Filter dmesg like piglit does. Piglit considers matches
against a short filter list to mean the test result
should be changed to dmesg-warn/dmesg-fail. Without
this option everything except matches against a
(longer) filter list means the test result should
change.
[test_root] Directory that contains the IGT tests. The environment
variable IGT_TEST_ROOT will be used if set, overriding
this option if given.
Cannot open /home/cidrm/igt-gpu-tools/build/tmpdirpd1NmP/test-list.txt
(runner_test:12145) CRITICAL: Test assertion failure function __real_main196, file ../runner/runner_tests.c:776:
(runner_test:12145) CRITICAL: Failed assertion: !execute(&state, &settings, &list) (runner_test:12145) CRITICAL: Last errno: 2, No such file or directory
Subtest dry-run-option failed.
**** DEBUG ****
(runner_test:12145) CRITICAL: Test assertion failure function __real_main196, file ../runner/runner_tests.c:776:
(runner_test:12145) CRITICAL: Failed assertion: !execute(&state, &settings, &list) (runner_test:12145) CRITICAL: Last errno: 2, No such file or directory
(runner_test:12145) igt_core-INFO: Stack trace:

(runner_test:12145) igt_core-INFO:   #0 ../lib/igt_core.c:1471 __igt_fail_assert()
(runner_test:12145) igt_core-INFO:   #1 ../runner/runner_tests.c:777 __real_main196()
(runner_test:12145) igt_core-INFO:   #2 ../runner/runner_tests.c:196 main()
(runner_test:12145) igt_core-INFO:   #3 ../csu/libc-start.c:344 __libc_start_main()
(runner_test:12145) igt_core-INFO:   #4 [_start+0x2a]

**** END ****
-------

Full log written to /home/cidrm/igt-gpu-tools/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/python3 -u /usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#2 lore raw

PATCH v2 1/1 runner: Exit with 0 on dry-run

In reply to Petri Latvala

v2: Adjust tests accordingly

Signed-off-by Petri Latvala <[email protected]>
Cc Arkadiusz Hiler <[email protected]>
Cc Tomi Sarvela <[email protected]>
---
 runner/executor.c     | 2 +-
 runner/runner_tests.c | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)
runner/executor.c +1 -1
index 3f1eb010..d535c276 100644
@@ -1208,7 +1208,7 @@ bool execute(struct execute_state *state,
 
 	if (state->dry) {
 		printf("Dry run, not executing. Invoke igt_resume if you want to execute.\n");
-		return false;
+		return true;
 	}
 
 	if ((resdirfd = open(settings->results_path, O_DIRECTORY | O_RDONLY)) < 0) {
runner/runner_tests.c +3 -2
index 0965612a..e46568ac 100644
@@ -773,8 +773,9 @@ igt_main
 				     "Dry run initialization didn't create the results directory.\n");
 
 			/* Execute from just initialize_execute_state should fail */
-			igt_assert(!execute(&state, &settings, &list));
-			igt_assert(openat(dirfd, "0", O_DIRECTORY | O_RDONLY) < 0);
+			igt_assert(execute(&state, &settings, &list));
+			igt_assert_f(openat(dirfd, "0", O_DIRECTORY | O_RDONLY) < 0,
+				     "Dry run executed when it should not have.\n");
 			igt_assert_f((fd = openat(dirfd, "metadata.txt", O_RDONLY)) >= 0,
 				     "Dry run initialization didn't serialize settings.\n");
 			close(fd);
Signature · 6 lines
2.19.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
CI
#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for runner: Exit with 0 on dry-run (rev2)

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: runner: Exit with 0 on dry-run (rev2)
URL : https://patchwork.freedesktop.org/series/56887/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5630 -> IGTPW_2444
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56887/revisions/2/mbox/

Known issues
------------

Here are the changes found in IGTPW_2444 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]

#### Possible fixes ####

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: INCOMPLETE [fdo#102657] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527

Participating hosts (44 -> 41)
------------------------------

Additional (1): fi-bdw-5557u
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan

Build changes
-------------

* IGT: IGT_4837 -> IGTPW_2444

CI_DRM_5630: 82d591391bfcd9cfe2eeac149c49a678b571cd62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2444: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2444/
IGT_4837: 368e76156f752e6ed6ac32ed9f400567aef7d3fc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2444/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

CI
#5 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for runner: Exit with 0 on dry-run (rev2)

In reply to Petri Latvala
== Series Details ==

== Series Details ==

Series: runner: Exit with 0 on dry-run (rev2)
URL : https://patchwork.freedesktop.org/series/56887/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5630_full -> IGTPW_2444_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2444_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2444_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56887/revisions/2/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2444_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_crc@cursor-64x21-random:
- shard-kbl: NOTRUN -> FAIL

Known issues
------------

Here are the changes found in IGTPW_2444_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mmap_gtt@forked-big-copy-xy:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]

* igt@kms_busy@basic-flip-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +2

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_color@pipe-b-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]

* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: PASS -> FAIL [fdo#103232] +1

* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: PASS -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: PASS -> FAIL [fdo#103355]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +3

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:

    - shard-apl:          NOTRUN -> FAIL [fdo#108145]
    - shard-glk:          PASS -> FAIL [fdo#108145]
    - shard-kbl:          NOTRUN -> FAIL [fdo#108145]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +6

* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: NOTRUN -> FAIL [fdo#109016]

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]

* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-kbl: PASS -> FAIL [fdo#103166] +1

* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-apl: NOTRUN -> FAIL [fdo#104894]

#### Possible fixes ####

* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS +1
- shard-glk: FAIL [fdo#108145] -> PASS

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-kbl: FAIL [fdo#107725] / [fdo#108145] -> PASS +1

* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS

* igt@kms_cursor_crc@cursor-64x21-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +5

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1

* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: FAIL [fdo#109350] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: FAIL [fdo#103167] -> PASS +5

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +5

* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
- shard-apl: FAIL [fdo#108948] -> PASS +1

* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS +1

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS

* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS

* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-glk: FAIL [fdo#103166] -> PASS +2

* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: {SKIP} [fdo#109271] -> PASS

* igt@pm_rps@waitboost:
- shard-apl: FAIL [fdo#102250] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4837 -> IGTPW_2444
* Piglit: piglit_4509 -> None

CI_DRM_5630: 82d591391bfcd9cfe2eeac149c49a678b571cd62 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2444: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2444/
IGT_4837: 368e76156f752e6ed6ac32ed9f400567aef7d3fc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2444/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev