Skip to contentSkip to conversation

orinoco : Replace function name in string with __func__

PATCH In review Keyur Patel 2 participants 2 messages Feb 17, 2019 – Feb 19, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 orinoco : Replace function name in string with __func__

From: Keyur Patel <[email protected]>

Replace hard coded function name with __func__, to improve robustness and to conform to the Linux kernel coding style. Issue found using checkpatch.

---
 drivers/net/wireless/intersil/orinoco/mic.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/intersil/orinoco/mic.c +5 -5
index 709d9ab3e7bc..67b0c05afbdb 100644
@@ -18,16 +18,16 @@ int orinoco_mic_init(struct orinoco_private *priv)
 {
 	priv->tx_tfm_mic = crypto_alloc_shash("michael_mic", 0, 0);
 	if (IS_ERR(priv->tx_tfm_mic)) {
-		printk(KERN_DEBUG "orinoco_mic_init: could not allocate "
-		       "crypto API michael_mic\n");
+		printk(KERN_DEBUG "%s: could not allocate "
+		       "crypto API michael_mic\n", __func__);
 		priv->tx_tfm_mic = NULL;
 		return -ENOMEM;
 	}
 
 	priv->rx_tfm_mic = crypto_alloc_shash("michael_mic", 0, 0);
 	if (IS_ERR(priv->rx_tfm_mic)) {
-		printk(KERN_DEBUG "orinoco_mic_init: could not allocate "
-		       "crypto API michael_mic\n");
+		printk(KERN_DEBUG "%s: could not allocate "
+		       "crypto API michael_mic\n", __func__);
 		priv->rx_tfm_mic = NULL;
 		return -ENOMEM;
 	}
@@ -52,7 +52,7 @@ int orinoco_mic(struct crypto_shash *tfm_michael, u8 *key,
 	int err;
 
 	if (tfm_michael == NULL) {
-		printk(KERN_WARNING "orinoco_mic: tfm_michael == NULL\n");
+		printk(KERN_WARNING "%s: tfm_michael == NULL\n", __func__);
 		return -1;
 	}
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · Keyur Patel

From: Keyur Patel <[email protected]>

Replace hard coded function name with __func__, to improve robustness and to conform to the Linux kernel coding style. Issue found using checkpatch.

Patch applied to wireless-drivers-next.git, thanks.

25f87d8b63b8 orinoco : Replace function name in string with __func__

Signature · 3 lines
https://patchwork.kernel.org/patch/10817203/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches