Skip to contentSkip to conversation

usb: core: Replace hardcoded check with inline function from usb.h

PATCH New Keyur Patel 1 participant 1 message Feb 19, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: core: Replace hardcoded check with inline function from usb.h

From: Keyur Patel <[email protected]>

Expression (urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN can be replaced by usb_urb_dir_in(struct urb *urb) from usb.h for better readability.

---
 drivers/usb/core/devio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/core/devio.c +1 -1
index d65566341dd1..29e2ff055e6e 100644
@@ -604,7 +604,7 @@ static void async_completed(struct urb *urb)
 	snoop(&urb->dev->dev, "urb complete\n");
 	snoop_urb(urb->dev, as->userurb, urb->pipe, urb->actual_length,
 			as->status, COMPLETE, NULL, 0);
-	if ((urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN)
+	if (usb_urb_dir_in(urb))
 		snoop_urb_data(urb, urb->actual_length);
 
 	if (as->status < 0 && as->bulk_addr && as->status != -ECONNRESET &&