Skip to contentSkip to conversation

libcurl: fix typo in configure option w/o OpenSSL

PATCH New Trent Piepho 3 participants 4 messages Feb 20, 2019 – Feb 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libcurl: fix typo in configure option w/o OpenSSL

When not using OpenSSL, the correct option to configure is --without-ssl with two dashes.

Fixes b8b78e7e6a ("libcurl: Allow selection of TLS package libcurl will use")
---
 package/libcurl/libcurl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcurl/libcurl.mk +1 -1
index 1fae41ea3a..509dbdb54e 100644
@@ -46,7 +46,7 @@ LIBCURL_CONF_ENV += LD_LIBRARY_PATH=$(if $(LD_LIBRARY_PATH),$(LD_LIBRARY_PATH):)
 LIBCURL_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr \
 	--with-ca-path=/etc/ssl/certs
 else
-LIBCURL_CONF_OPTS += -without-ssl
+LIBCURL_CONF_OPTS += --without-ssl
 endif
 
 ifeq ($(BR2_PACKAGE_LIBCURL_GNUTLS),y)
Signature · 1 line
2.14.4
#1 lore raw

PATCH 1/1 libcurl: fix typo in configure option w/o OpenSSL

Quoted 6 lines · Trent Piepho

When not using OpenSSL, the correct option to configure is --without-ssl with two dashes.

Fixes b8b78e7e6a ("libcurl: Allow selection of TLS package libcurl will use")

Applied to master, thanks.

Peter, this is for 2018.11.x

Regards,
Arnout

Quoted 18 lines
---
 package/libcurl/libcurl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcurl/libcurl.mk +1 -1
index 1fae41ea3a..509dbdb54e 100644
@@ -46,7 +46,7 @@ LIBCURL_CONF_ENV += LD_LIBRARY_PATH=$(if $(LD_LIBRARY_PATH),$(LD_LIBRARY_PATH):)
 LIBCURL_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr \
 	--with-ca-path=/etc/ssl/certs
 else
-LIBCURL_CONF_OPTS += -without-ssl
+LIBCURL_CONF_OPTS += --without-ssl
 endif
 
 ifeq ($(BR2_PACKAGE_LIBCURL_GNUTLS),y)
#2 lore raw

PATCH 1/1 libcurl: fix typo in configure option w/o OpenSSL

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 3 lines · Trent Piepho

When not using OpenSSL, the correct option to configure is --without-ssl with two dashes.

Quoted 7 lines
Quoted 3 lines
Fixes b8b78e7e6a ("libcurl: Allow selection of TLS package libcurl will use")

Applied to master, thanks.

Peter, this is for 2018.11.x

No it isn't:

git describe --contains b8b78e7e6a
2019.02-rc1~958^2~211

And it hasn't been backported to the 2018.11.x branch.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 libcurl: fix typo in configure option w/o OpenSSL

Quoted 10 lines · Peter Korsgaard
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 6 lines · Trent Piepho

When not using OpenSSL, the correct option to configure is --without-ssl with two dashes.

Fixes b8b78e7e6a ("libcurl: Allow selection of TLS package libcurl will use")
Quoted 8 lines
Quoted 3 lines

Applied to master, thanks.

Peter, this is for 2018.11.x

No it isn't:

git describe --contains b8b78e7e6a
2019.02-rc1~958^2~211

I thought I hade done exactly that... I guess I was doing too many things at
the same time :-)

Regards,
Arnout

Quoted 3 lines

And it hasn't been backported to the 2018.11.x branch.