Skip to contentSkip to conversation

cpufreq: Report if CPU doesn't report boost technologies

PATCH In review Erwan Velu 3 participants 5 messages Feb 20, 2019 CPU frequency scaling framework

lore
Share & tools
lore

Erwan Velu

author
#0 lore raw

PATCH 1/1 cpufreq: Report if CPU doesn't report boost technologies

There is some rare cases where CPB (and possibly IDA) are missing on processors.
This is the case fixed by commit f7f3dc00f612 ("x86/cpu/AMD: Fix erratum 1076 (CPB bit)") and following.

In such context, the boost status isn't reported by /sys/devices/system/cpu/cpufreq/boost.

This commit is about printing a message reporting the CPU doesn't expose the boost capabilities. This message could help debugging platforms hit by this phenomena.

---
 drivers/cpufreq/acpi-cpufreq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/cpufreq/acpi-cpufreq.c +3 -1
index d62fd374d5c7..06d32d21dac0 100644
@@ -916,8 +916,10 @@ static void __init acpi_cpufreq_boost_init(void)
 {
 	int ret;
 
-	if (!(boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA)))
+	if (!(boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA))) {
+		pr_debug("CPU doesn't expose boost capabilities\n");
 		return;
+	}
 
 	acpi_cpufreq_driver.set_boost = set_boost;
 	acpi_cpufreq_driver.boost_enabled = boost_state(0);
Signature · 1 line
2.20.1
#1 lore raw
Quoted 5 lines · Erwan Velu

There is some rare cases where CPB (and possibly IDA) are missing on processors.
This is the case fixed by commit f7f3dc00f612 ("x86/cpu/AMD: Fix erratum 1076 (CPB bit)") and following.

In such context, the boost status isn't reported by /sys/devices/system/cpu/cpufreq/boost.

So I'm not really sure why the extra message is needed. It looks like this message will always be printed (with debug output enabled) if the current cpufreq driver is acpi-cpufreq and the boost attribute is not present in sysfs, which only is the case if CPB/IDA aren't there.

Does it provide any additional information, then?

#2 lore raw

Le 20/02/2019 à 11:41, Rafael J. Wysocki a écrit :

Quoted 11 lines · Erwan Velu
Quoted 4 lines

There is some rare cases where CPB (and possibly IDA) are missing on processors.
This is the case fixed by commit f7f3dc00f612 ("x86/cpu/AMD: Fix erratum 1076 (CPB bit)") and following.

In such context, the boost status isn't reported by /sys/devices/system/cpu/cpufreq/boost.

So I'm not really sure why the extra message is needed. It looks like this message will always be printed (with debug output enabled) if the current cpufreq driver is acpi-cpufreq and the boost attribute is not present in sysfs, which only is the case if CPB/IDA aren't there.

Does it provide any additional information, then?

When you know and read the code, yes this patch is too obvious.

As a user when I was troubleshooting why the boost entry was _not_ populated on one CPU and was populated on another.

Running acpi-cpufreq with dyndbg, I would have found useful to get that hint.

So that could helps users that never read that part of the code and which are tricked into that configuration.

Erwan,

#3 lore raw
Quoted 17 lines · Erwan Velu
Quoted 11 lines · Rafael J. Wysocki
Quoted 4 lines · Erwan Velu

There is some rare cases where CPB (and possibly IDA) are missing on processors.
This is the case fixed by commit f7f3dc00f612 ("x86/cpu/AMD: Fix erratum 1076 (CPB bit)") and following.

In such context, the boost status isn't reported by /sys/devices/system/cpu/cpufreq/boost.

So I'm not really sure why the extra message is needed. It looks like this message will always be printed (with debug output enabled) if the current cpufreq driver is acpi-cpufreq and the boost attribute is not present in sysfs, which only is the case if CPB/IDA aren't there.

Does it provide any additional information, then?

When you know and read the code, yes this patch is too obvious.

Quoted 8 lines

As a user when I was troubleshooting why the boost entry was _not_ populated on one CPU and was populated on another.

Running acpi-cpufreq with dyndbg, I would have found useful to get that hint.

So that could helps users that never read that part of the code and which are tricked into that configuration.

OK, I see your point.

I'll queue up the patch, but I guess I'll change the message.

author
#4 lore raw

I tried to put the message in a way to stay neutral, not saying if its a real error or not.
Just reporting we were not able to find any boost cap on it. Erwan,

Quoted 31 lines · Rafael J. Wysocki
Quoted 17 lines · Erwan Velu
Quoted 11 lines · Rafael J. Wysocki
Quoted 4 lines · Erwan Velu

There is some rare cases where CPB (and possibly IDA) are missing on processors.
This is the case fixed by commit f7f3dc00f612 ("x86/cpu/AMD: Fix erratum 1076 (CPB bit)") and following.

In such context, the boost status isn't reported by /sys/devices/system/cpu/cpufreq/boost.

So I'm not really sure why the extra message is needed. It looks like this message will always be printed (with debug output enabled) if the current cpufreq driver is acpi-cpufreq and the boost attribute is not present in sysfs, which only is the case if CPB/IDA aren't there.

Does it provide any additional information, then?

When you know and read the code, yes this patch is too obvious.

Quoted 8 lines

As a user when I was troubleshooting why the boost entry was _not_ populated on one CPU and was populated on another.

Running acpi-cpufreq with dyndbg, I would have found useful to get that hint.

So that could helps users that never read that part of the code and which are tricked into that configuration.

OK, I see your point.

I'll queue up the patch, but I guess I'll change the message.