shippable: fix build
PATCH 1/1 shippable: fix build
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directory
Add an explicit "make" step to fix it.
--- tests/docker/dockerfiles/debian-amd64.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/debian-amd64.docker +1 -1
@@ -33,7 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap -RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install +RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make && make install ENV QEMU_CONFIGURE_OPTS --enable-netmap RUN ldconfig
Signature · 1 line
2.20.1
Quoted 6 lines · Paolo Bonzini
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
I took an alternate approach as tracking another projects master seems like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream. Let's use a defined release so things don't magically change under us.
1 file changed, 1 insertion(+)
tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
apt-get install -y --no-install-recommends \
linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
+RUN cd /usr/src/netmap && git checkout v11.3
RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install ENV QEMU_CONFIGURE_OPTS --enable-netmap
<snip>
--
Alex Bennée
Quoted 9 lines · Alex Bennée
Quoted 6 lines · Paolo Bonzini
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
Quoted 7 lines
I took an alternate approach as tracking another projects master seems like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream. Let's use a defined release so things don't magically change under us.
Oh now I see your reply...
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 36
Quoted 11 lines
Signed-off-by Alex Bennée <[email protected]>1 file changed, 1 insertion(+)tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
tests/docker/dockerfiles/debian-amd64.docker +1
-0@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap +RUN cd /usr/src/netmap && git checkout v11.3
... and I notice I forgot to change directory in my previous suggestion.
Why do you take v11.3 and not v11.4?
I agree v11.3 was closer to what I tested when I introduced this dependency, but I'd rather use the latest release.
Regards,
Phil.
Quoted 9 lines
(quoted diff) +0
-1RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install ENV QEMU_CONFIGURE_OPTS --enable-netmap --Alex Bennée
Quoted 34 lines · Philippe Mathieu-Daudé
Quoted 9 lines · Alex Bennée
Quoted 6 lines · Paolo Bonzini
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
Quoted 7 lines
I took an alternate approach as tracking another projects master seems like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream. Let's use a defined release so things don't magically change under us.
Oh now I see your reply...
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 36
Quoted 11 lines
Signed-off-by Alex Bennée <[email protected]>1 file changed, 1 insertion(+)tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
tests/docker/dockerfiles/debian-amd64.docker +1
-0@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap +RUN cd /usr/src/netmap && git checkout v11.3... and I notice I forgot to change directory in my previous suggestion.
Quoted 3 lines
Why do you take v11.3 and not v11.4?
I agree v11.3 was closer to what I tested when I introduced this dependency, but I'd rather use the latest release.
Hmm github hid the newer releases by default and has a Latest Release button by v11.3.
--
Alex Bennée
Quoted 37 lines · Alex Bennée
Quoted 34 lines · Philippe Mathieu-Daudé
Quoted 9 lines · Alex Bennée
Quoted 6 lines · Paolo Bonzini
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
Quoted 7 lines
I took an alternate approach as tracking another projects master seems like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream. Let's use a defined release so things don't magically change under us.
Oh now I see your reply...
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 36
Quoted 11 lines
Signed-off-by Alex Bennée <[email protected]>1 file changed, 1 insertion(+)tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
tests/docker/dockerfiles/debian-amd64.docker +1
-0@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap +RUN cd /usr/src/netmap && git checkout v11.3... and I notice I forgot to change directory in my previous suggestion.
Quoted 6 lines
Quoted 3 lines
Why do you take v11.3 and not v11.4?
I agree v11.3 was closer to what I tested when I introduced this dependency, but I'd rather use the latest release.Hmm github hid the newer releases by default and has a Latest Release button by v11.3.
I don't understand (this GitHub feature)...
I'm talking about this release:
https://github.com/luigirizzo/netmap/releases/tag/v11.4
The date is more recent that the v11.3. This looks like the latest release to me.
Anyway I'm fine if you prefer v11.3.
Please send a formal patch because I don't want to confuse scripts adding my R-b in Paolo's patch.
Regards,
Phil.
CCing Vincenzo, one of the maintainer of Netmap.
Quoted 61 lines · Philippe Mathieu-Daudé
Quoted 37 lines · Alex Bennée
Quoted 34 lines · Philippe Mathieu-Daudé
Quoted 9 lines · Alex Bennée
Quoted 6 lines · Paolo Bonzini
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
Quoted 7 lines
I took an alternate approach as tracking another projects master seems like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream. Let's use a defined release so things don't magically change under us.
Oh now I see your reply...
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 36
Quoted 11 lines
Signed-off-by Alex Bennée <[email protected]>1 file changed, 1 insertion(+)tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
tests/docker/dockerfiles/debian-amd64.docker +1
-0@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap +RUN cd /usr/src/netmap && git checkout v11.3... and I notice I forgot to change directory in my previous suggestion.
Quoted 6 lines
Quoted 3 lines
Why do you take v11.3 and not v11.4?
I agree v11.3 was closer to what I tested when I introduced this dependency, but I'd rather use the latest release.Hmm github hid the newer releases by default and has a Latest Release button by v11.3.
I don't understand (this GitHub feature)...
I'm talking about this release:
https://github.com/luigirizzo/netmap/releases/tag/v11.4The date is more recent that the v11.3. This looks like the latest release to me.
Anyway I'm fine if you prefer v11.3.
Please send a formal patch because I don't want to confuse scripts adding my R-b in Paolo's patch.Regards,
Phil.
Signature · 2 lines
Stefano Garzarella Software Engineer @ Red Hat
Hi,
Yes, we added a static library that to ease application development
(libnetmap.a).
It looks like a configure/Makefile issue. Can you reproduce that?
(I'm CC-ing Giuseppe, who actually added libnetmap).
Cheers,
Vincenzo
Il giorno gio 21 feb 2019 alle ore 10:14 Stefano Garzarella < [email protected]> ha scritto:
Quoted 74 lines
CCing Vincenzo, one of the maintainer of Netmap.
Quoted 7 lines · Philippe Mathieu-Daudé
Quoted 6 lines · Alex Bennée
Quoted 3 lines · Philippe Mathieu-Daudé
Quoted 2 lines · Alex Bennée
Paolo Bonzini <[email protected]> writes:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
I took an alternate approach as tracking another projects master
seems
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream. Let's use a defined release so things don't magically change under
us.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Oh now I see your reply...
Quoted 2 lines
Signed-off-by Alex Bennée <[email protected]>Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 35
Quoted 8 lines
1 file changed, 1 insertion(+)tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
tests/docker/dockerfiles/debian-amd64.docker +0
-0@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git
/usr/src/netmapQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Review RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 36
Quoted 1 line
(quoted diff) +1
-0+RUN cd /usr/src/netmap && git checkout v11.3... and I notice I forgot to change directory in my previous
suggestion.
Quoted 16 lines
Quoted 7 lines
Quoted 4 lines
Why do you take v11.3 and not v11.4?
I agree v11.3 was closer to what I tested when I introduced this dependency, but I'd rather use the latest release.Hmm github hid the newer releases by default and has a Latest Release button by v11.3.
I don't understand (this GitHub feature)...
I'm talking about this release:
https://github.com/luigirizzo/netmap/releases/tag/v11.4The date is more recent that the v11.3. This looks like the latest release to me.
Quoted 8 lines
Anyway I'm fine if you prefer v11.3.
Please send a formal patch because I don't want to confuse scripts adding my R-b in Paolo's patch.Regards,
Phil.
--
Stefano Garzarella
Software Engineer @ Red Hat
Signature · 1 line
Vincenzo
Hi Paolo,
Please also Cc reviewers :)
Quoted 1 line · Paolo Bonzini
It looks like something in netmap has changed and compilation fails:
Partly my fault, I had the intention to add a git 'stable' tag for reproducible builds [*] but forgot to add to my TODO list :/
[*] https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02028.html
Quoted 16 lines
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directoryAdd an explicit "make" step to fix it.
Signed-off-by Paolo Bonzini <[email protected]>--- tests/docker/dockerfiles/debian-amd64.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/docker/dockerfiles/debian-amd64.docker +0
-0
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 35
Quoted 3 lines
tests/docker/dockerfiles/debian-amd64.docker +0
-0@@ -33,7 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ apt-get install -y --no-install-recommends \ linux-headers-amd64 RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
So the fix would be:
- RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
+ RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap && \
git checkout v11.4
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 36
Quoted 2 lines
tests/docker/dockerfiles/debian-amd64.docker +1
-1-RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install +RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make && make install
Your change doesn't hurt.
tests/docker/dockerfiles/debian-amd64.docker RUN DEBIAN_FRONTEND=noninteractive eatmydata \ · line 39
Quoted 4 lines
tests/docker/dockerfiles/debian-amd64.docker +0
-0ENV QEMU_CONFIGURE_OPTS --enable-netmap RUN ldconfig
Regards,
Phil.