Skip to contentSkip to conversation

kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2.

PATCH In review Maarten Lankhorst via igt-dev 4 participants 6 messages Feb 14, 2019 – Feb 27, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2.

Newer platforms don't support this format, but the tests don't check if the format is supported on the primary plane.

After enabling an output we also don't refresh the output connection, calling igt_output_set_pipe(output, PIPE_NONE) will do so, and prevent skips because no connected output is detected.

Changes since v1:
- Use igt_plane_has_format_mod (Ville).

---
 tests/kms_chamelium.c | 6 ++++++
 1 file changed, 6 insertions(+)
tests/kms_chamelium.c +6 -0
index 64f87d3ae474..cab7d751379d 100644
@@ -436,6 +436,9 @@ prepare_output(data_t *data,
 
 	output = igt_output_from_connector(display, connector);
 
+	/* Refresh pipe to update connected status */
+	igt_output_set_pipe(output, PIPE_NONE);
+
 	for_each_pipe(display, pipe) {
 		if (!igt_pipe_connector_valid(pipe, output))
 			continue;
@@ -614,6 +617,8 @@ static void test_display_one_mode(data_t *data, struct chamelium_port *port,
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_assert(primary);
 
+	igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
+
 	mode = &connector->modes[0];
 	if (check == CHAMELIUM_CHECK_ANALOG) {
 		bool bridge = check_analog_bridge(data, port);
@@ -642,6 +647,7 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
 	connector = chamelium_port_get_connector(data->chamelium, port, false);
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_assert(primary);
+	igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
 
 	if (check == CHAMELIUM_CHECK_ANALOG)
 		bridge = check_analog_bridge(data, port);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2.

== Series Details ==

== Series Details ==

Series: kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2.
URL : https://patchwork.freedesktop.org/series/56675/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5599 -> IGTPW_2403
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2403 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2403, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56675/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2403:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live_workarounds:
- fi-kbl-x1275: PASS -> INCOMPLETE

Known issues
------------

Here are the changes found in IGTPW_2403 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#105602] / [fdo#108529] +1

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#102505] / [fdo#103558] / [fdo#105079] / [fdo#105602]
- fi-kbl-7567u: PASS -> DMESG-FAIL [fdo#105079]

* igt@pm_rpm@basic-rte:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#108800]

* igt@pm_rpm@module-reload:
- fi-kbl-7567u: PASS -> DMESG-WARN [fdo#108529]

#### Possible fixes ####

* igt@i915_module_load@reload:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

* igt@i915_selftest@live_workarounds:
- {fi-icl-u3}: INCOMPLETE [fdo#109626] -> PASS

* igt@kms_busy@basic-flip-a:
- fi-gdg-551: FAIL [fdo#103182] -> PASS

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: DMESG-FAIL [fdo#109627] -> PASS

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109626]: https://bugs.freedesktop.org/show_bug.cgi?id=109626
[fdo#109627]: https://bugs.freedesktop.org/show_bug.cgi?id=109627

Participating hosts (43 -> 43)
------------------------------

Additional (6): fi-skl-6260u fi-whl-u fi-ivb-3770 fi-bsw-kefka fi-kbl-7560u fi-snb-2600
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-skl-6700hq fi-bdw-samus

Build changes
-------------

* IGT: IGT_4824 -> IGTPW_2403

CI_DRM_5599: 39119c9b385742d49446c25d6902864a60eda6b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2403: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2403/
IGT_4824: e55d439a9ba744227fb4c9d727338276b78871d4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2403/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2. (rev2)

In reply to Maarten Lankhorst via igt-dev
== Series Details ==

== Series Details ==

Series: kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2. (rev2)
URL : https://patchwork.freedesktop.org/series/56675/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5636 -> IGTPW_2454
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56675/revisions/2/mbox/

Known issues
------------

Here are the changes found in IGTPW_2454 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_busy@basic-flip-a:
- fi-gdg-551: PASS -> FAIL [fdo#103182]

* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +43

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- fi-icl-u2: INCOMPLETE [fdo#108569] -> DMESG-FAIL [fdo#108569]

[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485

Participating hosts (46 -> 40)
------------------------------

Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ilk-650 fi-bdw-samus

Build changes
-------------

* IGT: IGT_4842 -> IGTPW_2454

CI_DRM_5636: b33b7e4ffb889d3d3e03ad9b64d0fe15dd2184b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2454: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2454/
IGT_4842: 54e0e8b14f128919a0dbeb4d4f7b4fbbe30b5f60 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2454/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2. (rev2)

In reply to Maarten Lankhorst via igt-dev
== Series Details ==

== Series Details ==

Series: kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2. (rev2)
URL : https://patchwork.freedesktop.org/series/56675/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5636_full -> IGTPW_2454_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/56675/revisions/2/mbox/

Known issues
------------

Here are the changes found in IGTPW_2454_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mocs_settings@mocs-settings-bsd1:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +2

* igt@kms_atomic_transition@3x-modeset-transitions-fencing:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]

* igt@kms_color@pipe-b-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]

* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5

* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-glk: NOTRUN -> FAIL [fdo#103232]

* igt@kms_flip@busy-flip:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]

* igt@kms_force_connector_basic@force-connector-state:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +12

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +6

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +6

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +29

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +19

* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-glk: NOTRUN -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +2

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-kbl: NOTRUN -> FAIL [fdo#103166]

* igt@kms_plane_scaling@pipe-a-scaler-with-rotation:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4

* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> FAIL [fdo#109016]

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]

* igt@kms_universal_plane@cursor-fb-leak-pipe-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

* igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
- shard-apl: PASS -> FAIL [fdo#104894]

* igt@perf_pmu@rc6-runtime-pm-long:
- shard-apl: PASS -> FAIL [fdo#105010]
- shard-kbl: PASS -> FAIL [fdo#105010]

#### Possible fixes ####

* igt@gem_exec_big:
- shard-hsw: TIMEOUT [fdo#107937] -> PASS

* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS +1

* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +1

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-kbl: FAIL [fdo#109350] -> PASS
- shard-apl: FAIL [fdo#109350] -> PASS

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: FAIL [fdo#105767] -> PASS

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-glk: FAIL [fdo#100368] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-kbl: FAIL [fdo#103166] -> PASS

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS +1

* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS +2

* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +1

* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS

* igt@kms_vblank@pipe-b-ts-continuation-modeset:
- shard-apl: FAIL [fdo#104894] -> PASS +2

[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107937]: https://bugs.freedesktop.org/show_bug.cgi?id=107937
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4842 -> IGTPW_2454
* Piglit: piglit_4509 -> None

CI_DRM_5636: b33b7e4ffb889d3d3e03ad9b64d0fe15dd2184b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2454: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2454/
IGT_4842: 54e0e8b14f128919a0dbeb4d4f7b4fbbe30b5f60 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2454/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#4 lore raw
In reply to Maarten Lankhorst via igt-dev
Quoted 2 lines · Maarten Lankhorst

Newer platforms don't support this format, but the tests don't check if the format is supported on the primary plane.

This sentence is rather confusing. Maybe "Not all hardware supports all formats, but ..." ?

Otherwise the patch seems sensible to me

Quoted 46 lines

After enabling an output we also don't refresh the output connection, calling igt_output_set_pipe(output, PIPE_NONE) will do so, and prevent skips because no connected output is detected.

Changes since v1:
- Use igt_plane_has_format_mod (Ville).

---
 tests/kms_chamelium.c | 6 ++++++
 1 file changed, 6 insertions(+)
tests/kms_chamelium.c +6 -0
index 64f87d3ae474..cab7d751379d 100644
@@ -436,6 +436,9 @@ prepare_output(data_t *data,
 
 	output = igt_output_from_connector(display, connector);
 
+	/* Refresh pipe to update connected status */
+	igt_output_set_pipe(output, PIPE_NONE);
+
 	for_each_pipe(display, pipe) {
 		if (!igt_pipe_connector_valid(pipe, output))
 			continue;
@@ -614,6 +617,8 @@ static void test_display_one_mode(data_t *data, struct chamelium_port *port,
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_assert(primary);
 
+	igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
+
 	mode = &connector->modes[0];
 	if (check == CHAMELIUM_CHECK_ANALOG) {
 		bool bridge = check_analog_bridge(data, port);
@@ -642,6 +647,7 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
 	connector = chamelium_port_get_connector(data->chamelium, port, false);
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_assert(primary);
+	igt_require(igt_plane_has_format_mod(primary, fourcc, LOCAL_DRM_FORMAT_MOD_NONE));
 
 	if (check == CHAMELIUM_CHECK_ANALOG)
 		bridge = check_analog_bridge(data, port);
Signature · 1 line
2.20.1
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

Op 25-02-2019 om 20:10 schreef Ville Syrjälä:

Quoted 8 lines · Maarten Lankhorst
Quoted 2 lines

Newer platforms don't support this format, but the tests don't check if the format is supported on the primary plane.

This sentence is rather confusing. Maybe "Not all hardware supports all formats, but ..." ?

Otherwise the patch seems sensible to me

Oops, forgot to change the commit message here, but pushed. :)

Thanks for review. Will add a mental note to be more careful in the future.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev