percpu: use nr_groups as check condition
Subsystems (2)
RFC 1/1 percpu: use nr_groups as check condition
group_cnt array is defined with NR_CPUS entries, but normally nr_groups will not reach up to NR_CPUS. So there is no issue to the current code.
Checking other parts of pcpu_build_alloc_info, use nr_groups as check condition, so make it consistent to use 'group < nr_groups' as for loop check. In case we do have nr_groups equals with NR_CPUS, we could also avoid memory access out of bounds.
--- mm/percpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/percpu.c +1 -1
@@ -2384,7 +2384,7 @@ static struct pcpu_alloc_info * __init pcpu_build_alloc_info( ai->atom_size = atom_size; ai->alloc_size = alloc_size; -for (group =0 , unit =0 ; group_cnt[group]; group++) { +for (group =0 , unit =0 ; group < nr_groups; group++) {struct pcpu_group_info *gi = &ai->groups[group];/*
Signature · 1 line
2.16.4
Dennis Zhou
maintainerHi Peng,
Quoted 30 lines · Peng Fan
group_cntarray is defined withNR_CPUSentries, but normallynr_groupswill not reach up toNR_CPUS. So there is no issue to the current code.Checking other parts of
pcpu_build_alloc_info, usenr_groupsas check condition, so make it consistent to use 'group <nr_groups' as for loop check. In case we do havenr_groupsequals withNR_CPUS, we could also avoid memory access out of bounds.Signed-off-by Peng Fan <[email protected]>--- mm/percpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/percpu.c +1
-1@@ -2384,7 +2384,7 @@ static struct pcpu_alloc_info * __init pcpu_build_alloc_info( ai->atom_size = atom_size; ai->alloc_size = alloc_size; -for (group =0 , unit =0 ; group_cnt[group]; group++) { +for (group =0 , unit =0 ; group < nr_groups; group++) {struct pcpu_group_info *gi = &ai->groups[group];/* Signature · 1 line
2.16.4
This seems right to me. It is quite the edge case though. I've queued this for 5.1.
Thanks,
Dennis