Skip to contentSkip to conversation

writeback.h: Removed duplicated declaration of tag_pages_for_writeback()

PATCH In review Qu Wenruo 2 participants 2 messages Feb 21, 2019

Subsystems (2)
lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 writeback.h: Removed duplicated declaration of tag_pages_for_writeback()

There are two commits introducing the same declaration, 92c09c041f15 ("mm: declare some external symbols") and 5b41d92437f1 ("ext4: implement writeback livelock avoidance using page tagging"), they are all introducing declaration for tag_pages_for_writeback(), just lines apart.

One declaration is enough.

---
 include/linux/writeback.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/writeback.h +0 -2
index 738a0c24874f..e926fa256c43 100644
@@ -371,8 +371,6 @@ int write_cache_pages(struct address_space *mapping,
 		      void *data);
 int do_writepages(struct address_space *mapping, struct writeback_control *wbc);
 void writeback_set_ratelimit(void);
-void tag_pages_for_writeback(struct address_space *mapping,
-			     pgoff_t start, pgoff_t end);
 
 void account_page_redirty(struct page *page);
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Qu Wenruo

There are two commits introducing the same declaration, 92c09c041f15 ("mm: declare some external symbols") and 5b41d92437f1 ("ext4: implement writeback livelock avoidance using page tagging"), they are all introducing declaration for tag_pages_for_writeback(), just lines apart.

One declaration is enough.

Quoted 18 lines
---
 include/linux/writeback.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/writeback.h +0 -2
index 738a0c24874f..e926fa256c43 100644
@@ -371,8 +371,6 @@ int write_cache_pages(struct address_space *mapping,
 		      void *data);
 int do_writepages(struct address_space *mapping, struct writeback_control *wbc);
 void writeback_set_ratelimit(void);
-void tag_pages_for_writeback(struct address_space *mapping,
-			     pgoff_t start, pgoff_t end);
 
 void account_page_redirty(struct page *page);