usb: xhci: fix build warning - missing prototype

Quoted 30 lines · Greg KH

Quoted 12 lines · Jean-Philippe Menil

Quoted 9 lines · Greg KH

Quoted 4 lines · Mathias Nyman

From: Jean-Philippe Menil <[email protected]>

Fix build warning when building drivers/usb/host/xhci-mem.o due to missing prototype for xhci_free_virt_devices_depth_first.

There is no normal "build warning", this is a sparse fixup, right?

Quoted 8 lines

Hi Greg,

this is a build warning, at least with W=1 :

drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes]
void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int
slot_id)

"W=1" is not a normal build option for anyone to use, except those that wish to find crazy issues like this :)

Also, if that is the only way it shows up, you should mention it in the changelog.

thanks,

Quoted 2 lines

greg k-h

Hmm, rereaind this mail from kernel-janitors
https://marc.info/?l=kernel-janitors&m=154178546220848&w=2
seem that you're right, this is not a normal option :)

Mathias, do you want me to re-send something?