iotests: drop unnecessary accel=kvm in 238
PATCH v2 1/1 iotests: drop unnecessary accel=kvm in 238
Test 238 does not require the kvm accelerator. TCG works fine.
Use the default accelerator instead of requiring kvm.
---
Vladimir, I have dropped the 235 change because I don't have time to figure out the kvm/tcg vs qtest differences or add a skip function. Sorry!
tests/qemu-iotests/238 | 1 - 1 file changed, 1 deletion(-)
tests/qemu-iotests/238 +0 -1
@@ -33,7 +33,6 @@ else: virtio_scsi_device = 'virtio-scsi-pci' vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm') vm.launch() log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
Signature · 1 line
2.20.1
Quoted 19 lines · Stefan Hajnoczi
Test 238 does not require the kvm accelerator. TCG works fine.
Use the default accelerator instead of requiring kvm.
Suggested-by Thomas Huth <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>---
Vladimir, I have dropped the 235 change because I don't have time to figure out the kvm/tcg vs qtest differences or add a skip function. Sorry!tests/qemu-iotests/238 | 1 - 1 file changed, 1 deletion(-)tests/qemu-iotests/238 +0
-0
tests/qemu-iotests/238 else: · line 36
Quoted 4 lines
tests/qemu-iotests/238 +0
-1@@ -33,7 +33,6 @@ else: virtio_scsi_device = 'virtio-scsi-pci' vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm')
Would it be feasible to change it into "accel=qtest" instead? ... then this test would also work when QEMU has been compiled with --disable-tcg and when KVM is not available...
Thomas
Quoted 22 lines · Thomas Huth
Quoted 21 lines · Stefan Hajnoczi
Test 238 does not require the kvm accelerator. TCG works fine.
Use the default accelerator instead of requiring kvm.
Suggested-by Thomas Huth <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>---
Vladimir, I have dropped the 235 change because I don't have time to figure out the kvm/tcg vs qtest differences or add a skip function. Sorry!tests/qemu-iotests/238 | 1 - 1 file changed, 1 deletion(-)tests/qemu-iotests/238 +0
-0@@ -33,7 +33,6 @@ else: virtio_scsi_device = 'virtio-scsi-pci'
Quoted 6 lines
tests/qemu-iotests/238 else: · line 36
Quoted 2 lines
tests/qemu-iotests/238 +0
-1vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm')Would it be feasible to change it into "accel=qtest" instead? ... then this test would also work when QEMU has been compiled with --disable-tcg and when KVM is not available...
Sure. I have tested that qtest still triggered the bug when the fix was merged.
Will fix in v3.
Stefan