Skip to contentSkip to conversation

drivers: qcom: Fixes in RPMh driver

PATCH In review Raju P.L.S.S.S.N 2 participants 4 messages Feb 21, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover drivers: qcom: Fixes in RPMh driver

Hi,

This series consists of couple of fixes identified in RPMh driver. Please consider reviewing the patches.

Maulik Shah (1):
drivers: soc: qcom: rpmh-rsc: Correct check for slot number

Raju P.L.S.S.S.N (1):
drivers: qcom: rpmh: avoid sending sleep/wake sets immediately

 drivers/soc/qcom/rpmh-rsc.c | 2 +-
 drivers/soc/qcom/rpmh.c     | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of the Code Aurora Forum, hosted by The Linux Foundation.
#1 lore raw

PATCH 1/2 drivers: qcom: rpmh: avoid sending sleep/wake sets immediately

Fix the redundant call being made to send the sleep and wake requests immediately to the controller.

As per the patch[1], the sleep and wake request votes are cached in rpmh controller and sent during rpmh_flush(). These requests needs to be sent only during entry of deeper system low power modes or suspend.

[1] https://patchwork.kernel.org/patch/10477533/

---
 drivers/soc/qcom/rpmh.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/soc/qcom/rpmh.c +1 -2
index e6e98d461121..877fe78199a3 100644
@@ -228,9 +228,8 @@ static int __rpmh_write(const struct device *dev, enum rpmh_state state,
 		WARN_ON(irqs_disabled());
 		ret = rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg);
 	} else {
-		ret = rpmh_rsc_write_ctrl_data(ctrlr_to_drv(ctrlr),
-				&rpm_msg->msg);
 		/* Clean up our call by spoofing tx_done */
+		ret = 0;
 		rpmh_tx_done(&rpm_msg->msg, ret);
 	}
 
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of the Code Aurora Forum, hosted by The Linux Foundation.
#2 lore raw

PATCH 2/2 drivers: soc: qcom: rpmh-rsc: Correct check for slot number

In reply to Raju P.L.S.S.S.N

From: Maulik Shah <[email protected]>

The return index value from bitmap_find_next_zero_area can be higher than available slot. So correct the check to return error in such case.

---
 drivers/soc/qcom/rpmh-rsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/rpmh-rsc.c +1 -1
index 10b3102298c7..3ff3bebd4d71 100644
@@ -491,7 +491,7 @@ static int find_slots(struct tcs_group *tcs, const struct tcs_request *msg,
 	do {
 		slot = bitmap_find_next_zero_area(tcs->slots, MAX_TCS_SLOTS,
 						  i, msg->num_cmds, 0);
-		if (slot == tcs->num_tcs * tcs->ncpt)
+		if (slot >= tcs->num_tcs * tcs->ncpt)
 			return -ENOMEM;
 		i += tcs->ncpt;
 	} while (slot + msg->num_cmds - 1 >= i);
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of the Code Aurora Forum, hosted by The Linux Foundation.
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH v1 2/2] drivers: soc: qcom: rpmh-rsc: Correct check for slot number

Quoted 7 lines · Raju P.L.S.S.S.N

From: Maulik Shah <[email protected]>

The return index value from bitmap_find_next_zero_area can be higher than available slot. So correct the check to return error in such case.

Quoted 21 lines

---
drivers/soc/qcom/rpmh-rsc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/rpmh-rsc.c +1 -2
index 10b3102298c7..3ff3bebd4d71 100644
@@ -491,7 +491,7 @@ static int find_slots(struct tcs_group *tcs, const struct tcs_request *msg,
 	do {
 		slot = bitmap_find_next_zero_area(tcs->slots, MAX_TCS_SLOTS,
 						  i, msg->num_cmds, 0);
-		if (slot == tcs->num_tcs * tcs->ncpt)
+		if (slot >= tcs->num_tcs * tcs->ncpt)
 			return -ENOMEM;
 		i += tcs->ncpt;
 	} while (slot + msg->num_cmds - 1 >= i);
--

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.