Skip to contentSkip to conversation

Staging: fbtft: Fix Various Checkpatch issues

PATCH In review Bhanusree Pola 2 participants 4 messages Feb 21, 2019

lore
Share & tools
lore
#0 lore raw

cover Staging: fbtft: Fix Various Checkpatch issues

This series cleans the following checkpatch.pl issues:

CHECK: Extra blank line not required before closing brace '}' WARNING:EXPORT_SYMBOL(foo); should follow its function/variable WARNING:line over 80 characters

Bhanusree Pola (3):
Staging: fbtft: Remove extra blank line before '}'
Staging: fbtf: Declare Exprot symbols immediately
Staging: fbtft: Fix line over 80 characters warning

 drivers/staging/fbtft/fbtft-core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Bhanusree Pola

This series cleans the following checkpatch.pl issues:

CHECK: Extra blank line not required before closing brace '}' WARNING:EXPORT_SYMBOL(foo); should follow its function/variable WARNING:line over 80 characters

Quoted 7 lines

Bhanusree Pola (3):
Staging: fbtft: Remove extra blank line before '}'
Staging: fbtf: Declare Exprot symbols immediately
Staging: fbtft: Fix line over 80 characters warning

 drivers/staging/fbtft/fbtft-core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Your patches are not "threaded", like I asked for last time. How are you sending these out? git send-email should do it automatically.

thanks,

greg k-h

#2 lore raw
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Bhanusree Pola

This series cleans the following checkpatch.pl issues:

CHECK: Extra blank line not required before closing brace '}' WARNING:EXPORT_SYMBOL(foo); should follow its function/variable WARNING:line over 80 characters

Bhanusree Pola (3):
Staging: fbtft: Remove extra blank line before '}'
Staging: fbtf: Declare Exprot symbols immediately
Staging: fbtft: Fix line over 80 characters warning

Quoted 6 lines
Quoted 2 lines
 drivers/staging/fbtft/fbtft-core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Your patches are not "threaded", like I asked for last time. How are you sending these out? git send-email should do it automatically.

i'm sending each patch separately using mutt.

#3 lore raw
Quoted 15 lines · Bhanusree Mahesh
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Bhanusree Pola

This series cleans the following checkpatch.pl issues:

CHECK: Extra blank line not required before closing brace '}' WARNING:EXPORT_SYMBOL(foo); should follow its function/variable WARNING:line over 80 characters

Bhanusree Pola (3):
Staging: fbtft: Remove extra blank line before '}'
Staging: fbtf: Declare Exprot symbols immediately
Staging: fbtft: Fix line over 80 characters warning

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
 drivers/staging/fbtft/fbtft-core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Your patches are not "threaded", like I asked for last time. How are you sending these out? git send-email should do it automatically.

i'm sending each patch separately using mutt.

Ok, when doing that, make sure you properly thread them. You can do that by "replying" to the previous email you sent, and keeping the "In-Reply-To:" line in the header.

Or you can use git send-email :)

You might want to get send-email working, as you are sending lots of patches, it makes things much easier.

thanks,

greg k-h