Staging: fbtft: Declare Exprot symbols immediately
Subsystems (2)
PATCH 2/3 Staging: fbtft: Declare Exprot symbols immediately
Declaring EXPORT_SYMBOLS immediately after function/variable would be more appropriate.
This solves the checkpatch.pl warning:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by Bhanusree Pola <[email protected]>
--- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-core.c +2 -2
@@ -212,10 +212,10 @@ void fbtft_register_backlight(struct fbtft_par *par) }#else void fbtft_register_backlight (struct fbtft_par *par) { }; -void fbtft_unregister_backlight (struct fbtft_par *par) { }; -#endif EXPORT_SYMBOL (fbtft_register_backlight); +void fbtft_unregister_backlight (struct fbtft_par *par) { };EXPORT_SYMBOL (fbtft_unregister_backlight); +#endif static void fbtft_set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye)
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerQuoted 15 lines · Bhanusree Pola
Declaring
EXPORT_SYMBOLSimmediately after function/variable would be more appropriate.
This solves the checkpatch.pl warning:
WARNING:EXPORT_SYMBOL(foo); should immediately follow its function/variableSigned-off-by Bhanusree Pola <[email protected]>--- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/fbtft/fbtft-core.c +0
-0
drivers/staging/fbtft/fbtft-core.c void fbtft_register_backlight(struct fbtft_par *par) · line 218
Quoted 9 lines
drivers/staging/fbtft/fbtft-core.c +2
-2@@ -212,10 +212,10 @@ void fbtft_register_backlight(struct fbtft_par *par) }#else void fbtft_register_backlight (struct fbtft_par *par) { }; -void fbtft_unregister_backlight (struct fbtft_par *par) { }; -#endif EXPORT_SYMBOL (fbtft_register_backlight); +void fbtft_unregister_backlight (struct fbtft_par *par) { };EXPORT_SYMBOL (fbtft_unregister_backlight); +#endif
Nah, the original is nicer to read, I would just leave it alone.
thanks,
greg k-h