Skip to contentSkip to conversation

vf610-zii-dev-rev-b SPI fails at boot

BUG In review Russell King - ARM Linux admin 4 participants 4 messages Feb 21, 2019 SPI

lore
Share & tools
lore
#0 lore raw

While booting 4.20 on the ZII development revision B board, I notice this in the kernel logs:

spi spi0.1: setup: unsupported mode bits 4
spi_gpio spi0: can't setup spi0.1, status -22 spi_master spi0: spi_device register error /spi0/at93c46d@1 spi_master spi0: Failed to create SPI device for /spi0/at93c46d@1

This is for the at93c46d@1 device attached to spi-gpio (see arch/arm/boot/dts/vf610-zii-dev-rev-b.dts around line 330). This is declared with "spi-cs-high;" in DT. It appears to be complaining about the SPI_CS_HIGH flag.

It appears this warning comes from drivers/spi/spi.c around lines 2828-2847 due to:

	bad_bits = spi->mode & ~(spi->controller->mode_bits | SPI_CS_WORD);

and it looks like spi-gpio sets:

	master->mode_bits = SPI_3WIRE | SPI_CPHA | SPI_CPOL;

but then goes on to set:

	spi_gpio->bitbang.flags = SPI_CS_HIGH;

However, this is ignored by bitbang if master->mode_bits has already been set:

	if (!master->mode_bits)
		master->mode_bits = SPI_CPOL | SPI_CPHA | bitbang->flags;

It looks like this commit introduced for v4.19 broke the driver:

commit 4b859db2c60692560afbfef1b030d0ddef57b7ee

Author: Lorenzo Bianconi <[email protected]>
Date:   Sat Jul 28 10:19:14 2018 +0200

by setting master->mode_bits - prior to this, bitbang would have set the mode bits itself.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#1 lore raw

PATCH 1/1 spi: spi-gpio: fix SPI_CS_HIGH capability

spi-gpio is capable of dealing with active-high chip-selects. Unfortunately, commit 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support") broke this by setting master->mode_bits, which overrides the setting in the spi-bitbang code. Fix this.

Fixes 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support")

---
Patch against 4.20

 drivers/spi/spi-gpio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/spi/spi-gpio.c +1 -2
index 45973ee3ae11..2d7cfe3c7732 100644
@@ -410,7 +410,7 @@ static int spi_gpio_probe(struct platform_device *pdev)
 		return status;
 
 	master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32);
-	master->mode_bits = SPI_3WIRE | SPI_CPHA | SPI_CPOL;
+	master->mode_bits = SPI_3WIRE | SPI_CPHA | SPI_CPOL | SPI_CS_HIGH;
 	master->flags = master_flags;
 	master->bus_num = pdev->id;
 	/* The master needs to think there is a chipselect even if not connected */
@@ -437,7 +437,6 @@ static int spi_gpio_probe(struct platform_device *pdev)
 		spi_gpio->bitbang.txrx_word[SPI_MODE_3] = spi_gpio_spec_txrx_word_mode3;
 	}
 	spi_gpio->bitbang.setup_transfer = spi_bitbang_setup_transfer;
-	spi_gpio->bitbang.flags = SPI_CS_HIGH;
 
 	status = spi_bitbang_start(&spi_gpio->bitbang);
 	if (status)
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH] spi: spi-gpio: fix SPI_CS_HIGH capability

Quoted 10 lines · Russell King

spi-gpio is capable of dealing with active-high chip-selects. Unfortunately, commit 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support") broke this by setting master->mode_bits, which overrides the setting in the spi-bitbang code. Fix this.

Fixes 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support")

---
Patch against 4.20

Adding Jonathan who sent a similar fix recently:
https://patchwork.kernel.org/patch/10804855/

#3 lore raw

Re: [PATCH] spi: spi-gpio: fix SPI_CS_HIGH capability

Quoted 7 lines · Fabio Estevam
Quoted 6 lines · Russell King

spi-gpio is capable of dealing with active-high chip-selects. Unfortunately, commit 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support") broke this by setting master->mode_bits, which overrides the setting in the spi-bitbang code. Fix this.

Quoted 7 lines
Quoted 4 lines
Fixes 4b859db2c606 ("spi: spi-gpio: add SPI_3WIRE support")

---
Patch against 4.20

Adding Jonathan who sent a similar fix recently:
https://patchwork.kernel.org/patch/10804855/

Hello Russel,

your patch looks better, and I think Mark Brown has already applied it.

Thanks.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel